Bug 161980

Summary:	Make some member class static
Product:	[Eclipse Project] JDT	Reporter:	Olivier Thomann <Olivier_Thomann>
Component:	Core	Assignee:	Olivier Thomann <Olivier_Thomann>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	3.3
Target Milestone:	3.3 M4
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Olivier Thomann

2006-10-23 12:54:23 EDT

Some member classes that never referenced the enclosing type should be static. This would prevent the creation of the this$0 synthetic field.
Potential candidates:
org.eclipse.jdt.internal.eval.CodeSnippetSkeleton$BinaryMethodSkeleton
classe org.eclipse.jdt.internal.core.util.BindingKeyParser$Scanner
org.eclipse.jdt.internal.core.search.matching.MatchLocator$WrappedCoreException
org.eclipse.jdt.internal.core.JavaModelManager$CompilationParticipants
org.eclipse.jdt.internal.core.JavaElementDeltaBuilder$ListItem
org.eclipse.jdt.internal.core.index.DiskIndex$IntList
org.eclipse.jdt.internal.core.dom.rewrite.RewriteEventStore$PropertyLocation
org.eclipse.jdt.internal.compiler.parser.diagnose.LexStream$Token
org.eclipse.jdt.internal.compiler.parser.diagnose.DiagnoseParser$StateInfo
org.eclipse.jdt.internal.compiler.parser.diagnose.DiagnoseParser$SecondaryRepairInfo
org.eclipse.jdt.internal.compiler.parser.diagnose.DiagnoseParser$RepairCandidate
org.eclipse.jdt.internal.codeassist.CompletionEngine$AcceptedType
org.eclipse.jdt.core.search.SearchEngine$TypeNameRequestorAdapter
org.eclipse.jdt.core.search.SearchEngine$ResultCollectorAdapter

Comment 1 Olivier Thomann

2006-11-23 20:38:13 EST

Released for 3.3M4

Comment 2 Frederic Fusier

2006-12-12 13:48:51 EST

Verified for 3.3 M4 using build I20061212-0010.

Following inner classes are still not static:
org.eclipse.jdt.internal.eval.CodeSnippetSkeleton$BinaryMethodSkeleton
org.eclipse.jdt.core.search.SearchEngine$TypeNameRequestorAdapter
org.eclipse.jdt.core.search.SearchEngine$ResultCollectorAdapter

I guess this was intentional...