Summary: | Linking to/from shortcuts is broken | ||
---|---|---|---|
Product: | [Modeling] GMF-Tooling (ARCHIVED) | Reporter: | Fedor Isakov <fisakov> |
Component: | Core | Assignee: | Project Inbox <gmp.gmf-tooling-inbox> |
Status: | NEW --- | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | ahunter.eclipse |
Version: | 2.0 | Keywords: | plan |
Target Milestone: | 3.0 | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Whiteboard: | |||
Bug Depends on: | 191820 | ||
Bug Blocks: |
Description
Fedor Isakov
2006-07-14 09:46:17 EDT
I'm not sure routes should be removed from model on deleting a shortcut to the element - corresponding element still present in another model, so links are still valid. Please, correct me if I'm wrong. So, i think this request should ask to correctly update links to/from shortcuts (by corresponding ConnectionEditPolicy). Same problem was described in this request: https://bugs.eclipse.org/bugs/show_bug.cgi?id=149547 No, connections shoulnd't be removed from the model on shortcut removal. As a matter of fact, the menu item saying "Delete from model" should not be allowed on shortcut at all, as it can only be removed from view. I may be wrong, but the way shortcuts removal is done now is IMO a quick hack: the *ItemSemanticEditPolicy returns *semantic* destroy element command with getElementToDestroy() overridden to return the *view*. I don't think this is the right way to do it. But then again, I may be wrong at judging what is "right" here. There is a related request concerning connections to shortcuts: bug# 132574. It may be wise to look for a solution that satisfies both. I see, so if the proper command will be executed for the shortcuts (delete from view instead of semantic delete command) it'll be ok. In addition we just have to change CanonicalEditPolicies in accordance with the request mentioned before. Since GMF 2.0 M6 was released April 5, 2007, doing a bulk move of all open Bugzillas currently on M6 to 2.0 M7. Owners will need to access if the issue really is targetted for 2.0 M7. Too many changes for RC2. Moving to the next version. Moving to the next version. [GMF Restructure] Bug 319140 : product GMF and component Generation was the original product and component for this bug |