Bug 149154

Summary:

BinaryMethod#getParameterNames() should not try to extract from attached javadoc for synthetics

Product:

[Eclipse Project] JDT

Reporter:

Markus Keller <markus.kell.r>

Component:

Core

Assignee:

Olivier Thomann <Olivier_Thomann>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

3.2

Target Milestone:

3.3 M6

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed fix	none

Description Markus Keller

2006-06-29 09:41:30 EDT

HEAD

BinaryMethod#getParameterNames() should not try to extract names from attached javadoc for synthetic methods. By construction, synthetic methods have no javadoc.

An exception could be bridge methods, which could use the parameter names of their original method. But I think even there, generated parameter names make it more clear that those methods are compiler-generated.

Steps to reproduce:
- run HEAD with a VM that makes your firewall show an alert when accessing untrusted internet servers
- open java.util.Collections from an 1.5 rt.jar
- in the Outline view, select access$000(Object, Object)

Comment 1 Olivier Thomann

2007-02-13 21:45:46 EST

Created attachment 58935 [details]
Proposed fix

Comment 2 Olivier Thomann

2007-02-14 09:58:02 EST

Added regression test org.eclipse.jdt.core.tests.model.AttachedJavadocTests#test022. This test ensures that the parameter names are arg0 and arg1, but it cannot check if there is a connection to the javadoc.
This needs to be tested manually following steps described in comment 0.
Released for 3.3M6.

Comment 3 David Audel

2007-03-20 13:13:22 EDT

Verified for 3.3 M6 using build I20070320-0010