Bug 146556

Summary:

Should refactor boolean fields into bits

Product:

[Eclipse Project] JDT

Reporter:

Philipe Mulet <philippe_mulet>

Component:

Core

Assignee:

Olivier Thomann <Olivier_Thomann>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

eric_jodet

Version:

3.2

Keywords:

performance

Target Milestone:

3.3 M7

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed patch for a subset of the issues	none
Patch for remaining issues	none

Description Philipe Mulet

2006-06-12 09:04:12 EDT

Performing a search of boolean field decl "* boolean" in search dialog, any match in AST should be converted for using a tagbit instead.

Comment 1 Jerome Lanneluc

2007-04-02 12:19:34 EDT

To be investigated during 3.3 M7.

Comment 2 Philipe Mulet

2007-04-12 06:35:48 EDT

Created attachment 63595 [details]
Proposed patch for a subset of the issues

Removed:
  CaseStatement#isEnumConstant
  ExplicitConstructorCall#discardEnclosingInstance
  FieldDeclaration#hasBeenResolved

Comment 3 Philipe Mulet

2007-04-12 06:36:33 EDT

Patch released

Comment 4 Philipe Mulet

2007-04-12 06:45:15 EDT

Remaining issues:
  AbstractMethodDeclaration#errorInSignature
  AbstractMethodDeclaration#ignoreFurtherInvestigation (would keep this one)
  AbstractMethodDeclaration#needFreeReturn
  CompilationUnitDeclaration#... (would keep these - little instances)
  ConstructorDeclaration#isDefaultConstructor
  ForStatement#neededScope
  IfStatement#thenExit
  ImportReference#onDemand
  ImportReference#used
  Initializer#errorInSignature
  JavadocAllocationExpression#superAccess
  JavadocFieldReference#superAccess
  JavadocMessageSend#superAccess
  JavadocReturnStatement#empty
  ParameterizedQualifiedTypeReference#didResolve
  ParameterizedSingleTypeReference#didResolve
  ReturnStatement#isAnySubRoutineEscaping
  ReturnStatement#isSynchronized
  SynchronizedStatement#blockExit
  TypeDeclaration#hasBeenGenerated
  TypeDeclaration#ignoreFurtherInvestigation (would keep this)

Comment 5 Olivier Thomann

2007-04-25 11:52:30 EDT

Created attachment 64883 [details]
Patch for remaining issues

Comment 6 Olivier Thomann

2007-04-25 12:59:09 EDT

Released for 3.3M7.
To verify, the patch needs to be checked.

Comment 7 Maxime Daniel

2007-04-27 12:06:20 EDT

Verified for 3.3 M7 using source code v_751.
(Checked that remaining boolean field declarations in AST match the cases marked as 'would keep' above - a total of five instances.)