Bug 143992

Summary:	Deprecate the org.eclipse.core.commands.util package and mark for deletion
Product:	[Eclipse Project] Platform	Reporter:	Tod Creasey <Tod_Creasey>
Component:	UI	Assignee:	Lars Vogel <Lars.Vogel>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	akurtako, daniel_megert, Lars.Vogel, odockal
Version:	3.2	Keywords:	api
Target Milestone:	4.11 M3
Hardware:	PC
OS:	All
See Also:	https://git.eclipse.org/r/134827 https://git.eclipse.org/r/136305 https://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=c3ceeadede40affe8325e0bfa1be6ed78bcc89ba https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fb721e93e8067b50b16a4a481ec4a3add11d6b17
Whiteboard:
Bug Depends on:
Bug Blocks:	572014

Description Tod Creasey

2006-05-26 12:54:11 EDT

RC5

org.eclipse.core.commands.util is marked as public but it is only used for debugging. We should move the tracing class and make the package only visible to JFace and the Workbench.

Comment 1 Lars Vogel

2019-01-09 04:16:09 EST

I suggest that we mark the package as x-internal. This should be similar to our current removal strategy only that do not delete the package. 

If we do this, this needs to be added to the migration guide.

Comment 2 Lars Vogel

2019-01-09 04:16:52 EST

Dani, Alex, any concerns?

Comment 3 Eclipse Genie

2019-01-09 04:31:30 EST

New Gerrit change created: https://git.eclipse.org/r/134827

Comment 4 Dani Megert

2019-01-09 11:48:29 EST

(In reply to Lars Vogel from comment #1)
> I suggest that we mark the package as x-internal. This should be similar to
> our current removal strategy only that do not delete the package. 
This is like deleting the API - a no go.

There is no shortcut. The specified process has to be followed, i.e. copy the functionality in an internal package and deprecate the API. Later mark it for deletion.

Comment 5 Lars Vogel

2019-01-09 11:54:26 EST

IMHO it is not the same as deleting, let's discuss in the next PMC call.

Comment 6 Dani Megert

2019-01-09 12:07:12 EST

(In reply to Lars Vogel from comment #5)
> IMHO it is not the same as deleting, let's discuss in the next PMC call.

It means the API is no longer API. The clients will not get a compiler error but an API Tools error. Also, it is not very clean to mark a package that does not have 'internal' in the name as internal. The proposed approach is just sloppy.

Comment 7 Lars Vogel

2019-01-14 03:50:30 EST

(In reply to Dani Megert from comment #6)
 
> It means the API is no longer API. The clients will not get a compiler error
> but an API Tools error. Also, it is not very clean to mark a package that
> does not have 'internal' in the name as internal. 

Ok, lets move it to an internal package. Feels also better to me.

Comment 8 Eclipse Genie

2019-02-05 08:46:53 EST

New Gerrit change created: https://git.eclipse.org/r/136305

Comment 9 Eclipse Genie

2019-02-05 08:59:07 EST

Gerrit change https://git.eclipse.org/r/136305 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=c3ceeadede40affe8325e0bfa1be6ed78bcc89ba

Comment 10 Eclipse Genie

2019-02-05 11:18:56 EST

Gerrit change https://git.eclipse.org/r/134827 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fb721e93e8067b50b16a4a481ec4a3add11d6b17