Bug 142184

Summary:	Do not log messages shown as a result of invalid user input
Product:	[Tools] Target Management	Reporter:	Martin Oberhuber <mober.at+eclipse>
Component:	RSE	Assignee:	David Dykstal <ddykstal.eclipse>
Status:	NEW ---	QA Contact:	Martin Oberhuber <mober.at+eclipse>
Severity:	minor
Priority:	P3	CC:	ddykstal.eclipse, dmcknigh, kmunir
Version:	unspecified	Keywords:	investigate
Target Milestone:	Future
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	196317, 158320
Bug Blocks:

Description Martin Oberhuber

2006-05-17 06:44:25 EDT

Under the "Local" subsystem, choose Contextmenu > New > Filter
Tab to the "Subset by file name" box and enter e.g.
   /bla/bla/bla

While typing, lots of errors are being logged to the PDE Error Log.
This should not happen.
Plain user notification of incorrect input should not be logged.

Comment 1 Kushal Munir

2006-05-18 16:00:25 EDT

RSE does not distinguish between messages shown as a result of invalid user input and actual error messages. The messaging framework logs any error message shown to the user in dialogs and wizards that use ISystemMessageLine. The problem is therefore evident in many RSE dialogs and wizards.

I would like to get thoughts on changing the framework to handle "real" error messages and those that are shown as a result of invalid user input.

Comment 2 Kushal Munir

2006-05-18 17:11:56 EDT

I'm changing the defect title to reflect the broader need to NOT log messages shown as a result of invalid user input (i.e. not really errors).

Comment 3 Kushal Munir

2006-05-18 17:43:24 EDT

*** Bug 138357 has been marked as a duplicate of this bug. ***

Comment 4 Kushal Munir

2006-08-02 09:22:54 EDT

I'm lowering the bug priority to P3 since this is not causing problems with functionality

Comment 5 Martin Oberhuber

2006-09-25 10:11:58 EDT

Kushal please check if this has been fixed by bug 158320 and resolve it as "duplicate" if yes.

Comment 6 Martin Oberhuber

2007-07-12 07:07:51 EDT

(In reply to comment #1)
> The messaging framework logs any error message shown to the user in dialogs
> and wizards that use ISystemMessageLine.

At this point I'd like to understand why this is done - when an error message is shown to the user by means of a dialog, it should not also be logged since it is part of normal system operation. We should use the error log only for unexpected errors.

See also bug #196035 comment 5.