Bug 141430

Summary: ACC: Print Dialog has fields that are not properly read by a screen reader
Product: [Modeling] GMF-Runtime Reporter: Cherie Revells <crevells>
Component: GeneralAssignee: Syed Atif <syedatif>
Status: RESOLVED FIXED QA Contact:
Severity: critical    
Priority: P3 CC: ahunter.eclipse
Version: 1.0Keywords: accessibility, contributed
Target Milestone: 1.0   
Hardware: PC   
OS: Windows 2000   
Whiteboard:
Attachments:
Description Flags
This zip contains the entire DiagramPrint cpp workspace (source only)
none
Recompiled DLLs none

Description Cherie Revells CLA 2006-05-11 16:51:08 EDT
The Print Dialog has fields that are not properly read by a screen reader.

To reproduce:
- Start MS Narrator found on Windows under Start > Programs > Accessories > Accessibility > Narrator.
- Open a GMF diagram.
- Select File > Print.
- Select the editable field titled "% of normal size".  
ISSUE #1 -- Notice the Narrator says the value "100" but it does not say "% of normal size" like it should.

- Select the "Fit to" radio button.  Select the editable field titled "page(s) wide).  
ISSUE #2 -- Notice the Narrator says "% of normal size" and it should say "page(s) wide".

- Select the value in "by: X tall".
ISSUE #3 -- This field should read "by X tall".  It doesn't say the word "tall".
Comment 1 Syed Atif CLA 2006-05-12 15:38:37 EDT
Usually, when a user sets focus on a field, the label to the immediate left will be associated with the field and thus that label's contents will be narrated along with the field contents.

There is no way for the narrator to make it work to read the fields on the right as well (which is the main problem of all these bugzillas).

The only solution that I see is to combine these labels on the right of the field with the label on the left of the field.

So, for example, we can do:

Adjust to (% of normal size): {TextField}

instead. However, I personally feel this becomes a bit more confusing, especially if other fields are made the same way. For example, lets take the (third issue) "By: X tall"

by (tall): X
Comment 2 Steven R. Shaw CLA 2006-05-18 08:55:46 EDT
Moving to RC4
Comment 3 Syed Atif CLA 2006-05-25 16:47:42 EDT
Created attachment 42639 [details]
This zip contains the entire DiagramPrint cpp workspace (source only)

This fix makes sure that the screen readers properly associate labels with their text fields. Usually, radio buttons cannot be associated as label names for text fields, so I placed an invisible label with a duplication caption under the "Adjust to % of normal size" radio button, and thus the screen reader correctly reads the corresponding text field's name.

There were a lot of truncation problems in the localized dialogs. This file contains a fix to all the truncation problems in all dialogs.

It seems that the updated workspace cpp source is not available from CVS (the old obsolete source can be found at org.eclipse.gmf/contributions/ibm-gmf-runtime/cpp-source). Please commit this source to org.eclipse.gmf/plugins/org.eclipse.gmf.runtime.common.ui.printing.win32/DiagramPrint

(I think the source was supposed to be committed but never was; see last two comments in bug 112407.)

Lastly, the localized dlls in the folder org.eclipse.gmf/plugins/org.eclipse.gmf.runtime.common.ui.printing.win32 are duplicates of PrintDiagram_en.dll, i.e. all of them are in English. Please update those dlls with the correctly localised ones supplied in the next attachment under the folder I10n (recompiled Release dlls).
Comment 4 Syed Atif CLA 2006-05-25 16:48:32 EDT
Created attachment 42641 [details]
Recompiled DLLs
Comment 5 Anthony Hunter CLA 2006-05-29 16:04:36 EDT
Committed the DLL and source code. 

We will need to retest with tonight's build.
Comment 6 Anthony Hunter CLA 2006-05-29 16:05:13 EDT
Should have marked as fixed too.
Comment 7 Richard Gronback CLA 2008-08-13 13:05:26 EDT
[target cleanup] 1.0 RC4 was the original target milestone for this bug
Comment 8 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug