Bug 14040

Summary: Platform interoperability issue w.r.t. Compare With Patch
Product: [Eclipse Project] Platform Reporter: Jeff Brown <jeff_brown>
Component: CompareAssignee: Adam Kiezun <akiezun>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: James_Moody, Michael.Valenta
Version: 2.0   
Target Milestone: 2.0 F2   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Jeff Brown CLA 2002-04-17 15:42:00 EDT
Compare With... Patch does not compensate for differing end-of-line
conventions between that of the patch file and that of the file
being patched.  As a result patch files often cannot be applied without
using Ignore Whitespace.

The problem is two-fold:
1) Ignore Whitespace should not need to be checked
2) Line delimiters in the patch are copied without translation into the
   patched file. For instance, files containing CR/LFs may be
   generated on Linux without the user's knowledge because new lines have
   been inserted.  This in turn may confuse tools that expect the
   platform line delimiter conventions to be respected.

In particular, this poses a problem for the CVS Team Provider since
it assumes that all text files adhere to the platform's line delimiter
conventions.

Since Compare With Patch is a prominent interface for external contributions,
it should be especially cautious vis-a-vis possible interoperability issues.
Comment 1 Andre Weinand CLA 2002-05-28 08:24:29 EDT
fixed in 20020528
Comment 2 Erich Gamma CLA 2002-06-02 17:48:52 EDT
pls verify
Comment 3 Andre Weinand CLA 2003-01-20 08:14:42 EST
what is "NEW FIXED"?