Bug 14040 - Platform interoperability issue w.r.t. Compare With Patch
Summary: Platform interoperability issue w.r.t. Compare With Patch
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.0 F2   Edit
Assignee: Adam Kiezun CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-04-17 15:42 EDT by Jeff Brown CLA
Modified: 2003-01-20 08:14 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Brown CLA 2002-04-17 15:42:00 EDT
Compare With... Patch does not compensate for differing end-of-line
conventions between that of the patch file and that of the file
being patched.  As a result patch files often cannot be applied without
using Ignore Whitespace.

The problem is two-fold:
1) Ignore Whitespace should not need to be checked
2) Line delimiters in the patch are copied without translation into the
   patched file. For instance, files containing CR/LFs may be
   generated on Linux without the user's knowledge because new lines have
   been inserted.  This in turn may confuse tools that expect the
   platform line delimiter conventions to be respected.

In particular, this poses a problem for the CVS Team Provider since
it assumes that all text files adhere to the platform's line delimiter
conventions.

Since Compare With Patch is a prominent interface for external contributions,
it should be especially cautious vis-a-vis possible interoperability issues.
Comment 1 Andre Weinand CLA 2002-05-28 08:24:29 EDT
fixed in 20020528
Comment 2 Erich Gamma CLA 2002-06-02 17:48:52 EDT
pls verify
Comment 3 Andre Weinand CLA 2003-01-20 08:14:42 EST
what is "NEW FIXED"?