Bug 139569

Summary:

Batch compiler should check if java home is null when trying to set the extDirs and endorsed dirs

Product:

[Eclipse Project] JDT

Reporter:

Olivier Thomann <Olivier_Thomann>

Component:

Core

Assignee:

Olivier Thomann <Olivier_Thomann>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert, philippe_mulet

Version:

3.2

Target Milestone:

3.2 RC3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed fix	none

Description Olivier Thomann

2006-05-01 14:29:12 EDT

In RC2, when the java home is null and no extDirs or endorsed dirs are set, the batch compiler doesn't work.
It fails with a NPE.

Comment 1 Olivier Thomann

2006-05-01 14:37:10 EDT

Created attachment 39972 [details]
Proposed fix

The patch is trivial. It simply adds null checks when using javaHome for settings extdirs and endorsed dirs.
Candidate for RC3?

Comment 2 Philipe Mulet

2006-05-01 16:11:13 EDT

+1 for 3.2RC3

Comment 3 Philipe Mulet

2006-05-01 16:17:18 EDT

Dani - would you pls cast your vote ? Trivial fix for batch compiler.

Comment 4 Dani Megert

2006-05-02 09:44:07 EDT

Approving for 3.2 RC3.

Comment 5 Olivier Thomann

2006-05-02 09:46:00 EDT

Fixed and released in HEAD.

Comment 6 Dani Megert

2006-05-02 09:50:33 EDT

*** Please note: you first have to post the intended bug(s) to the releng list so that others can veto it, see:
http://www.eclipse.org/eclipse/development/freeze_plan_3.2.html

Comment 7 Olivier Thomann

2006-05-02 09:55:46 EDT

My understanding was to send the list of bugs fixed. But I didn't understand that the bug list had to be submitted prior to releasing them. It is a notification, not a vote. Did I miss anything?

Comment 8 Dani Megert

2006-05-02 10:01:03 EDT

It says: "Announce bug numbers of ***intended*** ...

My understanding in the >RC2 phase is that any component lead can veto any change at this time. Though that rarely happens.

Comment 9 Olivier Thomann

2006-05-03 11:37:09 EDT

Verified using N20060503-0010 for 3.2RC3 by creating the executable of the batch compiler using gcj. When running this executable, the java.home property is not set.