Summary: | Compile errors against foundation 1.0: org.eclipse.update.ui | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | DJ Houghton <dj.houghton> | ||||
Component: | Update (deprecated - use Eclipse>Equinox>p2) | Assignee: | Branko Tripkovic <btripkov> | ||||
Status: | RESOLVED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P1 | CC: | jeffmcaffer, wassim.melhem | ||||
Version: | 3.2 | ||||||
Target Milestone: | 3.2 RC3 | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Whiteboard: | |||||||
Bug Depends on: | |||||||
Bug Blocks: | 139490 | ||||||
Attachments: |
|
Description
DJ Houghton
2006-04-27 11:02:52 EDT
DJ, Jeff this methods are in jdk 1.4 and code has been in for very long time, some of it from 2004. It might be very dangerous to change it this late. I am not sure how this was not caught before. The statement "compiles against Foundation 1.0" was never enforced before. Now the infrastructure is there and we can actually do it as part of the build process. true that the slick way of doing this is recent but the manual way of confirming your plugin compiles against Foundation has been around for some time (since 3.0). Having said that, we are where we are. Lets see if we can fix the code for 3.2. Created attachment 40050 [details] patch for org.eclipse.update.ui Recommended patch for the org.eclipse.update.ui project. Note that this patch also combines the changes required to fix bug 139490. after applying patch I am getting an error in manifest.mf on this import packages: Import-Package: javax.xml.parsers, org.w3c.dom, org.xml.sax, org.xml.sax.helpers I am also confused with multiple environments is that ok: Bundle-RequiredExecutionEnvironment: J2SE-1.4, CDC-1.0/Foundation-1.0, J2SE-1.3 Is this what you wanted: Bundle-RequiredExecutionEnvironment: CDC-1.0/Foundation-1.0, J2SE-1.3 DJ, can you look at this please? Also can you please combine patch with patch for 139490? There is a same problem in patches for this bugs: bug 139490, bug 139489, bug 139488. What errors do you get? I re-applied the patch and it works fine for me. The patch is already combined with bug 139490. The EE list is what we want. We need 1.4 first because that is the EE that the releng builder uses to compile against and we need to get the XML APIs from 1.4 for the build. DJ, sorry this was a clash between me and pde everything is fine now. Jeff, Dejan I need some pluses here. One more, Wassim - I can see the light at the end of the tunnel now :-). +1 from me. +1 Committed. |