Bug 138903

Summary:

Template for the perspectives extension point

Product:

[Eclipse Project] PDE

Reporter:

Shaun Skelton <shaun>

Component:

Assignee:

Chris Aniszczyk <caniszczyk>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

wassim.melhem, xavier.mehaut

Version:

3.2

Keywords:

contributed

Target Milestone:

3.3 M2

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Icon associated with patch	none
Perspective Template	none
org.eclipse.pde.ui.patch	none
org.eclipse.pde.ui.patch	none

Description Shaun Skelton

2006-04-27 09:33:03 EDT

I have created a new template for the perspectives extension point however I have certain concerns.

I themed the sample perspective around Release Engineering and to accomplish this I have hardcoded some view id's into the sample code. While I normally would abstain from using hardcoded values, in this case it allowed for a bit more depth in the template. The two options I see are:

1) Keep the hardcoded values and theme to provide a template that's more interesting

2) Remove the hardcoded values, stick to using view id's that have public constants available, and adjust the template decription accordingly.

Comment 1 Shaun Skelton

2006-04-27 09:34:32 EDT

Created attachment 39659 [details]
Icon associated with patch

Path: /org.eclipse.pde.ui/templates_3.0/perspective/bin/icons/releng_gears.gif

Comment 2 Shaun Skelton

2006-04-27 09:39:30 EDT

Created attachment 39660 [details]
Perspective Template

Comment 3 Wassim Melhem

2006-04-27 21:01:17 EDT

*** Bug 78481 has been marked as a duplicate of this bug. ***

Comment 4 Chris Aniszczyk

2006-08-10 14:49:21 EDT

I'll look at cleaning this one up

Comment 5 Chris Aniszczyk

2006-08-13 23:47:14 EDT

Created attachment 47826 [details]
org.eclipse.pde.ui.patch

Updated patch against latest code base.

Comment 6 Chris Aniszczyk

2006-08-13 23:48:25 EDT

Hey Wassim, I updated the patch, however, I noticed a strange problem with our wizards. Sometimes when you go to the template and you're presented options, the wizard expands to the width of your screen. Let me know if you can reproduce that (open another bug?).

Other than that, the template looks good to go.

Comment 7 Wassim Melhem

2006-08-13 23:54:42 EDT

Chris, I told you about the wizard being too wide issue in bug 145854 comment 5.

I opened a bug report (bug 153536) against Platform/UI regarding the issue.

Comment 8 Chris Aniszczyk

2006-08-14 00:07:05 EDT

note to self, Wassim has a good memory

Comment 9 Wassim Melhem

2006-08-14 00:50:05 EDT

Released the patch.

Chris, the binary icon in the patch messed it up.

Also the patch is missing mnemonics for the checkboxes on the template page.  please provide a fixpack :)

Comment 10 Chris Aniszczyk

2006-08-14 23:43:58 EDT

Created attachment 47889 [details]
org.eclipse.pde.ui.patch

there you go

Comment 11 Wassim Melhem

2006-08-14 23:48:19 EDT

Thanks Shaun and Chris.