Bug 138516

Summary:

DiagramEventBrokerCommand should implement canRedo() using the EMF-TX extension to the Command interface

Product:

[Modeling] GMF-Runtime

Reporter:

Christian Damus <give.a.damus>

Component:

General

Assignee:

Christian Damus <give.a.damus>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

vramaswa

Version:

1.0

Keywords:

contributed

Target Milestone:

1.0

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

138287

Bug Blocks:

Attachments:

Description	Flags
Patch to implement the required method	none

Description Christian Damus

2006-04-25 17:08:34 EDT

The DiagramEventBrokerCommand class defined by the DiagramEditingDomain should implement the ConditionallyRedoableCommand interface to provide the canRedo() method, when bug 138287 is resolved and the next EMFT build is adopted by GMF.

This will be required for ICommands and IUndoableOperations executed by the diagram event broker to include their redoability in the computation of the overall redoability of the operation/transaction that the event broker extends.

This defect is targeted to the Runtime EMF Core team because they (I) implemented the DiagramEventBrokerCommand for inserting the broker's changes via the TriggerCommand.

Comment 1 Christian Damus

2006-05-02 10:01:23 EDT

Created attachment 40038 [details]
Patch to implement the required method

Attached a patch that updates the DiagramEventBrokerCommand to implement the new ConditionalRedoCommand interface.

Comment 2 Christian Damus

2006-05-02 10:02:12 EDT

Adding Vishy to the cc: to review and (hopefully) apply the patch.

Comment 3 Vishy Ramaswamy

2006-05-02 11:10:49 EDT

Reviewed and applied patch

Comment 4 Richard Gronback

2008-08-13 13:04:19 EDT

[target cleanup] 1.0 RC was the original target milestone for this bug

Comment 5 Eclipse Webmaster

2010-07-19 12:24:18 EDT

[GMF Restructure] Bug 319140 : product GMF and component
Runtime EMF was the original product and component for this bug