Bug 135906

Summary:

CompilationUnitStructureRequestor.resolveDuplicates has bad performance

Product:

[Eclipse Project] JDT

Reporter:

Dani Megert <daniel_megert>

Component:

Core

Assignee:

Jerome Lanneluc <jerome_lanneluc>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

eric_jodet, Olivier_Thomann

Version:

3.2

Keywords:

performance

Target Milestone:

3.5 M1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed fix and performance test	none

Description Dani Megert

2006-04-10 11:51:45 EDT

N20060410-0010.

I know having many duplicates of the same member isn't a common case but if that happens the performance gets very bad.

Test Case:
1. create CU Foo.java
2. add method void foo() {}
3. make 4000 copies for it and save
4. close editor
5. open editor
==> takes very long

Now comment out the code in resolveDuplicates()
==> editor opens quite fast

Comment 1 Jerome Lanneluc

2006-05-03 07:32:09 EDT

Post 3.2

Comment 2 Dani Megert

2006-06-16 08:46:08 EDT

Can this now be reopened for 3.3.?

Comment 3 Jerome Lanneluc

2006-06-16 08:49:39 EDT

Reopening to consider in 3.3

Comment 4 Jerome Lanneluc

2007-06-21 05:03:25 EDT

We could have a separate table from original handle (i.e. with occurrenceCount == 0) to current occurrence count.

Comment 5 Jerome Lanneluc

2008-05-07 07:59:19 EDT

Deferring again (sorry Dani)

Comment 6 Jerome Lanneluc

2008-06-10 09:11:11 EDT

Created attachment 104305 [details]
Proposed fix and performance test

Comment 7 Jerome Lanneluc

2008-06-26 07:16:55 EDT

Fix and performance test released for 3.5M1 in HEAD.
Performance test released in perf_34x branch.

Comment 8 Olivier Thomann

2008-08-08 10:57:32 EDT

Will be verified once the performance test results are back.

Comment 9 Frederic Fusier

2008-12-12 04:02:26 EST

Verified for 3.5M4 using performance results of build I20081211-0100.