Summary: | [search] Improve search progress monitor label | ||
---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Martin Aeschlimann <martinae> |
Component: | Core | Assignee: | Frederic Fusier <frederic_fusier> |
Status: | VERIFIED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | philippe_mulet |
Version: | 3.2 | ||
Target Milestone: | 3.2 RC1 | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Whiteboard: |
Description
Martin Aeschlimann
2006-04-10 05:47:32 EDT
This is the participant API which is at work here. Need to be careful. First, we do not update this label for each scanned file while indexing files or locating matches as it would have a big hit on performances. Second, message is: "{0}: locate matches..." where parameter is the Search Participant description returned by API method IJavaSearchParticipant.getDescription() So, I would say that best solution would be to change the entire message in messages.properties of o.e.jdt.internal.core.util package. Your proposal looks good (e.g. "Locate {0} matches...") as this message is also used in combined phrase. For example in preview of Rename dialog, you can have: "Searching for references... Locate {0} matches..." and "Checking preconditions... Locate {0} matches..." Philippe, does it sound OK for you? If, so please accept this bug for RC1, thanks Should be "Locating" not "Locate". +1 for 3.2RC1 as minor polish. I've modified properties as follows: engine_searching_indexing = Looking through {0} indexes... engine_searching_matching = Locating {0} matches... Fixed and released in HEAD Verified for 3.2 RC1 using build I20060413-0010 |