Bug 13507

Summary:	LinkedPositionUI has a reference to SWT.COLOR_RED
Product:	[Eclipse Project] JDT	Reporter:	Tod Creasey <Tod_Creasey>
Component:	UI	Assignee:	Claude Knaus <Claude_Knaus>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P2	Keywords:	accessibility
Version:	2.0
Target Milestone:	---
Hardware:	PC
OS:	Windows 2000
Whiteboard:

Description Tod Creasey

2002-04-11 09:30:37 EDT

LinkedPositionUI(ITextViewer, LinkedPositionManager) - 
org.eclipse.jdt.internal.ui.text.link.LinkedPositionUI has a reference to 
SWT.COLOR_RED which will be unreadble if the user sets their background colour 
to Red.

We will be adding a getErrorText colour to JFaceColours in build >20020411. You 
may want to use that.

Comment 1 Erich Gamma

2002-04-12 08:35:11 EDT

there should be a prefernce to change the template variable color

Comment 2 Tod Creasey

2002-04-12 09:12:38 EDT

There is now a JFaceColors entry getErrorText() which returns the JFace colour 
setting for errors. You may want to use this rather than creating another 
preference.

Comment 3 Claude Knaus

2002-04-12 09:37:51 EDT

It's not showing any errors, so I don't intend to use it. :)

Comment 4 Nick Edgar

2002-04-16 09:57:24 EDT

Please remove the ref to SWT.COLOR_RED if you're not using it then.

Comment 5 Claude Knaus

2002-04-16 10:05:29 EDT

I am using color red for now, that doesn't mean it is an error. I see that it's 
confusing because errors are now red, too. Therefore, I will change it to be 
configurable.

Comment 6 Nick Edgar

2002-04-16 12:14:26 EDT

The problem is that we need to avoid hardcoded colours for accessibility 
reasons. If it's configurable, that's OK.  
Please also describe how to cause this to occur so we can test for 
accessibility.

Comment 7 Claude Knaus

2002-04-17 08:28:59 EDT

fixed >= 20020417
added color preference option in Preference->Java->Editor