Bug 129785

Summary: Undo/redo doesn't work after making changes in property pages
Product: [Modeling] GMF-Runtime Reporter: Cherie Revells <crevells>
Component: GeneralAssignee: Cherie Revells <crevells>
Status: RESOLVED FIXED QA Contact:
Severity: critical    
Priority: P1 CC: rana.zaied
Version: 1.0   
Target Milestone: 1.0   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Cherie Revells CLA 2006-02-28 09:54:46 EST
After my EMF Transaction migration in the diagram layer, undo/redo no longer works when making changes in the properties view.
Comment 1 Cherie Revells CLA 2006-03-02 12:12:32 EST
Linda debugged this.  The problem is that the diagram editor's operation history listener is receiving the event before the WorkspaceCommandStackImpl.DomainListener.  The DomainListener adds the context to the operation, so when the diagram editor's operation history listener gets the event there is no context set.

Transferring to Linda.
Comment 2 Cherie Revells CLA 2006-03-02 13:01:36 EST
Purpose:   
Bugzilla#129785 Undo/redo doesn't work after making changes in property pages 
- Installed the operation history listener in the DiagramEditor.startListening() method instead of in its ctor. 

Activities:   
Bugzilla#129803 gmf_head cmahoney 060301 Deleting node leaves connection connected to space 

Code Reviewed by: 
Team programmed by:  Cherie, Christian, Linda. 

How tested: 
Adhoc property page undo/redo testing with multiple editors open. 

JUnit Tests:   
diagram.ui -- all passed 
Comment 3 Richard Gronback CLA 2008-08-13 13:07:04 EDT
[target cleanup] 1.0 M5 was the original target milestone for this bug
Comment 4 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug