Bug 129196

Summary: Change methods in RegistryStrategy
Product: [Eclipse Project] Equinox Reporter: DJ Houghton <dj.houghton>
Component: CompendiumAssignee: equinox.compendium-inbox <equinox.compendium-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: john.arthorne, Mike_Wilson, ob1.eclipse
Version: 3.2Keywords: api
Target Milestone: 3.2 M6   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch for the org.eclipse.equinox.registry none

Description DJ Houghton CLA 2006-02-23 13:16:07 EST 
RegistryStrategy#onStart(Object)
RegistryStrategy#onStop(Object)

When we had 2 different extension registries (one in the runtime namespace and the other in the equinox.registry namespace) these method signatures made sense. The registry code was refactored so now only one registry class exists.

We should update the signatures for these methods accordingly to make things clearer for users of our new API.
   RegistryStrategy#onStart(IExtensionRegistry)
   RegistryStrategy#onStop(IExtensionRegistry)

The only known callers of this method are internal to the registry. 

Since this change is happening after the API freeze, we need permission of the PMC to do this.
Comment 1 Jeff McAffer CLA 2006-02-23 18:55:49 EST 
+1 from me.  You might ping another PMC member for continuity.
Comment 2 DJ Houghton CLA 2006-02-24 06:37:20 EST 
Mike?
Comment 3 John Arthorne CLA 2006-02-24 10:11:15 EST 
The change makes sense to me.  If this interface is being treated as real API the javadoc comment about clients being repeatedly broken should be removed.
Comment 4 Mike Wilson CLA 2006-02-24 11:07:27 EST 
Agree with John's comment. You only need one PMC member's approval, so Jeff's +1 will carry it.
Comment 5 Oleg Besedin CLA 2006-02-24 13:47:29 EST 
Created attachment 35331 [details]
Patch for the org.eclipse.equinox.registry 

Patch modifies signatures of RegistryStrategy#onStart and RegistryStrategy#onStop as described in the request.
Comment 6 DJ Houghton CLA 2006-02-25 14:26:36 EST 
Patch released.

re: javadoc - we have multiple places in the runtime that we need to re-visit w.r.t. provisional API. (including the registry classes)