Bug 126321

Summary: [options] Add constant in JavaCore for nullReference
Product: [Eclipse Project] JDT Reporter: Martin Aeschlimann <martinae>
Component: CoreAssignee: Maxime Daniel <maxime_daniel>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.2   
Target Milestone: 3.2 M5   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Add the constant + none

Description Martin Aeschlimann CLA 2006-02-03 05:23:03 EST 
20060203

There is no constant for org.eclipse.jdt.core.compiler.problem.nullReference.

There's one for COMPILER_PB_INCONSISTENT_NULL_CHECK = PLUGIN_ID + ".compiler.problem.inconsistentNullCheck"

which doesn't exist in the comment for getDefaultOptions.

Please add the spec at the constant itself, as what we (and probably everybody else) use are the constants, not the strings.
Comment 1 Maxime Daniel CLA 2006-02-06 06:02:29 EST 
Created attachment 34183 [details]
Add the constant +

This patch adds the required constant, plus it deprecates the unused inconsistenNullCheck one, and aligns JavaCore#getDefaultOptions comment with the current default value for nullReference (that is, ignore for now).
Comment 2 Maxime Daniel CLA 2006-02-06 06:04:11 EST 
Verification: visit JavaCore and search for COMPILER_PB_NULL_REFERENCE.
Comment 3 Jerome Lanneluc CLA 2006-02-14 08:50:22 EST 
Verified for 3.2 M5 using build I20060214-0010