Summary: | [evaluation] Improve error message for method invocation on manually suspended threads | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Dani Megert <daniel_megert> | ||||
Component: | Debug | Assignee: | Michael Rennie <Michael_Rennie> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | minor | ||||||
Priority: | P3 | CC: | achapiro, curtis.windatt.public | ||||
Version: | 3.2 | ||||||
Target Milestone: | 3.4 M1 | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Dani Megert
2006-01-30 03:18:54 EST
Created attachment 33774 [details]
Picture showing problem
OK, I guess I didn't fully digest the info text in the display area. What it really wanted to say is: "You manually suspended the thread and hence the details can't be displayed.". Correct? If so, OK to close. Correct, this is a VM limitation. Could the message be improved? Probably. The evaluatuion engine has no idea why it was invoked (to peform toString, etc), so the "detail" manage will likely have to intercept and replace the error message with something else. Deferred *** Bug 137066 has been marked as a duplicate of this bug. *** Re-open to mark dup and press the 'reopen' button *** This bug has been marked as a duplicate of 34440 *** Re-opening to improve message in var view and debug popups when no thread is available for computing toString(). Any suggestions on a better error message? It is straight forward to change it when computing details as we can check for a specific error code when computing java details. Something along comment 2? Perhaps "<details unavailable in manually suspended thread>". I would use pro-active voice i.e. The/This thread has been manually suspended and hence there are no details available. Latest suggestion: "This thread has been manually suspended. Object details are unavailable." Opinions? Discovered a bug while playing around with this. When manually suspended, array value details give a detail formatter error (even though they have no detail formatter). Filing a separate bug report. Darin has suggested that it would be good if we could find a better way of presenting detail errors to the user. Currently we simply display them as text in the source viewer (which is editable). One possible idea would be to allow the detail listener to return an IStatus, and create an image and label to display the message. This will likely end up being a separate enhancement request. I would say why the object details are unvailable. This isn't 100% clear from your suggestion. ==> This thread has been manually suspended and therefore object details are unavailable. Alright, we'll use "This thread has been manually suspended and therefore object details are unavailable." Fixed in HEAD, see JavaDetailFormattersManager.java, DebugUIMessages.java and DebugUIMessages.properties. Mike, please verify. verified that the nomenclature of the error statement is satisfactory. |