Bug 125177

Summary:	[general] some refactoring actions are enabled even if there's no CU [refactoring]
Product:	[Eclipse Project] JDT	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	JDT-UI-Inbox <jdt-ui-inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3
Version:	3.2
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:	stalebug
Bug Depends on:
Bug Blocks:	123782

Description Dani Megert

2006-01-25 11:10:13 EST

R3.1 and I20060124-1115

Some refactoring actions are enabled even if there's no CU.

Test Case:
1. open a file from repository (e.g. via CVS Resource History view)
2. make some valid selection in the editor
3. open the main 'Refactoring' menu
==> some refactoring actions are still enabled even though there's no CU

Reason:
The SelectionDispatchAction.update(ISelection) always calls selectionChanged(ISelection) which gets delegated to selectionChanged(ITextSelection) and which for some refactoring actions is implemented as 'setEnabled(true)'.

Fix:
update(ISelection) which is called far less often than the selectionChanged(*) methods should do the same checks as the constructor.

See also bug 125176.

Comment 1 Eclipse Genie

2020-07-28 17:04:08 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 2 Eclipse Genie

2022-11-15 16:46:38 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.