Bug 122615

Summary: validate classpath propose to exlude a source folder even though exlusion patterns are disabled
Product: [Eclipse Project] JDT Reporter: Benno Baumgartner <benno.baumgartner>
Component: CoreAssignee: Jerome Lanneluc <jerome_lanneluc>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.2   
Target Milestone: 3.2 M5   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 122505    
Attachments:
Description Flags
proposed fix none

Description Benno Baumgartner CLA 2006-01-04 07:02:15 EST 
Version: 3.2.0
Build id: I20060103-0800

Given a project with the project folder as root. When calling JavaConventions#validateClasspath with a new source folder class path entry the returned status is an error saying something like: Cannot nest 'P01/src' inside 'P01'. To enable the nesting exclude 'src/' from 'P01'

But excluding a source folder is only possible if the use of exclusion patterns is enabled. If exclusion patterns are disabled the message should read something like: Cannot nest 'P01/src' inside 'P01'.
Comment 1 Benno Baumgartner CLA 2006-01-04 07:03:39 EST 
Created attachment 32459 [details]
proposed fix
Comment 2 Philipe Mulet CLA 2006-01-05 06:19:59 EST 
I wonder which setting is stronger. Maybe the right fix for the user is to enable exclusion patterns instead... By indicating need for excluding, we give a clue about the existence of this feature. Maybe we only need to adjust the wording to account for the fact the excluding is an optional feature (ON by default).
Comment 3 Benno Baumgartner CLA 2006-01-10 03:36:20 EST 
That whould be great too. Maybe something like:

To enable the nesting enable exlusion patterns in project P01 and exlude src from P01.
Comment 4 Jerome Lanneluc CLA 2006-01-18 07:26:53 EST 
Thanks for the patch. Released it with the message:
Cannot nest 'P01/src' inside 'P'. To allow the nesting enable use of exclusion patterns in the preferences of project 'P01' and exclude 'src/' from 'P01'

Added regression test ClasspathTests#testClasspathValidation42()
Comment 5 Frederic Fusier CLA 2006-02-14 07:10:44 EST 
Verified for 3.2 M5 using build I20060214-0010.