Bug 122016

Summary: CreateUnspecifiedTypeRequest should setSize for all the wrapped requests
Product: [Modeling] GMF-Runtime Reporter: Alex Shatalin <shatalin>
Component: GeneralAssignee: Cherie Revells <crevells>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P1    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Fix is attached none

Description Alex Shatalin CLA 2005-12-23 10:44:09 EST
CreateUnspecifiedTypeRequest override setLocation() and call setLocation() for all the wrapped requests, but do not override setSize() method. As a result, al the wrapped requests (passed to the command to process in future) do not get an information about actual size of object to be created.

As a result, all the diagram elements will be created with default sizes, instead of selected with the creation tool.
Comment 1 Alex Shatalin CLA 2005-12-23 10:45:54 EST
Created attachment 32203 [details]
Fix is attached
Comment 2 Cherie Revells CLA 2006-01-11 10:35:32 EST
Added propogation of size, creation factory, and extended data to the individual requests in a CreateUnspecifiedTypeRequest.

Activities: 
Bugzilla#122016 gmf_head cmahoney 060112 CreateUnspecifiedTypeRequest should setSize for all the wrapped requests

Code Reviewed by:
Tom

How tested: 
- Tested with the polygon geoshape unspecified creation tool.
- Added a new JUnit, RequestTests, to test this API.

JUnit Tests:  
org.eclipse.gmf.tests.runtime.diagram.ui -- 74/74

Comment 3 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug