Summary: | MylarUiPlugin fails to activate if no mylar views visible | ||||||
---|---|---|---|---|---|---|---|
Product: | z_Archived | Reporter: | Brock Janiczak <brockj> | ||||
Component: | Mylyn | Assignee: | Brock Janiczak <brockj> | ||||
Status: | RESOLVED FIXED | QA Contact: | |||||
Severity: | major | ||||||
Priority: | P1 | CC: | brad, brettconnor+b, mik.kersten | ||||
Version: | 0.4 | ||||||
Target Milestone: | --- | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Brock Janiczak
2005-12-17 22:42:23 EST
Thanks for identifying these problems Brock! I'm plan on putting out a service build tomorrow or Monday morning. Created attachment 31908 [details]
patch to org.eclipse.mylar.tasklist
Lazily load the ImageRegistry in TaskListImages. Images should only be requested on the UI thread, so there should be no need to synchronize getImageRegistry. It is also guarantees that Display.getCurrent will return a valid object.
Excellent Brock--very elegant solution for the sort of problem that can be really annoying to track down (startup issues have been a pain in the past). We have 3 image registries (ui, tasklist, and bugzilla) so I introduced this idiom to the other two as well, although they wouldn't have caused a problem because they don't require early startup. When you make any substatial patch of an existing class, could you add yourself to a new @author line with a short description? It's not necessary for minor stuff, but I like to ensure that credit goes where it's due, e.g.: @author Mik Kersten @author Brock Janiczak (lazy loading of image registry) This was resolved by Brock, so reassigning. Resolved. *** Bug 121436 has been marked as a duplicate of this bug. *** *** Bug 121381 has been marked as a duplicate of this bug. *** |