Bug 120633

Summary:

Accumulate messages issued during WeavingAdaptor intialization of flush if -verbose

Product:

[Tools] AspectJ

Reporter:

Matthew Webster <matthew_webster>

Component:

Compiler

Assignee:

aspectj inbox <aspectj-inbox>

Status:

VERIFIED FIXED

QA Contact:

Severity:

enhancement

Priority:

Version:

DEVELOPMENT

Target Milestone:

1.5.0

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Modified existing tests and implementation	none
Updates to LTW section on Development Environment Guide	none

Description Matthew Webster

2005-12-13 12:16:24 EST

There are several useful messages issued during adaptor initialization (including the new version string) that are not output unless "-Daj.weaving.verbose=true" because the verbose flag must be read from aop.xml. This enhancement accumulates these messages the outputs them if -verbose is specified. The implementation allows for a futher enhancement where these messages are retained until a warning/error message is issued.

Comment 1 Matthew Webster

2005-12-13 12:21:22 EST

Created attachment 31653 [details]
Modified existing tests and implementation

1. Enhance WeavingAdaptorMessageHandler to support accumulation and flushing
2. Make WeavingAdaptor.messageHandler private and intercept its update to allow accumulated messaged to be flushed
3. Modify expected output for serveral existing tests to account for the additional messages

Comment 2 Andrew Clement

2005-12-19 16:37:54 EST

changes committed into HEAD but not into the release branch yet.

Comment 3 Adrian Colyer

2005-12-20 06:14:53 EST

changes merged into release branch...

Comment 4 Matthew Webster

2005-12-20 06:50:01 EST

Created attachment 32017 [details]
Updates to LTW section on Development Environment Guide

Comment 5 Andrew Clement

2005-12-21 05:58:04 EST

all available in 1.5.0 final.