Bug 117752

Summary:

[CCombo] CCombo text drawn too high

Product:

[Eclipse Project] Platform

Reporter:

Christof Marti <christof_marti>

Component:

SWT

Assignee:

Duong Nguyen <duongn>

Status:

NEW ---

QA Contact:

Severity:

normal

Priority:

CC:

andre_weinand, grant_gayed, masha.krol, steve_northover

Version:

3.2

Target Milestone:

---

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

22782

Bug Blocks:

Attachments:

Description	Flags
Screenshot	none

Description Christof Marti

2005-11-23 12:21:00 EST

3.2M3

The text of a CCombo by default is drawn too high under Windows XP. CCombo#internalLayout() sets the upper-left bound to (0,0).

Comment 1 Christof Marti

2005-11-23 12:21:57 EST

Created attachment 30490 [details]
Screenshot

Comment 2 Andre Weinand

2005-11-23 13:29:04 EST

Positioning the text to (0,0) results in misaligned text if the height of the drop down arrow is larger than the text's height (which is the case for the attached screenshot). I think both the text and the icon should be centered vertically within the container.

Comment 3 Grant Gayed

2006-09-14 16:50:08 EDT

fixed > 0914

Comment 4 Grant Gayed

2006-09-19 09:58:04 EDT

Reopening report and taking out this fix, because vertically centering the Text in the CCombo and setting the CCombo's background to the Text's background (so that it all blends together) can fail when:

- the user changes their theme with CCombos open
- a CCombo is disabled

The first case can be handled by adding an SWT.Settings listener to the display and redrawing whenever the theme changes.  However there's no way to handle the second case with existing swt apis.

Comment 5 Grant Gayed

2006-09-19 10:00:29 EDT

There is a request for api that would help with the second case.  If that request can be implemented on all platforms then this can be revisited.  Marking this report as dependent on bug 22782.

Comment 6 Steve Northover

2007-04-18 03:36:11 EDT

Grant, what happened here?  Do we still have the problem?

Comment 7 Grant Gayed

2007-04-18 09:10:37 EDT

Yes, see comment 5.

Comment 8 Steve Northover

2007-04-18 15:42:39 EDT

Maybe we should put back the old code?

Comment 9 Eclipse Webmaster

2019-09-06 16:10:16 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.