Bug 114909

Summary:

AST: String concatenation represented as single node

Product:

[Eclipse Project] JDT

Reporter:

Markus Keller <markus.kell.r>

Component:

Core

Assignee:

Jerome Lanneluc <jerome_lanneluc>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

Olivier_Thomann

Version:

3.2

Target Milestone:

3.2 M4

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed fix	none
Regression test	none

Description Markus Keller

2005-11-03 09:19:38 EST

I20051102-1600

It looks like bug 82830 has only been paralyzed and now crept back into the
build again.

Comment 1 Jerome Lanneluc

2005-11-03 09:27:39 EST

The regression test for bug 82830 is still passing, indicating that an infix
expression is built for a string concatenation. Do you have more details ?

Comment 2 Olivier Thomann

2005-11-03 09:36:54 EST

Indeed, using the ASTView in I20051102-1200 produces a single string literal in
reconcile mode

Comment 3 Olivier Thomann

2005-11-03 10:14:05 EST

I will investigate.

Comment 4 Olivier Thomann

2005-11-03 11:21:13 EST

The path that doesn't work is a BecomeWorkingCopyOperation followed by a reconcile.
In this case the string literals are optimized.

Comment 5 Olivier Thomann

2005-11-03 12:05:44 EST

Created attachment 29274 [details]
Proposed fix

Comment 6 Jerome Lanneluc

2005-11-04 04:29:06 EST

Created attachment 29313 [details]
Regression test

Comment 7 Jerome Lanneluc

2005-11-04 10:44:34 EST

Release proposed fix and regression test in HEAD.

Comment 8 David Audel

2005-12-12 11:35:24 EST

Verified for 3.2 M4 using build I20051212-0010