Bugzilla – Full Text Bug Listing
| Summary: | Sweep diagram plugin message bundles | ||
|---|---|---|---|
| Product: | [Modeling] GMF-Runtime | Reporter: | Steven R. Shaw <steveshaw> |
| Component: | General | Assignee: | Cherie Revells <crevells> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P1 | CC: | etworkow |
| Version: | 1.0 | ||
| Target Milestone: | 1.0 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
|
Description
Steven R. Shaw
From Eliza: Is there a plan item to migrate GMF plug-ins to conform to Eclipse's way of getting images (quoting Wayne "E.g. using the imageDescriptorFromPlugin() method off AbstractUIPlugin. For a concrete example, please see IDEWorkbenchPlugin.getIDEImageDescriptor())" ? Purpose: For all GMF diagram plugins: - Migrated the retrieval of translated strings to use XMessages mechanism. - Migrated the retrieval of images and image descriptors to an XPluginImages class which manages the caching of only frequently used images. - Migrated the retrieval of fonts to use an internal FontRegistry class in the draw2d and diagram.ui plugins. This is used internally only. We have tried to migrate to JFace FontRegistry in the past, but the font caching is only done at the font level and not on specific sizes of fonts. - Moved the getColor() methods in AbstractResourceManager to a DiagramColorRegistry as this was the only thing left in the DiagramResourceManager. - Removed all XResourceManagers except for DiagramResourceManager which has been deprecated (see API change notice I just sent). Activities: Bugzilla#113812 gmf_head cmahoney 051125 Deprecating DiagramResourceManager Code Reviewed by: Steve How tested: - Eyeballed the strings and icons in the preference pages, appearance property pages, toolbar, diagram main menu, popup menu, diagram assistants. - Adhoc font tests, zoom tests. - Adhoc testing in Logic Example, Visualizer, and Modeler. Launching org.eclipse.gmf.tests.runtime.diagram.ui OK, Runs: 69, Fails: 0, Errors: 0, org.eclipse.gmf.tests.runtime.diagram.ui, Time: 94.266 Launching org.eclipse.gmf.tests.runtime.draw2d.ui OK, Runs: 35, Fails: 0, Errors: 0, org.eclipse.gmf.tests.runtime.draw2d.ui, Time: 0.312 Launching org.eclipse.gmf.tests.runtime.draw2d.ui.render OK, Runs: 3, Fails: 0, Errors: 0, org.eclipse.gmf.tests.runtime.draw2d.ui.render, Time: 5.344 [target cleanup] 1.0 M4 was the original target milestone for this bug [GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug |