Bug 110971

Summary:

Compartment Scrolling Issues

Product:

[Modeling] GMF-Runtime

Reporter:

Cherie Revells <crevells>

Component:

General

Assignee:

Alex Boyko <aboyko>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

ahunter.eclipse, mmostafa, steveshaw

Version:

1.0

Keywords:

contributed

Target Milestone:

2.0

Hardware:

OS:

Windows 2000

Whiteboard:

Attachments:

Description	Flags
proposed patch (attempt 1)	none

Description Cherie Revells

2005-09-28 14:19:33 EDT

There are issues with our scroll buttons in compartments.  I think these 
scrollbars are so ugly and hard to use.  Why don't we use the scroll bars that 
GEF uses?  To see the GEF scrollbars, create a circuit in the GEF logic diagram.

Issue 1:  There are no scroll bars.  It is annoying to have to click on the 
little scroll button all the time.  You cannot tell where you are scrolled in 
the compartment relative to the contents.  We should have scroll bars.

Issue 2:  Vertical down scroll button covers the horizontal right scroll button.
To reproduce:
- Create a logic diagram.
- Create a circuit.
- Add a LED in the circuit.
- Resize the circuit so that it is smaller than the LED horizontally and 
vertically.
RESULT: The vertical down scroll button covers the horizontal right scroll 
button.

Issue 3: Both vertical and horizontal scroll buttons seem stay even after the 
shape is resized.
To reproduce:
- Do steps for Issue 2.
- Resize the circuit horizontally so it is big enough horizontally to fit its 
contents.
RESULT: The horizontal scroll buttons still appear.  They should go away like 
in the GEF logic diagram.

Comment 1 Steven R. Shaw

2005-10-04 13:19:54 EDT

Issue 1:
I think the current scroll can be more elegant and less intrusive in certain 
contexts (ListCompartments).  I there's a way to bypass these and use the 
GEF / SWT scroll bars.  

Issue 2 / 3: Sounds like bugs with current implementation.

Comment 2 Steven R. Shaw

2005-10-06 14:35:46 EDT

Changing component to "Runtime Diagram"

Comment 3 Anthony Hunter

2006-11-28 16:52:33 EST

We need to look at:

Issue 2:  Vertical down scroll button covers the horizontal right scroll button.
To reproduce:
- Create a logic diagram.
- Create a circuit.
- Add a LED in the circuit.
- Resize the circuit so that it is smaller than the LED horizontally and 
vertically.
RESULT: The vertical down scroll button covers the horizontal right scroll 
button.

Issue 3: Both vertical and horizontal scroll buttons seem stay even after the 
shape is resized.
To reproduce:
- Do steps for Issue 2.
- Resize the circuit horizontally so it is big enough horizontally to fit its 
contents.
RESULT: The horizontal scroll buttons still appear.  They should go away like 
in the GEF logic diagram.

Comment 4 Alex Boyko

2006-11-28 22:24:36 EST

Created attachment 54685 [details]
proposed patch (attempt 1)

Here is an attempt to fix these issue:

3) currently we have both scroll bars appearing, although only one may be required. So I fixed this such that only scroll bars required to show will show and not both always.

2) I couldn't reproduce it - either I'm not following the steps correctly, or simply didn't notice this behavior or it's been fixed indirectly

1) I actually added the scroll thumbs, but set the alpha for the thumb figure to 0.5, so it looks nice. Perhaps, it's not a bad idea to have it.

Comment 5 Alex Boyko

2006-11-29 14:18:34 EST

Guys, regarding the scroll thumbs I'd like to add, could you please try this patch out when you get a free minute and provide me with some user feedback on the thumbs that I put for the scroll bars?
Thanks in advance.

Comment 6 Cherie Revells

2006-12-06 09:40:48 EST

Committed the patch.

The scroll buttons are still ugly in my opinion, but we have put in a request with the Media Design Team for some new ones.

Comment 7 Richard Gronback

2008-08-13 13:10:41 EDT

[target cleanup] 2.0 M4 was the original target milestone for this bug

Comment 8 Eclipse Webmaster

2010-07-19 12:27:33 EDT

[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug