Bug 109109

Summary:

Missing return keyword in BuildConsolePartition.equals(Object)

Product:

[Tools] CDT

Reporter:

Matthias Spycher <matthias>

Component:

cdt-core

Assignee:

Doug Schaefer <cdtdoug>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

cdtdoug, matthias

Version:

3.0

Keywords:

contributed

Target Milestone:

3.1

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
patch	bjorn.freeman-benson: iplog+

Description Matthias Spycher

2005-09-08 19:33:30 EDT

Body of if statement should contain: return fstream.equals(...);

public boolean equals(Object partition) {
  if (super.equals(partition)) {
    fStream.equals(((BuildConsolePartition) partition).getStream());
  }
  return false;
}

Stumbled on this while browsing the code.

Comment 1 Matthias Spycher

2005-09-08 19:34:12 EDT

Created attachment 26975 [details]
patch

Comment 2 Doug Schaefer

2005-09-28 15:54:47 EDT

Thanks, I've applied the patch to HEAD (3.1). I'm not sure what ill behavior
this caused, but it looks better.

Comment 3 Doug Schaefer

2008-06-03 14:22:58 EDT

assigning

Comment 4 Doug Schaefer

2008-06-03 14:23:17 EDT

done