Bug 104704

Summary:

[compiler] caching in the constant pool could be improved

Product:

[Eclipse Project] JDT

Reporter:

Olivier Thomann <Olivier_Thomann>

Component:

Core

Assignee:

Olivier Thomann <Olivier_Thomann>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

3.1

Target Milestone:

3.2 M1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Proposed fix	none
Proposed fix	none
Regression tests updated	none

Description Olivier Thomann

2005-07-21 14:34:18 EDT

Right now we do two accesses in the constant pool for each constant we want to add.
One to find out if it exists and one to add it if it doesn't. One access could
be enough. If it doesn't exist, we can add it immediately.

Comment 1 Olivier Thomann

2005-07-21 16:40:39 EDT

Created attachment 25156 [details]
Proposed fix

Note that you also need the patch for bug 104664 if you want to test using
-repeat on the batch compiler's command line.

Comment 2 Olivier Thomann

2005-07-25 10:30:49 EDT

Fix and released in HEAD.

Comment 3 Olivier Thomann

2005-07-25 10:31:12 EDT

Created attachment 25240 [details]
Proposed fix

Comment 4 Olivier Thomann

2005-07-25 10:31:28 EDT

Created attachment 25241 [details]
Regression tests updated

Comment 5 Olivier Thomann

2005-07-25 10:31:51 EDT

Remember to update ConformTests as well.

Comment 6 Jerome Lanneluc

2005-08-09 06:55:32 EDT

Verified with I20050808-2000