Bug 100062

Summary:

[formatting] Code formatter is broken on test case from bug 99999

Product:

[Eclipse Project] JDT

Reporter:

Olivier Thomann <Olivier_Thomann>

Component:

Core

Assignee:

Olivier Thomann <Olivier_Thomann>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

daniel_megert

Version:

3.1

Target Milestone:

3.1 RC3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Corresponding regression test	none
Proposed fix	none

Description Olivier Thomann

2005-06-14 15:57:39 EDT

Try to format the test case from bug 99999.
It doesn't work.

Comment 1 Olivier Thomann

2005-06-14 16:34:53 EDT

Created attachment 23102 [details]
Corresponding regression test

Comment 2 Olivier Thomann

2005-06-14 16:35:21 EDT

Created attachment 23103 [details]
Proposed fix

It needs the fix for bug 99999.

Comment 3 Philipe Mulet

2005-06-15 09:05:21 EDT

+1 for RC3

Dani - would you vote for this one ?

Comment 4 Dani Megert

2005-06-15 09:58:38 EDT

How big is the risk to break other scenarios?

Comment 5 Olivier Thomann

2005-06-15 10:06:06 EDT

very low.
All our formatter tests passed.

Comment 6 Olivier Thomann

2005-06-15 10:30:36 EDT

The bug is in decoding this:

[1]

in the code formatter. We wrongly consider this as dimensions. This leads the
code formatter to format that part at the wrong moment and then it cannot find
expected tokens afterwards. This is why it fails.

Comment 7 Dani Megert

2005-06-15 10:44:14 EDT

+1 for 3.1 RC3.

Comment 8 Olivier Thomann

2005-06-15 10:54:32 EDT

Fixed and released in HEAD.
Regression test added in
org.eclipse.jdt.core.tests.formatter.FormatterRegressionTests.test583

Comment 9 Olivier Thomann

2005-06-16 14:55:33 EDT

Verified using N20050616-0010 + JDT/Core HEAD