Attachment 75052 Details for Bug 196632 – patch to review

[patch] patch to review

patch.txt (text/plain), 2.18 KB, created by David McKnight

on 2007-07-31 12:02:29 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: David McKnight

Created: 2007-07-31 12:02:29 EDT

Size: 2.18 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.rse.subsystems.files.ftp
>Index: src/org/eclipse/rse/internal/subsystems/files/ftp/connectorservice/FTPConnectorService.java
>===================================================================
>RCS file: /cvsroot/dsdp/org.eclipse.tm.rse/plugins/org.eclipse.rse.subsystems.files.ftp/src/org/eclipse/rse/internal/subsystems/files/ftp/connectorservice/FTPConnectorService.java,v
>retrieving revision 1.15
>diff -u -r1.15 FTPConnectorService.java
>--- src/org/eclipse/rse/internal/subsystems/files/ftp/connectorservice/FTPConnectorService.java	31 May 2007 14:16:51 -0000	1.15
>+++ src/org/eclipse/rse/internal/subsystems/files/ftp/connectorservice/FTPConnectorService.java	31 Jul 2007 16:03:22 -0000
>@@ -19,6 +19,7 @@
>  * Javier Montalvo Orus (Symbian) - Fixing 176216 - [api] FTP sould provide API to allow clients register their own FTPListingParser
>  * Javier Montalvo Orus (Symbian) - [187531] Improve exception thrown when Login Failed on FTP
>  * David Dykstal (IBM) - added RESID_FTP_SETTINGS_LABEL
>+ * David McKnight       (IBM)     - [196632] [ftp] Passive mode setting does not work
>  ********************************************************************************/
> 
> package org.eclipse.rse.internal.subsystems.files.ftp.connectorservice;
>@@ -55,6 +56,11 @@
> 		super(FTPSubsystemResources.RESID_FTP_CONNECTORSERVICE_NAME,FTPSubsystemResources.RESID_FTP_CONNECTORSERVICE_DESCRIPTION, host, port);
> 		_ftpService = new FTPService();
> 			
>+		
>+	}
>+	
>+	private IPropertySet getPropertySet()
>+	{
> 		_propertySet = getPropertySet("FTP Settings"); //$NON-NLS-1$
> 		
> 		if(_propertySet==null)
>@@ -80,7 +86,8 @@
> 			String label = FTPSubsystemResources.RESID_FTP_SETTINGS_LABEL;
> 			((ILabeledObject)_propertySet).setLabel(label);
> 		}
>-	} 
>+		return _propertySet;
>+	}
> 	
> 	protected void internalConnect(IProgressMonitor monitor)  throws RemoteFileException, IOException
> 	{
>@@ -89,7 +96,7 @@
> 
> 	private void internalConnect() throws RemoteFileException, IOException
> 	{
>-
>+		getPropertySet();
> 		SystemSignonInformation info = getSignonInformation();
> 		_ftpService.setHostName(info.getHostname());
> 		_ftpService.setUserId(info.getUserId());

Actions: View | Diff

Attachments on bug 196632: 75052 | 75066 | 75077