Attachment 60539 Details for Bug 176971 – Proposed fix

[patch] Proposed fix

bug176971_001.txt (text/plain), 2.06 KB, created by David Audel

on 2007-03-12 05:48:44 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: David Audel

Created: 2007-03-12 05:48:44 EDT

Size: 2.06 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java,v
>retrieving revision 1.321
>diff -u -r1.321 CompletionEngine.java
>--- codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java	2 Mar 2007 14:38:28 -0000	1.321
>+++ codeassist/org/eclipse/jdt/internal/codeassist/CompletionEngine.java	12 Mar 2007 09:40:19 -0000
>@@ -1537,7 +1537,7 @@
> 				// get the source positions of the completion identifier
> 				if (qualifiedBinding instanceof ReferenceBinding && !(qualifiedBinding instanceof TypeVariableBinding)) {
> 					if (!this.requestor.isIgnored(CompletionProposal.TYPE_REF) ||
>-							!this.requestor.isIgnored(CompletionProposal.JAVADOC_TYPE_REF)) {
>+							((this.assistNodeInJavadoc & CompletionOnJavadoc.TEXT) != 0 && !this.requestor.isIgnored(CompletionProposal.JAVADOC_TYPE_REF))) {
> 						int rangeStart = typeRef.completeInText() ? typeRef.sourceStart : (int) (completionPosition >>> 32);
> 						setSourceRange(rangeStart, (int) completionPosition);
> 						findMemberTypes(this.completionToken,
>@@ -6374,7 +6374,7 @@
> 		
> 		boolean proposeType =
> 			!this.requestor.isIgnored(CompletionProposal.TYPE_REF) ||
>-			!this.requestor.isIgnored(CompletionProposal.JAVADOC_TYPE_REF);
>+			((this.assistNodeInJavadoc & CompletionOnJavadoc.TEXT) != 0 && !this.requestor.isIgnored(CompletionProposal.JAVADOC_TYPE_REF));
> 		
> 		boolean proposeAllMemberTypes = !this.assistNodeIsConstructor;
> 		
>@@ -6631,7 +6631,7 @@
> 
> 		boolean proposeType =
> 			!this.requestor.isIgnored(CompletionProposal.TYPE_REF) ||
>-			!this.requestor.isIgnored(CompletionProposal.JAVADOC_TYPE_REF);
>+			((this.assistNodeInJavadoc & CompletionOnJavadoc.TEXT) != 0 && !this.requestor.isIgnored(CompletionProposal.JAVADOC_TYPE_REF));
> 		
> 		char[] qualifiedName =
> 			CharOperation.concatWith(packageBinding.compoundName, token, '.');

Actions: View | Diff

Attachments on bug 176971: 60539