Attachment 4981 Details for Bug 38171 – Proposed fix

[patch] Proposed fix

patch.txt (text/plain), 2.71 KB, created by Debbie Wilson

on 2003-05-27 16:23:24 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Debbie Wilson

Created: 2003-05-27 16:23:24 EDT

Size: 2.71 KB

patch

obsolete

>Index: PageLayout.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PageLayout.java,v
>retrieving revision 1.10
>diff -u -r1.10 PageLayout.java
>--- PageLayout.java	11 Mar 2003 20:46:45 -0000	1.10
>+++ PageLayout.java	27 May 2003 20:13:56 -0000
>@@ -44,9 +44,7 @@
>  * </ol>
>  * </p>
>  */
>-public class PageLayout implements IPageLayout {
>-	private static final String MISSING_REF_PART = "Referenced part does not exist yet: "; //$NON-NLS-1$
>-	
>+public class PageLayout implements IPageLayout {	
> 	private ViewFactory viewFactory;
> 	private LayoutPart editorFolder;
> 	private boolean editorVisible = true;
>@@ -156,7 +154,7 @@
> 		ratio = normalizeRatio(ratio);
> 		rootLayoutContainer.add(newPart, getPartSashConst(relationship), ratio, refPart);
> 	} else {
>-		WorkbenchPlugin.log(MISSING_REF_PART + refId);//$NON-NLS-1$
>+		WorkbenchPlugin.log(WorkbenchMessages.format("PageLayout.missingRefPart", new Object[] {refId}));//$NON-NLS-1$
> 		rootLayoutContainer.add(newPart);
> 	}
> }
>@@ -224,7 +222,7 @@
>  */
> /*package*/ boolean checkPartInLayout(String partId) {
> 	if (getRefPart(partId) != null) {
>-		WorkbenchPlugin.log("Part already exists in page layout: " + partId);//$NON-NLS-1$
>+		WorkbenchPlugin.log(WorkbenchMessages.format("PageLayout.duplicateRefPart", new Object[] {partId}));//$NON-NLS-1$
> 		return true;
> 	}
> 	for(int i = 0; i<fastViews.size(); i++) {
>@@ -454,7 +452,7 @@
> 	}
> 
> 	// If ref part is not found then just do add.
>-	WorkbenchPlugin.log(MISSING_REF_PART + refId);//$NON-NLS-1$
>+	WorkbenchPlugin.log(WorkbenchMessages.format("PageLayout.missingRefPart", new Object[] {refId}));//$NON-NLS-1$
> 	rootLayoutContainer.add(newPart);
> }
> // stackPlaceholder(String, String) added by dan_rubel@instantiations.com
>Index: messages.properties
>===================================================================
>RCS file: /home/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/messages.properties,v
>retrieving revision 1.114
>diff -u -r1.114 messages.properties
>--- messages.properties	20 May 2003 19:50:01 -0000	1.114
>+++ messages.properties	27 May 2003 20:13:56 -0000
>@@ -1306,6 +1306,9 @@
> WorkbenchPage.unableToRestorePerspective=Unable to restore perspective: {0}.
> WorkbenchPage.unableToSavePerspective=Unable to save perspective: {0}.
> Perspective.unableToRestorePerspective=Unable to restore perspective: {0}.
>+PageLayout.missingRefPart=Referenced part does not exist yet: {0}.
>+PageLayout.duplicateRefPart=Part already exists in page layout: {0}.
>+
> 
> # ==============================================================================
> # Keys with references but don't show in the UI

Actions: View | Diff

Attachments on bug 38171: 4981