Attachment 24403 Details for Bug 91426 – Proposed fix

[patch] Proposed fix

patch_91426.txt (text/plain), 2.72 KB, created by Olivier Thomann

on 2005-07-06 16:51:17 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2005-07-06 16:51:17 EDT

Size: 2.72 KB

patch

obsolete

>Index: model/org/eclipse/jdt/internal/core/builder/AbstractImageBuilder.java
>===================================================================
>RCS file: /home/eclipse/org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/builder/AbstractImageBuilder.java,v
>retrieving revision 1.76
>diff -u -r1.76 AbstractImageBuilder.java
>--- model/org/eclipse/jdt/internal/core/builder/AbstractImageBuilder.java	28 Apr 2005 13:12:12 -0000	1.76
>+++ model/org/eclipse/jdt/internal/core/builder/AbstractImageBuilder.java	6 Jul 2005 20:49:33 -0000
>@@ -51,14 +51,16 @@
> private boolean inCompiler;
> 
> public static int MAX_AT_ONCE = 1000;
>-public final static String[] JAVA_PROBLEM_MARKER_ATTRIBUTE_NAMES = {
>+public final static String[] JAVA_PROBLEM_AND_TASK_MARKER_ATTRIBUTE_NAMES = {
> 					IMarker.MESSAGE, 
> 					IMarker.SEVERITY, 
>+					IMarker.PRIORITY, 
> 					IJavaModelMarker.ID, 
> 					IMarker.CHAR_START, 
> 					IMarker.CHAR_END, 
> 					IMarker.LINE_NUMBER, 
> 					IJavaModelMarker.ARGUMENTS};
>+public final static Integer S_INFO = new Integer(IMarker.SEVERITY_INFO);
> public final static Integer S_ERROR = new Integer(IMarker.SEVERITY_ERROR);
> public final static Integer S_WARNING = new Integer(IMarker.SEVERITY_WARNING);
> public final static Integer P_HIGH = new Integer(IMarker.PRIORITY_HIGH);
>@@ -384,10 +386,11 @@
> 		if (id != IProblem.Task) {
> 			IMarker marker = resource.createMarker(IJavaModelMarker.JAVA_MODEL_PROBLEM_MARKER);
> 			marker.setAttributes(
>-				JAVA_PROBLEM_MARKER_ATTRIBUTE_NAMES,
>+				JAVA_PROBLEM_AND_TASK_MARKER_ATTRIBUTE_NAMES,
> 				new Object[] { 
> 					problem.getMessage(),
> 					problem.isError() ? S_ERROR : S_WARNING, 
>+					P_NORMAL, 
> 					new Integer(id),
> 					new Integer(problem.getSourceStart()),
> 					new Integer(problem.getSourceEnd() + 1),
>@@ -425,7 +428,8 @@
> 	IResource resource = sourceFile.resource;
> 	for (int i = 0, l = tasks.length; i < l; i++) {
> 		IProblem task = tasks[i];
>-		if (task.getID() == IProblem.Task) {
>+		final int id = task.getID();
>+		if (id == IProblem.Task) {
> 			IMarker marker = resource.createMarker(IJavaModelMarker.TASK_MARKER);
> 			Integer priority = P_NORMAL;
> 			String compilerPriority = task.getArguments()[2];
>@@ -434,11 +438,12 @@
> 			else if (JavaCore.COMPILER_TASK_PRIORITY_LOW.equals(compilerPriority))
> 				priority = P_LOW;
> 			marker.setAttributes(
>-				JAVA_PROBLEM_MARKER_ATTRIBUTE_NAMES,
>+				JAVA_PROBLEM_AND_TASK_MARKER_ATTRIBUTE_NAMES,
> 				new Object[] { 
> 					task.getMessage(),
>+					S_INFO,
> 					priority,
>-					org.eclipse.jdt.internal.compiler.util.Util.toBoolean(false),
>+					new Integer(id),
> 					new Integer(task.getSourceStart()),
> 					new Integer(task.getSourceEnd() + 1),
> 					new Integer(task.getSourceLineNumber()),

Actions: View | Diff

Attachments on bug 91426: 24372 | 24403