Attachment 147128 Details for Bug 288148 – Proposed fix

[patch] Proposed fix

patch_ 288148.txt (text/plain), 2.29 KB, created by Olivier Thomann

on 2009-09-14 14:40:00 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Thomann

Created: 2009-09-14 14:40:00 EDT

Size: 2.29 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core.tests.performance
>Index: src/org/eclipse/jdt/core/tests/performance/FullSourceWorkspaceCompletionTests.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.performance/src/org/eclipse/jdt/core/tests/performance/FullSourceWorkspaceCompletionTests.java,v
>retrieving revision 1.16
>diff -u -r1.16 FullSourceWorkspaceCompletionTests.java
>--- src/org/eclipse/jdt/core/tests/performance/FullSourceWorkspaceCompletionTests.java	10 Mar 2009 18:40:27 -0000	1.16
>+++ src/org/eclipse/jdt/core/tests/performance/FullSourceWorkspaceCompletionTests.java	14 Sep 2009 18:41:46 -0000
>@@ -16,7 +16,6 @@
> 
> import org.eclipse.jdt.core.*;
> import org.eclipse.jdt.core.tests.model.AbstractJavaModelTests;
>-import org.eclipse.test.performance.Performance;
> 
> /**
>  */
>@@ -176,7 +175,6 @@
> 	}
> 	public void testPerfCompleteMemberAccess() throws JavaModelException {
> 		tagAsGlobalSummary("Codeassist in expression", true); // put in global fingerprint
>-		setComment(Performance.EXPLAINS_DEGRADATION_COMMENT, "Regression introduced to fix bug 250454");
> 		complete(
> 				"org.eclipse.jdt.core",
> 				"org.eclipse.jdt.internal.core",
>Index: src/org/eclipse/jdt/core/tests/performance/FullSourceWorkspaceModelTests.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.performance/src/org/eclipse/jdt/core/tests/performance/FullSourceWorkspaceModelTests.java,v
>retrieving revision 1.45
>diff -u -r1.45 FullSourceWorkspaceModelTests.java
>--- src/org/eclipse/jdt/core/tests/performance/FullSourceWorkspaceModelTests.java	28 Apr 2009 17:53:14 -0000	1.45
>+++ src/org/eclipse/jdt/core/tests/performance/FullSourceWorkspaceModelTests.java	14 Sep 2009 18:41:46 -0000
>@@ -1123,7 +1123,6 @@
> 
> public void testInitJDTPlugin() throws JavaModelException, CoreException {
> 	tagAsSummary("JDT/Core plugin initialization", true); // put in fingerprint
>-	setComment(Performance.EXPLAINS_DEGRADATION_COMMENT, "Added clean-up of internal thread local which imply additional garbage collect during the restart. It concerns only the performance test itself and has no impact in standard Eclipse usage...");
> 
> 	// Warm-up
> 	int wmax = WARMUP_COUNT / 5;

Actions: View | Diff

Attachments on bug 288148: 147128