Attachment 74333 Details for Bug 194529 – Patch disables up/down buttons if the tree is filtered.

[patch] Patch disables up/down buttons if the tree is filtered.

194529.txt (text/plain), 2.60 KB, created by Peter Friese

on 2007-07-23 05:10:33 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Friese

Created: 2007-07-23 05:10:33 EDT

Size: 2.60 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.pde.ui
>Index: src/org/eclipse/pde/internal/ui/editor/plugin/ExtensionsSection.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/ExtensionsSection.java,v
>retrieving revision 1.55
>diff -u -r1.55 ExtensionsSection.java
>--- src/org/eclipse/pde/internal/ui/editor/plugin/ExtensionsSection.java	16 Jul 2007 22:10:18 -0000	1.55
>+++ src/org/eclipse/pde/internal/ui/editor/plugin/ExtensionsSection.java	23 Jul 2007 09:09:51 -0000
>@@ -74,6 +74,8 @@
> import org.eclipse.swt.custom.BusyIndicator;
> import org.eclipse.swt.events.DisposeEvent;
> import org.eclipse.swt.events.DisposeListener;
>+import org.eclipse.swt.events.ModifyEvent;
>+import org.eclipse.swt.events.ModifyListener;
> import org.eclipse.swt.graphics.Cursor;
> import org.eclipse.swt.graphics.Image;
> import org.eclipse.swt.widgets.Composite;
>@@ -239,6 +241,13 @@
> 		createSectionToolbar(section, toolkit);
> 		// Create the adapted listener for the filter entry field
> 		fFilteredTree.createUIListenerEntryFilter(this);
>+		fFilteredTree.getFilterControl().addModifyListener(new ModifyListener() {
>+			public void modifyText(ModifyEvent e) {
>+				StructuredViewer viewer = getStructuredViewerPart().getViewer();
>+				IStructuredSelection ssel = (IStructuredSelection)viewer.getSelection();
>+				updateUpDownButtons(ssel.size() != 1 ? null : ssel.getFirstElement());
>+			}
>+		});
> 	}
> 	
> 	/**
>@@ -1056,6 +1065,14 @@
> 			return;
> 		}
> 		
>+		// Fix for bug 194529
>+		boolean filtered = fFilteredTree.isFiltered();
>+		if (filtered) {
>+			getTreePart().setButtonEnabled(3, false);
>+			getTreePart().setButtonEnabled(4, false);
>+			return;
>+		}
>+		
> 		boolean upEnabled = false;
> 		boolean downEnabled = false;
> 		if (item instanceof IPluginElement) {
>Index: src/org/eclipse/pde/internal/ui/editor/plugin/FormFilteredTree.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/plugin/FormFilteredTree.java,v
>retrieving revision 1.11
>diff -u -r1.11 FormFilteredTree.java
>--- src/org/eclipse/pde/internal/ui/editor/plugin/FormFilteredTree.java	9 Jul 2007 17:44:17 -0000	1.11
>+++ src/org/eclipse/pde/internal/ui/editor/plugin/FormFilteredTree.java	23 Jul 2007 09:09:51 -0000
>@@ -121,4 +121,9 @@
> 		});
> 	}
> 	
>+	public boolean isFiltered() {
>+		String filterText = getFilterControl().getText();
>+		boolean filtered = (filterText != null && filterText.length() > 0);
>+		return filtered;
>+	}
> }

Actions: View | Diff

Attachments on bug 194529: 74333 | 74377