Attachment 72773 Details for Bug 194911 – avoid using the top property

[patch] avoid using the top property

patch.txt (text/plain), 1.69 KB, created by Pierre Candela

on 2007-06-29 08:52:09 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Pierre Candela

Created: 2007-06-29 08:52:09 EDT

Size: 1.69 KB

patch

obsolete

>Index: advanced/searchScoped.jsp
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.help.webapp/advanced/searchScoped.jsp,v
>retrieving revision 1.17
>diff -u -r1.17 searchScoped.jsp
>--- advanced/searchScoped.jsp	26 Mar 2007 15:40:13 -0000	1.17
>+++ advanced/searchScoped.jsp	29 Jun 2007 12:49:12 -0000
>@@ -158,13 +158,13 @@
> <%
> if (data.isIE()){
> %>
>-	var l = top.screenLeft + (top.document.body.clientWidth - w) / 2;
>-	var t = top.screenTop + (top.document.body.clientHeight - h) / 2;
>+	var l = parent.screenLeft + (parent.document.body.clientWidth - w) / 2;
>+	var t = parent.screenTop + (parent.document.body.clientHeight - h) / 2;
> <%
> } else {
> %>
>-	var l = top.screenX + (top.innerWidth - w) / 2;
>-	var t = top.screenY + (top.innerHeight - h) / 2;
>+	var l = parent.screenX + (parent.innerWidth - w) / 2;
>+	var t = parent.screenY + (parent.innerHeight - h) / 2;
> <%
> }
> %>
>Index: advanced/navActions.js
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.help.webapp/advanced/navActions.js,v
>retrieving revision 1.10
>diff -u -r1.10 navActions.js
>--- advanced/navActions.js	7 Mar 2007 21:05:37 -0000	1.10
>+++ advanced/navActions.js	29 Jun 2007 12:49:12 -0000
>@@ -77,7 +77,7 @@
> 	var href = parent.tocViewFrame.getSelectedTopic();
> 	if (href && href != ":blank") {
> 		var contentRect = getWindowBounds(parent.parent.parent.parent.ContentFrame.ContentViewFrame.window);
>-		var topRect = getWindowBounds(top);
>+		var topRect = getWindowBounds(parent.parent.parent.parent.parent);
> 		var w = contentRect.width;
> 		var h = topRect.height;
> 		var x = topRect.x + (topRect.width - w)/2;

Actions: View | Diff

Attachments on bug 194911: 72773