Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 284869 Details for
Bug 569108
The ShowViewsDialog shows disabled views
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
[patch]
Fix in the ViewContentProvider.
Bug-569108-ShowViewDialog-doesnt-filter-disabled-vie.patch (text/plain), 969 bytes, created by
Hannes Niederhausen
on 2020-11-24 07:10:05 EST
(
hide
)
Description:
Fix in the ViewContentProvider.
Filename:
MIME Type:
Creator:
Hannes Niederhausen
Created:
2020-11-24 07:10:05 EST
Size:
969 bytes
patch
obsolete
>diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewContentProvider.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewContentProvider.java >index e347620..d0ba471 100644 >--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewContentProvider.java >+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/ViewContentProvider.java >@@ -183,10 +183,11 @@ > private boolean isFilteredByActivity(String elementId) { > IViewDescriptor[] views = viewRegistry.getViews(); > for (IViewDescriptor descriptor : views) { >- if (descriptor.getId().equals(elementId) && WorkbenchActivityHelper.filterItem(descriptor)) { >- return true; >+ if (descriptor.getId().equals(elementId)) { >+ return WorkbenchActivityHelper.filterItem(descriptor); > } > } >- return false; >+ // if we didn't find the view, we should list it >+ return true; > } > }
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=284869">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 569108
: 284869
