Attachment 203681 Details for Bug 297681 – Patch for Bug 297681

[patch] Patch for Bug 297681

Replaced-printing-of-exceptions-with-logging.patch (text/plain), 1.96 KB, created by Shahin Kahriz

on 2011-09-20 09:57:47 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Shahin Kahriz

Created: 2011-09-20 09:57:47 EDT

Size: 1.96 KB

patch

obsolete

>From 3db8433364819172186ca9301c25d1be6e4066b9 Mon, 12 Sep 2011 11:33:14 -0400
>From: skahriz <skahriz@tpskahriz.ottawa.ibm.com>
>Date: Mon, 12 Sep 2011 11:14:10 -0400
>Subject: [PATCH] Replaced printing of exceptions with logging. 
>
>diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PlatformUIPreferenceListener.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PlatformUIPreferenceListener.java
>index 1999d64..4c3d48e 100644
>--- a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PlatformUIPreferenceListener.java
>+++ b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PlatformUIPreferenceListener.java
>@@ -11,11 +11,14 @@
>  *******************************************************************************/
> package org.eclipse.ui.internal;
> 
>+
>+
> import java.io.IOException;
> import java.io.Reader;
> import java.io.StringReader;
> import java.util.HashMap;
>-
>+import java.util.logging.Level;
>+import java.util.logging.Logger;
> import org.eclipse.core.runtime.preferences.IEclipsePreferences;
> import org.eclipse.core.runtime.preferences.IEclipsePreferences.PreferenceChangeEvent;
> import org.eclipse.jface.preference.IPreferenceStore;
>@@ -40,6 +43,8 @@
> public class PlatformUIPreferenceListener implements
> 		IEclipsePreferences.IPreferenceChangeListener {
> 	
>+	private static final Logger LOG = Logger.getLogger(PlatformUIPreferenceListener.class.getName());
>+
> 	private static PlatformUIPreferenceListener singleton;
> 	
> 	public static IEclipsePreferences.IPreferenceChangeListener getSingleton(){
>@@ -161,13 +166,13 @@
> 						editorRegistry.readResources(editorMap, reader);
> 					}
> 				} catch (WorkbenchException e) {
>-					e.printStackTrace();
>+					LOG.log(Level.WARNING, e.getMessage());
> 				} finally {
> 					if (reader != null) {
> 						try {
> 							reader.close();
> 						} catch (IOException e) {
>-							e.printStackTrace();
>+							LOG.log(Level.WARNING, e.getMessage());
> 						}
> 					}
> 				}

Actions: View | Diff

Attachments on bug 297681: 203681 | 205065