Attachment 153293 Details for Bug 189497 – Proposed patch

[patch] Proposed patch

bug189497.patch (text/plain), 2.62 KB, created by j.o.

on 2009-11-27 20:56:23 EST

(hide)

Description:

Filename:

MIME Type:

Creator: j.o.

Created: 2009-11-27 20:56:23 EST

Size: 2.62 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.debug.ui
>Index: ui/org/eclipse/jdt/internal/debug/ui/breakpoints/AddExceptionAction.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/breakpoints/AddExceptionAction.java,v
>retrieving revision 1.16
>diff -u -r1.16 AddExceptionAction.java
>--- ui/org/eclipse/jdt/internal/debug/ui/breakpoints/AddExceptionAction.java	17 Jul 2007 17:14:14 -0000	1.16
>+++ ui/org/eclipse/jdt/internal/debug/ui/breakpoints/AddExceptionAction.java	28 Nov 2009 01:44:55 -0000
>@@ -54,6 +54,7 @@
> 	public static final String CAUGHT_CHECKED = "caughtChecked"; //$NON-NLS-1$
> 	public static final String UNCAUGHT_CHECKED = "uncaughtChecked"; //$NON-NLS-1$
> 	public static final String DIALOG_SETTINGS = "AddExceptionDialog"; //$NON-NLS-1$
>+	public static final String ENABLE_CHECKPOINT = "Enable Breakpoint"; //$NON-NLS-1$
> 	
> 	private IWorkbenchWindow fWindow = null;
> 
>@@ -117,6 +118,7 @@
> 	 * @since 3.2
> 	 */
> 	private void createBreakpoint(final boolean caught, final boolean uncaught, final IType type) throws CoreException {
>+		IJavaBreakpoint breakpoint = null;
> 		final IResource resource = BreakpointUtils.getBreakpointResource(type);
> 		final Map map = new HashMap(10);
> 		BreakpointUtils.addJavaBreakpointAttributes(map, type);
>@@ -124,7 +126,7 @@
> 						JDIDebugModel.getPluginIdentifier());
> 		boolean exists = false;
> 		for (int j = 0; j < breakpoints.length; j++) {
>-			IJavaBreakpoint breakpoint = (IJavaBreakpoint) breakpoints[j];
>+			breakpoint = (IJavaBreakpoint) breakpoints[j];
> 			if (breakpoint instanceof IJavaExceptionBreakpoint) {
> 				if (breakpoint.getTypeName().equals(type.getFullyQualifiedName())) {
> 					exists = true;
>@@ -146,6 +148,24 @@
> 				}
> 
> 			}.schedule();
>+		} else {
>+			final IJavaBreakpoint existingBreakpoint = breakpoint;
>+			new Job(ENABLE_CHECKPOINT) {
>+	            protected IStatus run(IProgressMonitor monitor) {
>+	                try {
>+	                	if(!existingBreakpoint.isEnabled()){
>+	                		existingBreakpoint.setEnabled(true);
>+	                	}
>+	                    return Status.OK_STATUS;
>+	                } catch (final CoreException e) {
>+	                	/* What to put in here? Failing quietly may be appropriate. 
>+	                	 * I think a CoreException would be raised before performing any changes 
>+	                	 * that would have to be undone. 
>+	                	 */
>+	                }
>+	                return Status.CANCEL_STATUS;
>+	            }
>+	        }.schedule();
> 		}
> 	}
>

Flags:

Michael_Rennie: iplog+

Actions: View | Diff

Attachments on bug 189497: 153293 | 154272