Attachment 132786 Details for Bug 267834 – Patch to tweak the dialog

[patch] Patch to tweak the dialog

patch(267834) (text/plain), 7.53 KB, created by Eric Moffatt

on 2009-04-22 11:04:26 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Moffatt

Created: 2009-04-22 11:04:26 EDT

Size: 7.53 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/WorkbenchMessages.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchMessages.java,v
>retrieving revision 1.115
>diff -u -r1.115 WorkbenchMessages.java
>--- Eclipse UI/org/eclipse/ui/internal/WorkbenchMessages.java	21 Apr 2009 19:50:58 -0000	1.115
>+++ Eclipse UI/org/eclipse/ui/internal/WorkbenchMessages.java	22 Apr 2009 15:03:03 -0000
>@@ -218,7 +218,6 @@
> 	public static String HideItemsCannotMakeVisible_unavailableCommandGroupText;
> 	public static String HideItemsCannotMakeVisible_switchToCommandGroupTab;
> 	public static String HideItemsCannotMakeVisible_unavailableChildrenText;
>-	public static String HideItemsCannotMakeVisible_expandItemText;
> 	
> 	public static String HideMenuItems_menuItemsTab;
> 	public static String HideMenuItems_chooseMenuItemsLabel;
>Index: Eclipse UI/org/eclipse/ui/internal/messages.properties
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/messages.properties,v
>retrieving revision 1.396
>diff -u -r1.396 messages.properties
>--- Eclipse UI/org/eclipse/ui/internal/messages.properties	21 Apr 2009 19:50:58 -0000	1.396
>+++ Eclipse UI/org/eclipse/ui/internal/messages.properties	22 Apr 2009 15:03:03 -0000
>@@ -170,11 +170,10 @@
> HideItems_dynamicItemList = The items which are currently being displayed are:
> HideItems_dynamicItemEmptyList = There are no items which are currently being displayed.
> 
>-HideItemsCannotMakeVisible_dialogTitle = Cannot make items visible
>+HideItemsCannotMakeVisible_dialogTitle = Make Item Visible
> HideItemsCannotMakeVisible_unavailableCommandGroupText = "{0}" cannot be made visible because it is in the unavailable "{1}" command group.
> HideItemsCannotMakeVisible_switchToCommandGroupTab = Would you like to switch to the Command Group Availability tab?
> HideItemsCannotMakeVisible_unavailableChildrenText = "{0}" cannot be made visible because all of its children are in unavailable command groups.
>-HideItemsCannotMakeVisible_expandItemText =Would you like to expand it to see its children?
>  
> HideMenuItems_menuItemsTab = Menu Visibility
> HideMenuItems_chooseMenuItemsLabel = Choose which menu items to display.
>Index: Eclipse UI/org/eclipse/ui/internal/dialogs/CustomizePerspectiveDialog.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/dialogs/CustomizePerspectiveDialog.java,v
>retrieving revision 1.75
>diff -u -r1.75 CustomizePerspectiveDialog.java
>--- Eclipse UI/org/eclipse/ui/internal/dialogs/CustomizePerspectiveDialog.java	1 Apr 2009 16:14:55 -0000	1.75
>+++ Eclipse UI/org/eclipse/ui/internal/dialogs/CustomizePerspectiveDialog.java	22 Apr 2009 15:03:03 -0000
>@@ -23,49 +23,9 @@
> import java.util.Map;
> import java.util.Set;
> 
>-import org.eclipse.osgi.util.NLS;
>-
>-import org.eclipse.swt.SWT;
>-import org.eclipse.swt.custom.SashForm;
>-import org.eclipse.swt.events.SelectionEvent;
>-import org.eclipse.swt.events.SelectionListener;
>-import org.eclipse.swt.graphics.Color;
>-import org.eclipse.swt.graphics.Font;
>-import org.eclipse.swt.graphics.FontData;
>-import org.eclipse.swt.graphics.Image;
>-import org.eclipse.swt.graphics.Point;
>-import org.eclipse.swt.graphics.Resource;
>-import org.eclipse.swt.layout.GridData;
>-import org.eclipse.swt.layout.GridLayout;
>-import org.eclipse.swt.widgets.Button;
>-import org.eclipse.swt.widgets.Combo;
>-import org.eclipse.swt.widgets.Composite;
>-import org.eclipse.swt.widgets.Control;
>-import org.eclipse.swt.widgets.CoolBar;
>-import org.eclipse.swt.widgets.CoolItem;
>-import org.eclipse.swt.widgets.Decorations;
>-import org.eclipse.swt.widgets.Display;
>-import org.eclipse.swt.widgets.Event;
>-import org.eclipse.swt.widgets.Label;
>-import org.eclipse.swt.widgets.Link;
>-import org.eclipse.swt.widgets.Menu;
>-import org.eclipse.swt.widgets.MenuItem;
>-import org.eclipse.swt.widgets.MessageBox;
>-import org.eclipse.swt.widgets.Shell;
>-import org.eclipse.swt.widgets.TabFolder;
>-import org.eclipse.swt.widgets.TabItem;
>-import org.eclipse.swt.widgets.Table;
>-import org.eclipse.swt.widgets.TableColumn;
>-import org.eclipse.swt.widgets.TableItem;
>-import org.eclipse.swt.widgets.ToolBar;
>-import org.eclipse.swt.widgets.ToolItem;
>-import org.eclipse.swt.widgets.Tree;
>-
> import org.eclipse.core.commands.Command;
> import org.eclipse.core.commands.ParameterizedCommand;
>-
> import org.eclipse.core.runtime.CoreException;
>-
> import org.eclipse.jface.action.ActionContributionItem;
> import org.eclipse.jface.action.ContributionManager;
> import org.eclipse.jface.action.CoolBarManager;
>@@ -113,7 +73,42 @@
> import org.eclipse.jface.viewers.ViewerCell;
> import org.eclipse.jface.viewers.ViewerFilter;
> import org.eclipse.jface.window.ToolTip;
>-
>+import org.eclipse.osgi.util.NLS;
>+import org.eclipse.swt.SWT;
>+import org.eclipse.swt.custom.SashForm;
>+import org.eclipse.swt.events.SelectionEvent;
>+import org.eclipse.swt.events.SelectionListener;
>+import org.eclipse.swt.graphics.Color;
>+import org.eclipse.swt.graphics.Font;
>+import org.eclipse.swt.graphics.FontData;
>+import org.eclipse.swt.graphics.Image;
>+import org.eclipse.swt.graphics.Point;
>+import org.eclipse.swt.graphics.Resource;
>+import org.eclipse.swt.layout.GridData;
>+import org.eclipse.swt.layout.GridLayout;
>+import org.eclipse.swt.widgets.Button;
>+import org.eclipse.swt.widgets.Combo;
>+import org.eclipse.swt.widgets.Composite;
>+import org.eclipse.swt.widgets.Control;
>+import org.eclipse.swt.widgets.CoolBar;
>+import org.eclipse.swt.widgets.CoolItem;
>+import org.eclipse.swt.widgets.Decorations;
>+import org.eclipse.swt.widgets.Display;
>+import org.eclipse.swt.widgets.Event;
>+import org.eclipse.swt.widgets.Label;
>+import org.eclipse.swt.widgets.Link;
>+import org.eclipse.swt.widgets.Menu;
>+import org.eclipse.swt.widgets.MenuItem;
>+import org.eclipse.swt.widgets.MessageBox;
>+import org.eclipse.swt.widgets.Shell;
>+import org.eclipse.swt.widgets.TabFolder;
>+import org.eclipse.swt.widgets.TabItem;
>+import org.eclipse.swt.widgets.Table;
>+import org.eclipse.swt.widgets.TableColumn;
>+import org.eclipse.swt.widgets.TableItem;
>+import org.eclipse.swt.widgets.ToolBar;
>+import org.eclipse.swt.widgets.ToolItem;
>+import org.eclipse.swt.widgets.Tree;
> import org.eclipse.ui.IActionBars2;
> import org.eclipse.ui.IPerspectiveDescriptor;
> import org.eclipse.ui.IPerspectiveRegistry;
>@@ -1260,23 +1255,19 @@
> 					mb.open();
> 				} else {
> 					MessageBox mb = new MessageBox(viewer.getControl()
>-							.getShell(), SWT.YES | SWT.NO | SWT.ICON_WARNING);
>+							.getShell(), SWT.OK | SWT.ICON_WARNING);
> 					mb
> 							.setText(WorkbenchMessages.HideItemsCannotMakeVisible_dialogTitle);
> 					mb
> 							.setMessage(NLS
> 									.bind(
> 											WorkbenchMessages.HideItemsCannotMakeVisible_unavailableChildrenText,
>-											item.getLabel())
>-									+ WorkbenchMessages.HideItemsCannotMakeVisible_expandItemText);
>-					if (mb.open() == SWT.YES) {
>-						viewer.setExpandedState(item, true);
>-					}
>+											item.getLabel()));
>+					mb.open();
> 				}
> 			} else {
> 				// the case where this item is unavailable because it belongs to
>-				// an
>-				// unavailable action set
>+				// an unavailable action set
> 				MessageBox mb = new MessageBox(viewer.getControl().getShell(),
> 						SWT.YES | SWT.NO | SWT.ICON_WARNING);
> 				mb

Actions: View | Diff

Attachments on bug 267834: 128182 | 132786