Download
Getting Started
Members
Projects
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
More
Community
Marketplace
Events
Planet Eclipse
Newsletter
Videos
Participate
Report a Bug
Forums
Mailing Lists
Wiki
IRC
How to Contribute
Working Groups
Automotive
Internet of Things
LocationTech
Long-Term Support
PolarSys
Science
OpenMDM
Toggle navigation
Bugzilla – Attachment 105166 Details for
Bug 237294
[results] Performance test not grey from degredation comment
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
Log In
[x]
|
Terms of Use
|
Copyright Agent
[patch]
Proposed patch
v00.txt (text/plain), 3.45 KB, created by
Frederic Fusier
on 2008-06-17 10:14:11 EDT
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Frederic Fusier
Created:
2008-06-17 10:14:11 EDT
Size:
3.45 KB
patch
obsolete
>### Eclipse Workspace Patch 1.0 >#P org.eclipse.test.performance >Index: src/org/eclipse/test/internal/performance/results/DB_Results.java >=================================================================== >RCS file: /cvsroot/eclipse/org.eclipse.test.performance/src/org/eclipse/test/internal/performance/results/DB_Results.java,v >retrieving revision 1.3 >diff -u -r1.3 DB_Results.java >--- src/org/eclipse/test/internal/performance/results/DB_Results.java 1 Feb 2008 17:17:45 -0000 1.3 >+++ src/org/eclipse/test/internal/performance/results/DB_Results.java 17 Jun 2008 14:13:34 -0000 >@@ -696,9 +696,7 @@ > int scenarioID = scenarioResults.getId(); > // First try to get summaries of elapsed process dimension > result = fSQL.queryScenarioSummaries(scenarioID, config, cBuildName, bBuildName, InternalDimensions.ELAPSED_PROCESS.getId()); >- boolean hasResults = false; > while (result.next()) { >- hasResults = true; > String variation = result.getString(1); > int summaryKind = result.getShort(2); > int comment_id = result.getInt(3); >@@ -715,24 +713,22 @@ > buildResults.setSummary(summaryKind, COMMENTS[comment_id]); > } > } >- if (!hasResults) { >- // Scenario is not a fingerprint, try to get comments >- result = fSQL.queryScenarioSummaries(scenarioID, config, cBuildName, bBuildName, 0); >- while (result.next()) { >- String variation = result.getString(1); >- int comment_id = result.getInt(3); >- StringTokenizer tokenizer = new StringTokenizer(variation, "=|"); //$NON-NLS-1$ >- tokenizer.nextToken(); // 'build' >- String buildName = tokenizer.nextToken(); // 'I20070615-1200' >- BuildResults buildResults = null; >- if (buildName.equals(currentBuildName)) { >- buildResults = currentBuild; >- } else if (buildName.equals(baselineBuildName)) { >- buildResults = baselineBuild; >- } >- if (buildResults != null) { >- buildResults.setComment(COMMENTS[comment_id]); >- } >+ // Update scenario comment if any >+ result = fSQL.queryScenarioSummaries(scenarioID, config, cBuildName, bBuildName, 0); >+ while (result.next()) { >+ String variation = result.getString(1); >+ int comment_id = result.getInt(3); >+ StringTokenizer tokenizer = new StringTokenizer(variation, "=|"); //$NON-NLS-1$ >+ tokenizer.nextToken(); // 'build' >+ String buildName = tokenizer.nextToken(); // 'I20070615-1200' >+ BuildResults buildResults = null; >+ if (buildName.equals(currentBuildName)) { >+ buildResults = currentBuild; >+ } else if (buildName.equals(baselineBuildName)) { >+ buildResults = baselineBuild; >+ } >+ if (buildResults != null) { >+ buildResults.setComment(COMMENTS[comment_id]); > } > } > } catch (SQLException e) { >Index: src/org/eclipse/test/internal/performance/results/BuildResults.java >=================================================================== >RCS file: /cvsroot/eclipse/org.eclipse.test.performance/src/org/eclipse/test/internal/performance/results/BuildResults.java,v >retrieving revision 1.5 >diff -u -r1.5 BuildResults.java >--- src/org/eclipse/test/internal/performance/results/BuildResults.java 1 Feb 2008 17:17:45 -0000 1.5 >+++ src/org/eclipse/test/internal/performance/results/BuildResults.java 17 Jun 2008 14:13:34 -0000 >@@ -322,7 +322,9 @@ > * Set the build summary and its associated comment. > */ > void setComment(String comment) { >- this.comment = comment; >+ if (comment != null && this.comment == null) { >+ this.comment = comment; >+ } > } > > /*
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 237294
: 105166