Attachment 101038 Details for Bug 228648 – [proposed patch + test case] on top v865

[patch] [proposed patch + test case] on top v865

v00_top_v_865.txt (text/plain), 3.52 KB, created by Eric Jodet

on 2008-05-20 10:03:08 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Eric Jodet

Created: 2008-05-20 10:03:08 EDT

Size: 3.52 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.jdt.core
>Index: compiler/org/eclipse/jdt/internal/compiler/ast/JavadocArgumentExpression.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler/ast/JavadocArgumentExpression.java,v
>retrieving revision 1.22
>diff -u -r1.22 JavadocArgumentExpression.java
>--- compiler/org/eclipse/jdt/internal/compiler/ast/JavadocArgumentExpression.java	7 Jan 2008 14:16:21 -0000	1.22
>+++ compiler/org/eclipse/jdt/internal/compiler/ast/JavadocArgumentExpression.java	20 May 2008 13:46:41 -0000
>@@ -47,7 +47,8 @@
> 						this.resolvedType.leafComponentType().enclosingType() != null &&
> 						scope.compilerOptions().complianceLevel <= ClassFileConstants.JDK1_4) {
> 					scope.problemReporter().javadocInvalidMemberTypeQualification(this.sourceStart, this.sourceEnd, scope.getDeclarationModifiers());
>-					return null;
>+					// https://bugs.eclipse.org/bugs/show_bug.cgi?id=228648
>+					// do not return now but report unresolved reference as expected depending on compliance settings
> 				}
> 				if (!this.resolvedType.isValidBinding()) {
> 					scope.problemReporter().javadocInvalidType(typeRef, this.resolvedType, scope.getDeclarationModifiers());
>#P org.eclipse.jdt.core.tests.model
>Index: src/org/eclipse/jdt/core/tests/dom/ASTConverterJavadocTest.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverterJavadocTest.java,v
>retrieving revision 1.77
>diff -u -r1.77 ASTConverterJavadocTest.java
>--- src/org/eclipse/jdt/core/tests/dom/ASTConverterJavadocTest.java	22 Feb 2008 09:46:44 -0000	1.77
>+++ src/org/eclipse/jdt/core/tests/dom/ASTConverterJavadocTest.java	20 May 2008 13:46:43 -0000
>@@ -3472,4 +3472,13 @@
> 			assumeEquals("Enum constant declaration "+constantDeclaration+" does not have the correct length", commentEnd, declarationEnd);
> 		}
> 	}
>+	
>+	/**
>+	 * @bug 228648: AST: no binding for Javadoc reference to inner class
>+	 * @see "https://bugs.eclipse.org/bugs/show_bug.cgi?id=228648"
>+	 */
>+	public void testBug228648() throws JavaModelException {
>+		ICompilationUnit unit = getCompilationUnit("Converter" , "src", "javadoc.testBug228648", "A.java"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$
>+		verifyComments(unit);
>+	}
> }
>Index: workspace/Converter/src/javadoc/testBug228648/A.java
>===================================================================
>RCS file: workspace/Converter/src/javadoc/testBug228648/A.java
>diff -N workspace/Converter/src/javadoc/testBug228648/A.java
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ workspace/Converter/src/javadoc/testBug228648/A.java	1 Jan 1970 00:00:00 -0000
>@@ -0,0 +1,12 @@
>+package javadoc.testBug228648;
>+import javadoc.testBug228648.B.Inner;
>+/**
>+ * {@link #foo(Inner)}
>+ * {@link #foo2(B)}
>+ */
>+public class A {
>+        public void foo(Inner inner) {
>+        }
>+        public void foo2(B b) {
>+        }
>+}
>Index: workspace/Converter/src/javadoc/testBug228648/B.java
>===================================================================
>RCS file: workspace/Converter/src/javadoc/testBug228648/B.java
>diff -N workspace/Converter/src/javadoc/testBug228648/B.java
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ workspace/Converter/src/javadoc/testBug228648/B.java	1 Jan 1970 00:00:00 -0000
>@@ -0,0 +1,5 @@
>+package javadoc.testBug228648;
>+public class B {
>+        class Inner {   
>+        }
>+}

Actions: View | Diff

Attachments on bug 228648: 101038