Attachment #265890 for bug #509247

View | Details | Raw Unified | Return to bug 509247
Collapse All | Expand All





		System.out.print("file contents: |");
		File file= cu.getResource().getLocation().toFile();
		try (BufferedReader reader= new BufferedReader(new FileReader(file))) {
			BufferedReader reader= new BufferedReader(new FileReader(file));
			String line;
			while ((line= reader.readLine()) != null) {
				System.out.println(line);
			}
			System.out.println("|");
			reader.close();
		} catch (FileNotFoundException e1) {
			e1.printStackTrace();
		} catch (IOException e1) {





		Enumeration<? extends ZipEntry> entries = zipFile.entries();

		while(entries.hasMoreElements()){
			ZipEntry entry = entries.nextElement();
			if(entry.isDirectory()){
				continue;
					continue;
				}
				String entryName = entry.getName();
				File file = new File(dstDir, changeSeparator(entryName, '/', File.separatorChar));
				file.getParentFile().mkdirs();
				InputStream src = null;
				OutputStream dst = null;
				try {
					src = zipFile.getInputStream(entry);
					dst = new FileOutputStream(file);
					transferData(src, dst);
				} finally {
					if(dst != null){
						try {
							dst.close();
						} catch(IOException e){
						}
					}
					if(src != null){
						try {
							src.close();
						} catch(IOException e){
						}
					}
				}
			}
			String entryName = entry.getName();
			File file = new File(dstDir, changeSeparator(entryName, '/', File.separatorChar));
			file.getParentFile().mkdirs();
			try (InputStream src = zipFile.getInputStream(entry);
					OutputStream dst = new FileOutputStream(file)) {
				transferData(src, dst);
			}
		}
	}

	 */
	public static void transferData(File source, File destination) throws IOException {
		destination.getParentFile().mkdirs();
		try (InputStream is = new FileInputStream(source);
				OutputStream os = new FileOutputStream(destination)) {
		try {
			is = new FileInputStream(source);
			os = new FileOutputStream(destination);
			transferData(is, os);
		} finally {
			if(os != null){
				try {
					os.close();
				} catch(IOException e){
				}
			}
			if(is != null){
				try {
					is.close();
				} catch(IOException e){
				}
			}
		}
	}


	}

	public static StringBuffer read(String fileName) throws IOException {
		try (Reader reader = new FileReader(fileName)) {
			return read(reader);
		}
	}

	public static StringBuffer read(Reader reader) throws IOException {
		StringBuffer s= new StringBuffer();
		char[] buffer= new char[8196];
		int chars= reader.read(buffer);
		while (chars != -1) {
			s.append(buffer, 0, chars);
			chars= reader.read(buffer);
				chars= reader.read(buffer);
			}
		} finally {
			try {
				reader.close();
			} catch (IOException e) {
			}
		}
		return s;
	}

	public static void write(String fileName, StringBuffer content) throws IOException {
		try (Writer writer= new FileWriter(fileName)) {
		try {
			writer.write(content.toString());
		} finally {
			try {
				writer.close();
			} catch (IOException e) {
			}
		}
	}
}

Lines 217-223 Link Here

(-)a/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/performance/ResourceTestHelper.java (-1 / +3 lines)
217		217
218	public static IProject createProjectFromZip(Plugin installationPlugin, String projectZip, String projectName) throws IOException, ZipException, CoreException {	218	public static IProject createProjectFromZip(Plugin installationPlugin, String projectZip, String projectName) throws IOException, ZipException, CoreException {
219	String workspacePath= ResourcesPlugin.getWorkspace().getRoot().getLocation().toString() + "/";	219	String workspacePath= ResourcesPlugin.getWorkspace().getRoot().getLocation().toString() + "/";
220	FileTool.unzip(new ZipFile(FileTool.getFileInPlugin(installationPlugin, new Path(projectZip))), new File(workspacePath));	220	try (ZipFile zipFile =new ZipFile(FileTool.getFileInPlugin(installationPlugin, new Path(projectZip)))) {
		221	FileTool.unzip(zipFile, new File(workspacePath));
		222	}
221	return createExistingProject(projectName);	223	return createExistingProject(projectName);
222	}	224	}
223		225




	}

	public static String getContents(InputStream in) throws IOException {
		BufferedReader br= new BufferedReader(new InputStreamReader(in));

		StringBuffer sb= new StringBuffer(300);
		try (BufferedReader br= new BufferedReader(new InputStreamReader(in))) {
			int read= 0;
			while ((read= br.read()) != -1)
				sb.append((char) read);
		} finally {
			br.close();
		}
		return sb.toString();
	}





		helper2(new String[]{"my.pack", "my"}, new String[][]{{}, {}}, "my");

		InputStreamReader reader= new InputStreamReader(textfile.getContents(true));
		StringBuffer newContent= new StringBuffer();
		try (InputStreamReader reader= new InputStreamReader(textfile.getContents(true))) {
			int ch;
			while((ch= reader.read()) != -1)
				newContent.append((char)ch);
		} finally {
			reader.close();
		}
		String definedContent= getFileContents(getTestPath() + getName() + TEST_OUTPUT_INFIX + "my/" + textFileName);
		assertEqualLines("invalid updating", definedContent, newContent.toString());


		helper2(new String[]{"r.p1", "r"}, new String[][]{{"A"}, {"A"}}, "q");

		InputStreamReader reader= new InputStreamReader(textfile.getContents(true));
		StringBuffer newContent= new StringBuffer();
		try (InputStreamReader reader= new InputStreamReader(textfile.getContents(true))) {
			int ch;
			while((ch= reader.read()) != -1)
				newContent.append((char)ch);
		} finally {
			reader.close();
		}
		String definedContent= getFileContents(getTestPath() + getName() + TEST_OUTPUT_INFIX + textFileName);
		assertEqualLines("invalid updating", definedContent, newContent.toString());





		ICompilationUnit newcu= getPackageP().getCompilationUnit(newName + ".java");
		assertEqualLines("invalid renaming", getFileContents(getOutputTestFileName(newName)), newcu.getSource());
		InputStreamReader reader= new InputStreamReader(file.getContents(true));
		StringBuffer newContent= new StringBuffer();
		try (InputStreamReader reader= new InputStreamReader(file.getContents(true))) {
			int ch;
			while((ch= reader.read()) != -1)
				newContent.append((char)ch);
		} finally {
			reader.close();
		}
		String definedContent= getFileContents(getTestPath() + getName() + TEST_OUTPUT_INFIX + textFileName);
		assertEqualLines("invalid updating", definedContent, newContent.toString());


		helper3("SomeClass", "SomeDifferentClass", true, true, true, "test.html");

		InputStreamReader reader= new InputStreamReader(file.getContents(true));
		StringBuffer newContent= new StringBuffer();
		try (InputStreamReader reader= new InputStreamReader(file.getContents(true))) {
			int ch;
			while((ch= reader.read()) != -1)
				newContent.append((char)ch);
		} finally {
			reader.close();
		}
		String definedContent= getFileContents(getTestPath() + "testSimilarElements05/out/test.html");
		assertEqualLines("invalid updating test.html", newContent.toString(), definedContent);




	}

	protected String getFileContents(InputStream in) throws IOException {
		BufferedReader br= new BufferedReader(new InputStreamReader(in));

		StringBuffer sb= new StringBuffer();
		try (BufferedReader br= new BufferedReader(new InputStreamReader(in))) {
			int read= 0;
			while ((read= br.read()) != -1)
				sb.append((char) read);
		} finally {
			br.close();
		}
		return sb.toString();
	}

Lines 292-300 Link Here

(-)a/org.eclipse.jdt.ui.tests.refactoring/test cases/org/eclipse/jdt/ui/tests/refactoring/nls/NLSHintTest.java (-3 / +3 lines)
292	private IFile createResource(IPackageFragment pack, String resourceName, String content) throws Exception {	292	private IFile createResource(IPackageFragment pack, String resourceName, String content) throws Exception {
293	IPath path = pack.getPath().append(resourceName);	293	IPath path = pack.getPath().append(resourceName);
294	IFile file = ResourcesPlugin.getWorkspace().getRoot().getFile(path);	294	IFile file = ResourcesPlugin.getWorkspace().getRoot().getFile(path);
295	InputStream is = new ByteArrayInputStream(content.getBytes());	295	try (InputStream is = new ByteArrayInputStream(content.getBytes())) {
296	file.create(is, true, new NullProgressMonitor());	296	file.create(is, true, new NullProgressMonitor());
297	is.close();	297	}
298	return file;	298	return file;
299	}	299	}
300		300




	}

	private void checkContentOfFile(String message, IFile file, String content) throws Exception {
		try (InputStream in= file.getContents()) {
		try {
			String realContent= copyToString(in);
			RefactoringTest.assertEqualLines(message, content, realContent);
		} finally {
			in.close();
		}
	}

	private String copyToString(InputStream in) throws Exception {
		try (ByteArrayOutputStream out= new ByteArrayOutputStream()) {
			int read= in.read();
			while (read != -1) {
				out.write(read);
				read= in.read();
			}
			return out.toString();
		}
		out.close();
		return out.toString();
	}

	private NLSRefactoring createDefaultNls(ICompilationUnit cu) {

Lines 84-92 Link Here

(-)a/org.eclipse.jdt.ui.tests.refactoring/test cases/org/eclipse/jdt/ui/tests/refactoring/nls/NlsRefactoringTestHelper.java (-3 / +3 lines)
84		84
85	private IFile createFile(IPath path, String content) throws Exception {	85	private IFile createFile(IPath path, String content) throws Exception {
86	IFile file = ResourcesPlugin.getWorkspace().getRoot().getFile(path);	86	IFile file = ResourcesPlugin.getWorkspace().getRoot().getFile(path);
87	InputStream iS = getInputStream(content);	87	try (InputStream iS = getInputStream(content)) {
88	file.create(iS, true, fNpm);	88	file.create(iS, true, fNpm);
89	iS.close();	89	}
90	return file;	90	return file;
91	}	91	}
92		92




	 * @see #addFromStream(InputStream, boolean)
	 */
	public void addFromFile(File file, boolean allowDuplicates) throws CoreException {
		try (InputStream stream= new FileInputStream(file)) {

		try {
			stream= new FileInputStream(file);
			addFromStream(stream, allowDuplicates);

		} catch (IOException e) {
			throwReadException(e);

		} finally {
			try {
				if (stream != null)
					stream.close();
			} catch (IOException e) {
				// just exit
			}
		}
	}


	 * @see #saveToStream(OutputStream)
	 */
	public void saveToFile(File file) throws CoreException {
		try (OutputStream stream= new FileOutputStream(file)) {

		try {
			stream= new FileOutputStream(file);
			saveToStream(stream);

		} catch (IOException e) {
			throwWriteException(e);

		} finally {
			try {
				if (stream != null)
					stream.close();
			} catch (IOException e) {
				// just exit
			}
		}
	}





		IPath stateLocation= JavaPlugin.getDefault().getStateLocation().append(fFileName);
		File file= stateLocation.toFile();
		if (file.exists()) {
			try (InputStreamReader reader = new InputStreamReader(new FileInputStream(file), "utf-8")) { //$NON-NLS-1$
	        try {
				reader = new InputStreamReader(new FileInputStream(file), "utf-8");//$NON-NLS-1$
				load(new InputSource(reader));
			} catch (IOException e) {
				JavaPlugin.log(e);
			} catch (CoreException e) {
				JavaPlugin.log(e);
			} finally {
				try {
					if (reader != null)
						reader.close();
				} catch (IOException e) {
					JavaPlugin.log(e);
				}
			}
		}
	}

	public synchronized void save() {
		IPath stateLocation= JavaPlugin.getDefault().getStateLocation().append(fFileName);
		File file= stateLocation.toFile();
		try (OutputStream out= new FileOutputStream(file)) {
		try {
			out= new FileOutputStream(file);
			save(out);
		} catch (IOException e) {
			JavaPlugin.log(e);

			// The XML library can be misconficgured (e.g. via
			// -Djava.endorsed.dirs=C:\notExisting\xerces-2_7_1)
			JavaPlugin.log(e);
		} finally {
			try {
				if (out != null) {
					out.close();
				}
			} catch (IOException e) {
				JavaPlugin.log(e);
			}
		}
	}






	private static int getFileLength(IFile file) throws CoreException {
		// Cannot use file buffers here, since they are not yet in sync at this point.
		try (InputStream contents= file.getContents()) {
			@SuppressWarnings("resource")
			InputStreamReader reader = null;
			try {
				reader= new InputStreamReader(contents, file.getCharset());
			} catch (UnsupportedEncodingException e) {
				JavaPlugin.log(e);
				reader= new InputStreamReader(contents);
			}
			try {
				return (int) reader.skip(Integer.MAX_VALUE);
			} finally {
				try {
					reader.close();
				} catch (IOException e) {
					// ignore
				}
			}
		} catch (IOException e) {
			throw new CoreException(new Status(IStatus.ERROR, Corext.getPluginId(), e.getMessage(), e));
		} 
			try {
				reader.close();
			} catch (IOException e) {
			}
		}
	}

	private boolean confirmDeleteIfReferenced() throws JavaModelException {




	@Override
	public Change perform(IProgressMonitor pm) throws CoreException, OperationCanceledException {

		InputStream is= null;
		try {
			pm.beginTask(NLSChangesMessages.createFile_creating_resource, 3);


				pm.worked(1);
				return composite.perform(new SubProgressMonitor(pm, 1));
			} else { */
			try (InputStream is= new ByteArrayInputStream(fSource.getBytes(fEncoding))) {
				is= new ByteArrayInputStream(fSource.getBytes(fEncoding));
				file.create(is, false, new SubProgressMonitor(pm, 1));
				if (fStampToRestore != IResource.NULL_STAMP) {
					file.revertModificationStamp(fStampToRestore);

				return new DeleteResourceChange(file.getFullPath(), true);
			} catch (UnsupportedEncodingException e) {
				throw new JavaModelException(e, IJavaModelStatusConstants.IO_EXCEPTION);
			}
		} finally {
			try {
				if (is != null)
					is.close();
			} catch (IOException ioe) {
				throw new JavaModelException(ioe, IJavaModelStatusConstants.IO_EXCEPTION);
			} finally {
				pm.done();
			}
		} finally {
			pm.done();
		}
	}





		IFile file= getOldFile(new NullProgressMonitor());
		if (! file.exists())
			return ""; //$NON-NLS-1$
		try (InputStream stream= file.getContents()) {
		try{
			stream= file.getContents();
			String encoding= file.getCharset();
			String c= NLSUtil.readString(stream, encoding);
			return (c == null) ? "": c; //$NON-NLS-1$
		} catch (CoreException e){
			throw new JavaModelException(e, IJavaModelStatusConstants.CORE_EXCEPTION);
		} catch (IOException e) {
			throw new JavaModelException(e, IJavaModelStatusConstants.IO_EXCEPTION);
				if (stream != null)
					stream.close();
			} catch (IOException x) {
			}
		}
	}





		 *  (String) handle identifier
		 */

		try (ByteArrayOutputStream out= new ByteArrayOutputStream();
				DataOutputStream dataOut= new DataOutputStream(out)) {
			DataOutputStream dataOut= new DataOutputStream(out);

			//write the number of elements
			dataOut.writeInt(javaElements.length);

			for (int i= 0; i < javaElements.length; i++) {
				writeJavaElement(dataOut, javaElements[i]);
			}

			//cleanup
			dataOut.close();
			out.close();
			byte[] bytes= out.toByteArray();
			super.javaToNative(bytes, transferData);
		} catch (IOException e) {




		}
		ClassLoader jceClassLoader = new URLClassLoader(rsrcUrls, null);
		Thread.currentThread().setContextClassLoader(jceClassLoader);
		Class<?> c = Class.forName(mi.rsrcMainClass, true, jceClassLoader);
		Method main = c.getMethod(JIJConstants.MAIN_METHOD_NAME, new Class[]{args.getClass()}); 
		main.invoke((Object)null, new Object[]{args});
	}

	private static ManifestInfo getManifestInfo() throws IOException {
		Enumeration<URL> resEnum = Thread.currentThread().getContextClassLoader().getResources(JarFile.MANIFEST_NAME); 
		resEnum = Thread.currentThread().getContextClassLoader().getResources(JarFile.MANIFEST_NAME); 
		while (resEnum.hasMoreElements()) {
			try {
				URL url = resEnum.nextElement();
				try (InputStream is = url.openStream()) {
					if (is != null) {
						ManifestInfo result = new ManifestInfo();
						Manifest manifest = new Manifest(is);
						Attributes mainAttribs = manifest.getMainAttributes();
						result.rsrcMainClass = mainAttribs.getValue(JIJConstants.REDIRECTED_MAIN_CLASS_MANIFEST_NAME); 
						String rsrcCP = mainAttribs.getValue(JIJConstants.REDIRECTED_CLASS_PATH_MANIFEST_NAME); 
						if (rsrcCP == null)
							rsrcCP = JIJConstants.DEFAULT_REDIRECTED_CLASSPATH; 
						result.rsrcClassPath = splitSpaces(rsrcCP);
						if ((result.rsrcMainClass != null) && !result.rsrcMainClass.trim().equals(""))    //$NON-NLS-1$
								return result;
					}
				}
			}
			catch (Exception e) {

	private static String[] splitSpaces(String line) {
		if (line == null) 
			return null;
		List<String> result = new ArrayList<>();
		int firstPos = 0;
		while (firstPos < line.length()) {
			int lastPos = line.indexOf(' ', firstPos);

			}
			firstPos = lastPos+1; 
		}
		return result.toArray(new String[result.size()]);
	}

}

Lines 36-44 Link Here

(-)a/org.eclipse.jdt.ui/jar in jar loader/org/eclipse/jdt/internal/jarinjarloader/RsrcURLConnection.java (+2 lines)
36	this.classLoader= classLoader;	36	this.classLoader= classLoader;
37	}	37	}
38		38
		39	@Override
39	public void connect() throws IOException {	40	public void connect() throws IOException {
40	}	41	}
41		42
		43	@Override
42	public InputStream getInputStream() throws IOException {	44	public InputStream getInputStream() throws IOException {
43	String file= URLDecoder.decode(url.getFile(), JIJConstants.UTF8_ENCODING);	45	String file= URLDecoder.decode(url.getFile(), JIJConstants.UTF8_ENCODING);
44	InputStream result= classLoader.getResourceAsStream(file);	46	InputStream result= classLoader.getResourceAsStream(file);




    	this.classLoader = classLoader;
	}

	@Override
	protected java.net.URLConnection openConnection(URL u) throws IOException {
    	return new RsrcURLConnection(u, classLoader);
    }

    @Override
	protected void parseURL(URL url, String spec, int start, int limit) {
    	String file;
    	if (spec.startsWith(JIJConstants.INTERNAL_URL_PROTOCOL_WITH_COLON))  
    		file = spec.substring(5);

Lines 31-36 Link Here

(-)a/org.eclipse.jdt.ui/jar in jar loader/org/eclipse/jdt/internal/jarinjarloader/RsrcURLStreamHandlerFactory.java (+1 lines)
31	this.classLoader = cl;	31	this.classLoader = cl;
32	}	32	}
33		33
		34	@Override
34	public URLStreamHandler createURLStreamHandler(String protocol) {	35	public URLStreamHandler createURLStreamHandler(String protocol) {
35	if (JIJConstants.INTERNAL_URL_PROTOCOL.equals(protocol))	36	if (JIJConstants.INTERNAL_URL_PROTOCOL.equals(protocol))
36	return new RsrcURLStreamHandler(classLoader);	37	return new RsrcURLStreamHandler(classLoader);

Added Link Here

(-)a/org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/nls/ExternalizeWizardPage.java (-6 / +7 lines)
11	*******************************************************************************/	11	*******************************************************************************/
12	package org.eclipse.jdt.internal.ui.refactoring.nls;	12	package org.eclipse.jdt.internal.ui.refactoring.nls;
13		13
14	import java.io.IOException;
14	import java.io.InputStream;	15	import java.io.InputStream;
15	import java.util.ArrayList;	16	import java.util.ArrayList;
16	import java.util.Collections;	17	import java.util.Collections;
Added Link Here
698		699
699	private Properties getProperties(IFile propertyFile) {	700	private Properties getProperties(IFile propertyFile) {
700	Properties props= new Properties();	701	Properties props= new Properties();
701	try {	702	if (propertyFile.exists()) {
702	if (propertyFile.exists()) {	703	try (InputStream is= propertyFile.getContents()) {
703	InputStream is= propertyFile.getContents();
704	props.load(is);	704	props.load(is);
705	is.close();	705	} catch (IOException e) {
		706	// sorry no property
		707	} catch (CoreException e) {
		708	// sorry no property
706	}	709	}
707	} catch (Exception e) {
708	// sorry no property
709	}	710	}
710	return props;	711	return props;
711	}	712	}

Lines 17-23 Link Here

(-)a/org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/nls/search/LineReader.java (-1 / +2 lines)
17	import java.io.Reader;	17	import java.io.Reader;
18		18
19		19
20	class LineReader extends Object {	20	class LineReader extends Object implements AutoCloseable {
21	protected static final int LF= '\n';	21	protected static final int LF= '\n';
22	protected static final int CR= '\r';	22	protected static final int CR= '\r';
23		23
Lines 62-67 Link Here
62	return -1;	62	return -1;
63	}	63	}
64		64
		65	@Override
65	public void close() throws IOException {	66	public void close() throws IOException {
66	fReader.close();	67	fReader.close();
67	}	68	}




	 */
	private int findPropertyNameStartPosition(String propertyName) {
		// Fix for http://dev.eclipse.org/bugs/show_bug.cgi?id=19319
		InputStream stream= null;
		LineReader lineReader= null;
		String encoding;
		try {
			encoding= fPropertiesFile.getCharset();
		} catch (CoreException e1) {
			encoding= "ISO-8859-1";  //$NON-NLS-1$
		}
		try (InputStream stream= createInputStream(fPropertiesFile)) {
			try (LineReader lineReader= new LineReader(stream, encoding)) {
				int start= 0;
				try {
					StringBuffer buf= new StringBuffer(80);
					int eols= lineReader.readLine(buf);
					int keyLength= propertyName.length();
					while (eols > 0) {
						String line= buf.toString();
						int i= line.indexOf(propertyName);
						int charPos= i + keyLength;
						char terminatorChar= 0;
						boolean hasNoValue= (charPos >= line.length());
						if (i > -1 && !hasNoValue)
							terminatorChar= line.charAt(charPos);
						if (line.trim().startsWith(propertyName) &&
								(hasNoValue || Character.isWhitespace(terminatorChar) || terminatorChar == '=')) {
							start += line.indexOf(propertyName);
							eols= -17; // found key
						} else {
							start += line.length() + eols;
							buf.setLength(0);
							eols= lineReader.readLine(buf);
						}
					}
					if (eols != -17)
						start= -1; //key not found in file. See bug 63794. This can happen if the key contains escaped characters.
				} catch (IOException ex) {
					JavaPlugin.log(ex);
					return -1;
				}
				return start;
			}
		} catch (CoreException cex) {
			// failed to get input stream
			JavaPlugin.log(cex);
			return -1;
		} catch (IOException e) {
			JavaPlugin.log(e);
				try {
					stream.close();
				} catch (IOException ce) {
					JavaPlugin.log(ce);
				}
			}
			return -1;
		}
		int start= 0;
		try {
			StringBuffer buf= new StringBuffer(80);
			int eols= lineReader.readLine(buf);
			int keyLength= propertyName.length();
			while (eols > 0) {
				String line= buf.toString();
				int i= line.indexOf(propertyName);
				int charPos= i + keyLength;
				char terminatorChar= 0;
				boolean hasNoValue= (charPos >= line.length());
				if (i > -1 && !hasNoValue)
					terminatorChar= line.charAt(charPos);
				if (line.trim().startsWith(propertyName) &&
						(hasNoValue || Character.isWhitespace(terminatorChar) || terminatorChar == '=')) {
					start += line.indexOf(propertyName);
					eols= -17; // found key
				} else {
					start += line.length() + eols;
					buf.setLength(0);
					eols= lineReader.readLine(buf);
				}
			}
			if (eols != -17)
				start= -1; //key not found in file. See bug 63794. This can happen if the key contains escaped characters.
		} catch (IOException ex) {
			JavaPlugin.log(ex);
			return -1;
		} finally {
			try {
				lineReader.close();
			} catch (IOException ex) {
				JavaPlugin.log(ex);
			}
		}
		return start;
	}

	private void loadProperties() {
		Set<Object> duplicateKeys= new HashSet<>();
		fProperties= new Properties(duplicateKeys);
		try (InputStream stream= new BufferedInputStream(createInputStream(fPropertiesFile))) {
			fProperties.load(stream);
			stream= new BufferedInputStream(createInputStream(fPropertiesFile));
		} catch (CoreException ex) {
			fProperties= new Properties();
			return;
		}
		try {
			fProperties.load(stream);
		} catch (IOException ex) {
			fProperties= new Properties();
			return;
		} finally {
			try {
				stream.close();
			} catch (IOException ex) {
			}
			reportDuplicateKeys(duplicateKeys);
		}
	}




		 *  (String) source of the element
		 */

		try (ByteArrayOutputStream out = new ByteArrayOutputStream();
			DataOutputStream dataOut = new DataOutputStream(out)) {
			DataOutputStream dataOut = new DataOutputStream(out);

			dataOut.writeInt(sources.length);

			for (int i = 0; i < sources.length; i++) {
				writeJavaElement(dataOut, sources[i]);
			}

			dataOut.close();
			out.close();

			super.javaToNative(out.toByteArray(), transferData);
		} catch (IOException e) {
			//it's best to send nothing if there were problems

		byte[] bytes = (byte[]) super.nativeToJava(transferData);
		if (bytes == null)
			return null;
		try (DataInputStream in = new DataInputStream(new ByteArrayInputStream(bytes))) {
		try {
			int count = in.readInt();
			TypedSource[] results = new TypedSource[count];
			for (int i = 0; i < count; i++) {
				results[i] = readJavaElement(in);
				Assert.isNotNull(results[i]);
			}
			in.close();
			return results;
		} catch (IOException e) {
			return null;





import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Status;
import org.eclipse.core.runtime.preferences.IEclipsePreferences;
import org.eclipse.core.runtime.preferences.InstanceScope;


        }

		public String encodeSettings(Map<String, String> settings) throws CoreException {
			try (ByteArrayOutputStream stream= new ByteArrayOutputStream(2000)) {
			try {
				CleanUpProfileVersioner versioner= new CleanUpProfileVersioner();
				CustomProfile profile= new ProfileManager.CustomProfile("custom", settings, versioner.getCurrentVersion(), versioner.getProfileKind()); //$NON-NLS-1$
				ArrayList<Profile> profiles= new ArrayList<>();

				} catch (UnsupportedEncodingException e) {
					return stream.toString();
				}
			} catch (IOException e) {
				throw new CoreException(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), e.getMessage(), e));
			}
		}


			} catch (UnsupportedEncodingException e) {
				bytes= settings.getBytes();
			}
			try (InputStream is= new ByteArrayInputStream(bytes)) {
			try {
				List<Profile> res= ProfileStore.readProfilesFromStream(new InputSource(is));
				if (res == null || res.size() == 0)
					return JavaPlugin.getDefault().getCleanUpRegistry().getDefaultOptions(CleanUpConstants.DEFAULT_CLEAN_UP_OPTIONS).getMap();

				CustomProfile profile= (CustomProfile)res.get(0);
				new CleanUpProfileVersioner().update(profile);
				return profile.getSettings();
			} catch (IOException e) {
				// ignore
				return null;
			}
		}





	 * @return the source without leading comments
	 */
	private String removeLeadingComments(String source) {
		JavaCodeReader reader= new JavaCodeReader();
		IDocument document= new Document(source);
		int i;
		try (JavaCodeReader reader= new JavaCodeReader()) {
			reader.configureForwardReader(document, 0, document.getLength(), true, false);
			int c= reader.read();
			while (c != -1 && (c == '\r' || c == '\n' || c == '\t')) {
				c= reader.read();
			}
			i= reader.getOffset();
			reader.close();
		} catch (IOException ex) {
			i= 0;
			JavaPlugin.log(ex);
			try {
				reader.close();
			} catch (IOException ex) {
				JavaPlugin.log(ex);
			}
		}

		try {




						if (uri != null) {
							final File file= new File(uri);
							if (file.exists()) {
								try (ZipFile zip= new ZipFile(file, ZipFile.OPEN_READ)) {
								try {
									zip= new ZipFile(file, ZipFile.OPEN_READ);
									ZipEntry entry= zip.getEntry(JarPackagerUtil.getRefactoringsEntry());
									if (entry != null) {
										try (InputStream stream= zip.getInputStream(entry)) {
										try {
											stream= zip.getInputStream(entry);
											final RefactoringHistory existing= RefactoringCore.getHistoryService().readRefactoringHistory(stream, JavaRefactoringDescriptor.JAR_MIGRATION | JavaRefactoringDescriptor.JAR_REFACTORING);
											if (existing != null)
												fHistoryDelta= incoming.removeAll(existing).getDescriptors();
										} finally {
											if (stream != null) {
												try {
													stream.close();
												} catch (IOException exception) {
													// Do nothing
												}
											}
										}
									}
								} catch (IOException exception) {
									// ignore
										zip.close();
									} catch(IOException e){
									}
								}
							}
						}




					setPageComplete(false);
					return;
				}
				try (ZipFile zip= new ZipFile(file, ZipFile.OPEN_READ)) {
				try {
					try {
						zip= new ZipFile(file, ZipFile.OPEN_READ);
					} catch (IOException exception) {
						setErrorMessage(JarImportMessages.JarImportWizardPage_invalid_location);
						setPageComplete(false);
						return;
					}
					final JarImportData data= fWizard.getImportData();
					data.setRefactoringFileLocation(URIUtil.toURI(path));
					ZipEntry entry= zip.getEntry(JarPackagerUtil.getRefactoringsEntry());

						setPageComplete(true);
						return;
					}
					try (InputStream stream= zip.getInputStream(entry)) {
					try {
						stream= zip.getInputStream(entry);
						data.setRefactoringHistory(RefactoringCore.getHistoryService().readRefactoringHistory(stream, JavaRefactoringDescriptor.JAR_MIGRATION | JavaRefactoringDescriptor.JAR_REFACTORING));
					} catch (IOException exception) {
						setErrorMessage(JarImportMessages.JarImportWizardPage_no_refactorings);

						setErrorMessage(JarImportMessages.JarImportWizardPage_no_refactorings);
						setPageComplete(false);
						return;
					} finally {
						if (stream != null) {
							try {
								stream.close();
							} catch (IOException exception) {
								// Do nothing
							}
						}
					}
				} catch (IOException exception) {
					setErrorMessage(JarImportMessages.JarImportWizardPage_invalid_location);
					setPageComplete(false);
					return;
						} catch (IOException e) {
						}
					}
				}
			}
		}

				if (uri != null) {
					final File file= new File(uri);
					if (file.exists()) {
						try (ZipFile zip= new ZipFile(file, ZipFile.OPEN_READ)) {
						try {
							zip= new ZipFile(file, ZipFile.OPEN_READ);
							ZipEntry entry= zip.getEntry(JarPackagerUtil.getRefactoringsEntry());
							if (entry != null) {
								fWizard.getImportData().setExistingTimeStamp(entry.getTime());
							}
						} catch (IOException exception) {
							// Just leave it
						} finally {
							if (zip != null) {
								try {
									zip.close();
								} catch (IOException e) {
								}
							}
						}
					}
				}




					if (element instanceof IPackageFragmentRoot) {
						IPackageFragmentRoot root= (IPackageFragmentRoot) element;
						if (root.isArchive()) {
							try (ZipFile file = JarPackagerUtil.getArchiveFile(root.getPath())) {
							try {
								file= JarPackagerUtil.getArchiveFile(root.getPath());
								if (file != null)
									count+= file.size();
							} catch (CoreException e) {
								JavaPlugin.log(e);
							} catch (IOException e) {
								addWarning(Messages.format(JarPackagerMessages.JarFileExportOperation_CloseZipFileError_message, new Object[] { JavaElementLabels.getElementLabel(root, JavaElementLabels.ALL_DEFAULT), e.getLocalizedMessage() }), e);
									if (file != null) {
										file.close();
									}
								} catch (IOException e) {
									addWarning(Messages.format(JarPackagerMessages.JarFileExportOperation_CloseZipFileError_message, new Object[] { JavaElementLabels.getElementLabel(root, JavaElementLabels.ALL_DEFAULT), e.getLocalizedMessage() }), e);
								}
							}
						} else if (root.isExternal()) {
							try {

	private void exportJavaElement(IProgressMonitor progressMonitor, IJavaElement je) throws InterruptedException {
		if (je.getElementType() == IJavaElement.PACKAGE_FRAGMENT_ROOT && ((IPackageFragmentRoot) je).isArchive()) {
			IPackageFragmentRoot root= (IPackageFragmentRoot) je;
			try (ZipFile jarFile= JarPackagerUtil.getArchiveFile(root.getPath())) {
			try {
				jarFile= JarPackagerUtil.getArchiveFile(root.getPath());
				fJarBuilder.writeArchive(jarFile, progressMonitor);
			} catch (CoreException e) {
				addWarning(Messages.format(JarPackagerMessages.JarFileExportOperation_OpenZipFileError_message, new Object[] { JavaElementLabels.getElementLabel(root, JavaElementLabels.ALL_DEFAULT), e.getLocalizedMessage() }), e);
			} catch (IOException e) {
				addWarning(Messages.format(JarPackagerMessages.JarFileExportOperation_CloseZipFileError_message, new Object[] { JavaElementLabels.getElementLabel(root, JavaElementLabels.ALL_DEFAULT), e.getLocalizedMessage() }), e);
					if (jarFile != null) {
						jarFile.close();
					}
				} catch (IOException e) {
					addWarning(Messages.format(JarPackagerMessages.JarFileExportOperation_CloseZipFileError_message, new Object[] { JavaElementLabels.getElementLabel(root, JavaElementLabels.ALL_DEFAULT), e.getLocalizedMessage() }), e);
				}
			}
			return;
		} else if (je.getElementType() == IJavaElement.PACKAGE_FRAGMENT_ROOT && ((IPackageFragmentRoot) je).isExternal()) {

				IFile classFile= (IFile)members[i];
				URI location= classFile.getLocationURI();
				if (location != null) {
					try (InputStream contents= EFS.getStore(location).openInputStream(EFS.NONE, monitor)) {
					try {
						contents= EFS.getStore(location).openInputStream(EFS.NONE, monitor);
						cfReader= ToolFactory.createDefaultClassFileReader(contents, IClassFileReader.CLASSFILE_ATTRIBUTES);
					} catch (IOException e) {
						throw new CoreException(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), IStatus.ERROR,
							Messages.format(JarPackagerMessages.JarFileExportOperation_errorCannotCloseConnection, BasicElementLabels.getURLPart(Resources.getLocationString(classFile))),
							e));
						} catch (IOException e) {
							throw new CoreException(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), IStatus.ERROR,
								Messages.format(JarPackagerMessages.JarFileExportOperation_errorCannotCloseConnection, BasicElementLabels.getURLPart(Resources.getLocationString(classFile))),
								e));
						}
					}
					if (cfReader != null) {
						ISourceAttribute sourceAttribute= cfReader.getSourceFileAttribute();




	private Manifest createSuppliedManifest(JarPackageData jarPackage) throws CoreException, IOException {
		Manifest manifest;
		// No need to use buffer here because Manifest(...) does
		try (InputStream stream= jarPackage.getManifestFile().getContents(false)) {
		try {
			manifest= new Manifest(stream);
		} finally {
			if (stream != null)
				stream.close();
		}
		return manifest;
	}




						while (entries.hasMoreElements()) {
							ZipEntry entry= entries.nextElement();
							if (entry.getName().equalsIgnoreCase("META-INF/MANIFEST.MF")) { //$NON-NLS-1$
								try (InputStream inputStream= zip.getInputStream(entry)) {
								try {
									inputStream= zip.getInputStream(entry);
									Manifest otherManifest= new Manifest(inputStream);
									otherManifests.add(otherManifest);
								} catch (IOException e) {
									JavaPlugin.log(e);
								} finally {
									if (inputStream != null) {
										try {
											inputStream.close();
										} catch(IOException e){
										}
									}
								}
							}
						}

				result= merge(ownManifest, otherManifests);
			} finally {
				for (Iterator<ZipFile> iter= openZips.iterator(); iter.hasNext(); ) {
					try (ZipFile file = iter.next()) {
						// nothing to do
						file.close();
					} catch (IOException e) {
						JavaPlugin.log(e);
					}

	private Manifest createSuppliedManifest(JarPackageData jarPackage) throws CoreException, IOException {
		Manifest manifest;
		// No need to use buffer here because Manifest(...) does
		try (InputStream stream= jarPackage.getManifestFile().getContents(false)) {
		try {
			manifest= new Manifest(stream);
		} finally {
			if (stream != null)
				stream.close();
		}
		return manifest;
	}




	@Override
	protected void buildANTScript(IPath antScriptLocation, String projectName, IPath absJarfile, String mainClass, SourceInfo[] sourceInfos) throws FileNotFoundException, IOException {
		File antScriptFile= antScriptLocation.toFile();
		try (OutputStream output = new FileOutputStream(antScriptFile)) {
			buildANTScript(output, projectName, absJarfile, mainClass, sourceInfos);
		}
		copyJarInJarLoader(new File(antScriptFile.getParentFile(), FatJarRsrcUrlBuilder.JAR_RSRC_LOADER_ZIP));
	}

	private void copyJarInJarLoader(File targetFile) throws IOException {
		try (InputStream is= JavaPlugin.getDefault().getBundle().getEntry(FatJarRsrcUrlBuilder.JAR_RSRC_LOADER_ZIP).openStream();
				OutputStream os= new FileOutputStream(targetFile)) {
			byte[] buf= new byte[1024];
			while (true) {
				int cnt= is.read(buf);
				if (cnt <= 0)
					break;
				os.write(buf, 0, cnt);
			}
		}
		os.close();
		is.close();
	}

	protected void buildANTScript(OutputStream outputStream, String projectName, IPath absJarfile, String mainClass, SourceInfo[] sourceInfos) throws IOException {





	@Override
	protected void buildANTScript(IPath antScriptLocation, String projectName, IPath absJarfile, String mainClass, SourceInfo[] sourceInfos) throws IOException {
		try (OutputStream outputStream= new FileOutputStream(antScriptLocation.toFile())) {
		try {
			outputStream= new FileOutputStream(antScriptLocation.toFile());
			String absJarname= absJarfile.toString();

			DocumentBuilder docBuilder= null;

				transformer.transform(source, result);
			} catch (TransformerException e) {
				throw new IOException(FatJarPackagerMessages.FatJarPackageAntScript_error_couldNotTransformToXML);
			}
		} finally {
			if (outputStream != null) {
				outputStream.close();
			}
		}
	}





	@Override
	protected void buildANTScript(IPath antScriptLocation, String projectName, IPath absJarfile, String mainClass, SourceInfo[] sourceInfos) throws IOException {
		try (OutputStream outputStream= new FileOutputStream(antScriptLocation.toFile())) {
		try {
			outputStream= new FileOutputStream(antScriptLocation.toFile());
			String absJarname= absJarfile.toString();
			String subfolder= absJarfile.removeFileExtension().lastSegment() + "_lib"; //$NON-NLS-1$
			String absSubfolder= absJarfile.removeLastSegments(1).append(subfolder).toString();

				transformer.transform(source, result);
			} catch (TransformerException e) {
				throw new IOException(FatJarPackagerMessages.FatJarPackageAntScript_error_couldNotTransformToXML);
			}
		} finally {
			if (outputStream != null) {
				outputStream.close();
			}
		}
	}




	}

	private void copyFile(File src, File dest) {
		try (InputStream in= new FileInputStream(src);
				OutputStream out= new FileOutputStream(dest)) {
		try {
			in= new FileInputStream(src);
			out= new FileOutputStream(dest);
			byte[] buf= new byte[4096];
			int cnt= in.read(buf);
			while (cnt > 0) {

			throw new RuntimeException(e);
		} catch (IOException e) {
			throw new RuntimeException(e);
		} finally {
			try {
				out.close();
			} catch (IOException ignore) {
			}
			try {
				in.close();
			} catch (IOException ignore) {
			}
		}
	}
	






	public File writeXML(Element javadocElement) throws CoreException {
		FileOutputStream objectStreamOutput= null;
		//@change
		//for now only writing ant files for single project selection
		try {


			file.getParentFile().mkdirs();

			try (FileOutputStream objectStreamOutput= new FileOutputStream(file)) {
				JavadocWriter.writeDocument(javadocElement, encoding, objectStreamOutput);
			}
			return file;
		} catch (IOException e) {
			String message= JavadocExportMessages.JavadocOptionsManager_createXM_error;

		} catch (TransformerException e) {
			String message= JavadocExportMessages.JavadocOptionsManager_createXM_error;
			throw new CoreException(JavaUIStatus.createError(IStatus.ERROR, message, e));
		} finally {
			if (objectStreamOutput != null) {
				try {
					objectStreamOutput.close();
				} catch (IOException e) {
				}
			}
		}
	}





			File file= File.createTempFile("javadoc-arguments", ".tmp");  //$NON-NLS-1$//$NON-NLS-2$
			vmArgs.add('@' + file.getAbsolutePath());

			try (BufferedWriter writer= new BufferedWriter(new OutputStreamWriter(new FileOutputStream(file), getEncoding(vmArgs)))) {
			try {
				for (int i= 0; i < progArgs.size(); i++) {
					String curr= progArgs.get(i);
					curr= checkForSpaces(curr);

					writer.write(curr);
					writer.write(' ');
				}
			} finally {
				writer.close();
			}
			String[] args= vmArgs.toArray(new String[vmArgs.size()]);
			process= Runtime.getRuntime().exec(args);




		}

		public ClipboardData(byte[] bytes) throws IOException {
			try (DataInputStream dataIn = new DataInputStream(new ByteArrayInputStream(bytes))) {
			try {
				fOriginHandle= dataIn.readUTF();
				fTypeImports= readArray(dataIn);
				fStaticImports= readArray(dataIn);
			} finally {
				dataIn.close();
			}
		}


		}

		public byte[] serialize() throws IOException {
			try (ByteArrayOutputStream out = new ByteArrayOutputStream(); DataOutputStream dataOut = new DataOutputStream(out)) {
			DataOutputStream dataOut = new DataOutputStream(out);
			try {
				dataOut.writeUTF(fOriginHandle);
				writeArray(dataOut, fTypeImports);
				writeArray(dataOut, fStaticImports);
				return out.toByteArray();
				dataOut.close();
				out.close();
			}

			return out.toByteArray();
		}
	}





	}

	private static IPath writeToTempFile(IClassFile classFile) {
		FileOutputStream writer= null;
		try {
			File file= File.createTempFile(classFile.getElementName(), ".class"); //$NON-NLS-1$
			byte[] bytes= classFile.getBytes();
			try (FileOutputStream writer= new FileOutputStream(file)) {
				writer.write(bytes);
				return new Path(file.toString());
			}
			JavaPlugin.log(e);
		} catch (CoreException e) {
			JavaPlugin.log(e.getStatus());
		} catch (IOException e) {
			JavaPlugin.log(e);
				try {
					writer.close();
				} catch (IOException e) {
					JavaPlugin.log(e);
				}
		}
		throw new IllegalArgumentException("Could not create temporary file."); //$NON-NLS-1$
	}




import java.io.BufferedOutputStream;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;

		if (path == null)
			return;

		TemplateReaderWriter reader= new TemplateReaderWriter();
		File file= new File(path);
		if (file.exists()) {
			try (InputStream input= new BufferedInputStream(new FileInputStream(file))) {
				TemplatePersistenceData[] datas= reader.read(input, null);
				for (int i= 0; i < datas.length; i++) {
					updateTemplate(datas[i]);
					for (int i= 0; i < datas.length; i++) {
						updateTemplate(datas[i]);
					}
				} finally {
					try {
						input.close();
					} catch (IOException x) {
					}
				}
			} catch (IOException e) {
				openReadErrorDialog(e);
			}

			fCodeTemplateTree.refresh();
			updateSourceViewerInput(fCodeTemplateTree.getSelectedElements());

		} catch (FileNotFoundException e) {
			openReadErrorDialog(e);
		} catch (IOException e) {
			openReadErrorDialog(e);
		}

		fCodeTemplateTree.refresh();
		updateSourceViewerInput(fCodeTemplateTree.getSelectedElements());
	}

	private void updateTemplate(TemplatePersistenceData data) {

		}

		if (!file.exists() || confirmOverwrite(file)) {
			try (OutputStream output= new BufferedOutputStream(new FileOutputStream(file))) {
			try {
				output= new BufferedOutputStream(new FileOutputStream(file));
				TemplateReaderWriter writer= new TemplateReaderWriter();
				writer.save(templates, output);
				output.close();
			} catch (IOException e) {
				if (output != null) {
					try {
						output.close();
					} catch (IOException e2) {
						// ignore
					}
				}
				openWriteErrorDialog();
			}
		}




			dialogSettings.put(DIALOGSETTING_LASTLOADPATH, dialog.getFilterPath());

			Properties properties= new Properties();
			try (FileInputStream fis= new FileInputStream(fileName)) {
			try {
				fis= new FileInputStream(fileName);
				properties.load(fis);
				List<ImportOrderEntry> res= loadFromProperties(properties);
				if (res != null) {

				}
			} catch (IOException e) {
				JavaPlugin.log(e);
			} finally {
				if (fis != null) {
					try { fis.close(); } catch (IOException e) {}
				}
			}
			String title= PreferencesMessages.ImportOrganizeConfigurationBlock_loadDialog_error_title;
			String message= PreferencesMessages.ImportOrganizeConfigurationBlock_loadDialog_error_message;

				ImportOrderEntry entry= elements.get(i);
				properties.setProperty(String.valueOf(i), entry.serialize());
			}
			try (FileOutputStream fos= new FileOutputStream(fileName)) {
			try {
				fos= new FileOutputStream(fileName);
				properties.store(fos, "Organize Import Order"); //$NON-NLS-1$
			} catch (IOException e) {
				JavaPlugin.log(e);
				String title= PreferencesMessages.ImportOrganizeConfigurationBlock_saveDialog_error_title;
				String message= PreferencesMessages.ImportOrganizeConfigurationBlock_saveDialog_error_message;
				MessageDialog.openError(getShell(), title, message);
			} finally {
				if (fos != null) {
					try { fos.close(); } catch (IOException e) {}
				}
			}
		}
	}

Lines 66-72 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavaBasePreferencePage.java (-1 / +1 lines)
66	private ArrayList<Button> fCheckBoxes;	66	private ArrayList<Button> fCheckBoxes;
67	private ArrayList<Button> fRadioButtons;	67	private ArrayList<Button> fRadioButtons;
68	private ArrayList<Text> fTextControls;	68	private ArrayList<Text> fTextControls;
69	private static final String PREFERENCE_STORE_KEY = "preferenceStore";	69	private static final String PREFERENCE_STORE_KEY = "preferenceStore"; //$NON-NLS-1$
70		70
71	private IPreferenceStore fJavaCorePreferences;	71	private IPreferenceStore fJavaCorePreferences;
72		72




				connection.connect();
				res= ((HttpURLConnection) connection).getResponseCode();
			}
			try (InputStream is= connection.getInputStream()) {
			try {
				is= connection.getInputStream();
				byte[] buffer= new byte[256];
				while (is.read(buffer) != -1) {
					// just read
				}
			} finally {
				if (is != null)
					is.close();
			}
		} catch (IllegalArgumentException e) {
			return false; // workaround for bug 91072

	}

	private String internalChooseArchivePath() {
		@SuppressWarnings("resource")
		ZipFile zipFile= null;
		try {
			if (fWorkspaceRadio.isSelected()) {




		}

		protected static void saveLibraries(List<CPUserLibraryElement> libraries, File file, String encoding, IProgressMonitor monitor) throws IOException {
			try (OutputStream stream= new FileOutputStream(file)) {
			try {
				DocumentBuilder docBuilder= null;
				DocumentBuilderFactory factory= DocumentBuilderFactory.newInstance();
				factory.setValidating(false);

			} catch (TransformerException e) {
				throw new IOException(e.getMessage());
			} finally {
				try {
					stream.close();
				} catch (IOException e) {
					// ignore
				}
				if (monitor != null) {
					monitor.done();
				}

		}

		private static List<CPUserLibraryElement> loadLibraries(File file) throws IOException {
			InputStream stream= new FileInputStream(file);
			Element cpElement;
			try (InputStream stream= new FileInputStream(file)) {
				DocumentBuilder parser = DocumentBuilderFactory.newInstance().newDocumentBuilder();
				parser.setErrorHandler(new DefaultHandler());
				cpElement = parser.parse(new InputSource(stream)).getDocumentElement();

				throw new IOException(PreferencesMessages.UserLibraryPreferencePage_LoadSaveDialog_load_badformat);
			} catch (ParserConfigurationException e) {
				throw new IOException(PreferencesMessages.UserLibraryPreferencePage_LoadSaveDialog_load_badformat);
			} finally {
				stream.close();
			}

			if (!cpElement.getNodeName().equalsIgnoreCase(TAG_ROOT)) {





		try {
			// note that it's wrong to use a file reader when XML declares UTF-8: Kept for compatibility
			try (final FileReader reader= new FileReader(file)) {
			try {
				List<Profile> res= readProfilesFromStream(new InputSource(reader));
				if (res != null) {
					for (int i= 0; i < res.size(); i++) {

				}
				file.delete(); // remove after successful write
				return res;
			} finally {
				reader.close();
			}
		} catch (CoreException e) {
			JavaPlugin.log(e); // log but ignore




	}

	public void writeProfiles(Collection<Profile> profiles, IScopeContext instanceScope) throws CoreException {
		try (ByteArrayOutputStream stream= new ByteArrayOutputStream(2000)) {
		try {
			writeProfilesToStream(profiles, stream, ENCODING, fProfileVersioner);
			String val;
			try {

			IEclipsePreferences uiPreferences = instanceScope.getNode(JavaUI.ID_PLUGIN);
			uiPreferences.put(fProfilesKey, val);
			uiPreferences.putInt(fProfilesVersionKey, fProfileVersioner.getCurrentVersion());
		} catch (IOException e) {
			// ignore
		}
	}


			} catch (UnsupportedEncodingException e) {
				bytes= profiles.getBytes();
			}
			try (InputStream is= new ByteArrayInputStream(bytes)) {
			try {
				List<Profile> res= readProfilesFromStream(new InputSource(is));
				if (res != null) {
					for (int i= 0; i < res.size(); i++) {

					}
				}
				return res;
			} catch (IOException e) {
				// ignore
			}
		}
		return null;

	 * @throws CoreException
	 */
	public List<Profile> readProfilesFromFile(File file) throws CoreException {
		try (final FileInputStream reader= new FileInputStream(file)) {
			return readProfilesFromStream(new InputSource(reader));
			try {
				return readProfilesFromStream(new InputSource(reader));
			} finally {
				try { reader.close(); } catch (IOException e) { /* ignore */ }
			}
		} catch (IOException e) {
			throw createException(e, FormatterMessages.CodingStyleConfigurationBlock_error_reading_xml_message);
		}

	 * @throws CoreException
	 */
	public void writeProfilesToFile(Collection<Profile> profiles, File file, String encoding) throws CoreException {
		try (final OutputStream stream= new FileOutputStream(file)) {
			writeProfilesToStream(profiles, stream, encoding, fProfileVersioner);
			stream= new FileOutputStream(file);
			try {
				writeProfilesToStream(profiles, stream, encoding, fProfileVersioner);
			} finally {
				try { stream.close(); } catch (IOException e) { /* ignore */ }
			}
		} catch (IOException e) {
			throw createException(e, FormatterMessages.CodingStyleConfigurationBlock_error_serializing_xml_message);
		}




			if (classfileResource == null)
				return null;

			try (InputStream contents= classfileResource.getContents()) {
			try {
				IClassFileReader cfReader= ToolFactory.createDefaultClassFileReader(contents, IClassFileReader.ALL);
				if (cfReader != null) {
					return calculateSerialVersionId(cfReader);
				}
			} finally {
				contents.close();
			}
			return null;
		} finally {




	}

	private String removeLeadingComments(String source) {
		final JavaCodeReader reader= new JavaCodeReader();
		IDocument document= new Document(source);
		int i;
		try (final JavaCodeReader reader= new JavaCodeReader()) {
			reader.configureForwardReader(document, 0, document.getLength(), true, false);
			int c= reader.read();
			while (c != -1 && (c == '\r' || c == '\n')) {
				c= reader.read();
			}
			i= reader.getOffset();
			reader.close();
		} catch (IOException ex) {
			i= 0;
			JavaPlugin.log(ex);
			try {
				reader.close();
			} catch (IOException ex) {
				JavaPlugin.log(ex);
			}
		}

		if (i < 0)




		Javadoc javadoc= getJavadocNode(member, rawJavadoc);

		if (javadoc == null) {
			try (Reader contentReader = JavadocContentAccess.getHTMLContentReader(member, false, false)) {
			// fall back to JavadocContentAccess:
			try {
				contentReader= JavadocContentAccess.getHTMLContentReader(member, false, false);
				if (contentReader != null)
					return getString(contentReader);
			} catch (JavaModelException e) {
				JavaPlugin.log(e);
			} catch (IOException e) {
				//ignore
					try {
						contentReader.close();
					} catch (IOException e) {
						//ignore
					}
				}
			}
			return null;
		}

	}

	private static String getHTMLContent(IJarEntryResource jarEntryResource, String encoding) throws CoreException {
		try (InputStream in = jarEntryResource.getContents()) {
		try {
			return getContentsFromInputStream(in, encoding);
		} catch (IOException e) {
			// ignore
			return null;
		} 
				} catch (IOException e) {
					//ignore
				}
			}
		}
	}

	private static String getHTMLContentFromAttachedSource(IPackageFragmentRoot root, IPackageFragment packageFragment) throws CoreException {

				} else {
					packagedocPath= filePath;
				}
				try (ZipFile zipFile= new ZipFile(file, ZipFile.OPEN_READ)) {
				InputStream in= null;
				try {
					zipFile= new ZipFile(file, ZipFile.OPEN_READ);
					ZipEntry packagedocFile= zipFile.getEntry(packagedocPath);
					if (packagedocFile != null) {
						try (InputStream in= zipFile.getInputStream(packagedocFile)) {
							if (encoding == null)
								encoding= getSourceAttachmentEncoding(root);
							return getContentsFromInputStream(in, encoding);
						}
					}
				} catch (IOException e) {
					throw new CoreException(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), e.getMessage(), e));
				} finally {
					try {
						if (in != null) {
							in.close();
						}
					} catch (IOException e) {
						//ignore
					}
					try {
						if (zipFile != null) {
							zipFile.close();//this will close the InputStream also
						}
					} catch (IOException e) {
						//ignore
					}
				}
			}
		}




					return;

				final URL url= new URL("file", null, filePath); //$NON-NLS-1$
				try (InputStream stream= url.openStream()) {
					fUserDictionary= new PersistentSpellDictionary(url);
					fChecker.addDictionary(fUserDictionary);
						fUserDictionary= new PersistentSpellDictionary(url);
						fChecker.addDictionary(fUserDictionary);
					} finally {
						stream.close();
					}
				}
			} catch (MalformedURLException exception) {
				// Do nothing




			 return fLoaded;

		if (url != null) {
			InputStream stream= null;
			int line= 0;
			try (InputStream stream= url.openStream()) {
				stream= url.openStream();
				if (stream != null) {
					String word= null;


					CharsetDecoder decoder= Charset.forName(getEncoding()).newDecoder();
					decoder.onMalformedInput(CodingErrorAction.REPORT);
					decoder.onUnmappableCharacter(CodingErrorAction.REPORT);
					try (final BufferedReader reader= new BufferedReader(new InputStreamReader(stream, decoder))) {
	
						boolean doRead= true;
						while (doRead) {
							try {
								word= reader.readLine();
							} catch (MalformedInputException ex) {
								// Tell the decoder to replace malformed input in order to read the line.
								decoder.onMalformedInput(CodingErrorAction.REPLACE);
								decoder.reset();
								word= reader.readLine();
								decoder.onMalformedInput(CodingErrorAction.REPORT);
	
								String message= Messages.format(JavaUIMessages.AbstractSpellingDictionary_encodingError, new String[] { word, decoder.replacement(), BasicElementLabels.getURLPart(url.toString()) });
								IStatus status= new Status(IStatus.ERROR, JavaUI.ID_PLUGIN, IStatus.OK, message, ex);
								JavaPlugin.log(status);
	
								doRead= word != null;
								continue;
							}
							doRead= word != null;
							if (doRead)
								hashWord(word);
						}
						return true;
						if (doRead)
							hashWord(word);
					}
					return true;
				}
			} catch (FileNotFoundException ex) {
				String urlString= url.toString();

					JavaPlugin.log(exception);
			} finally {
				fMustLoad= false;
				try {
					if (stream != null)
						stream.close();
				} catch (IOException x) {
				}
			}
		}
		return false;




		if (isCorrect(word))
			return;

		Charset charset= Charset.forName(getEncoding());
		ByteBuffer byteBuffer= charset.encode(word + "\n"); //$NON-NLS-1$
		int size= byteBuffer.limit();
		final byte[] byteArray;
		if (byteBuffer.hasArray())
			byteArray= byteBuffer.array();
		else {
			byteArray= new byte[size];
			byteBuffer.get(byteArray);
		}
		try (FileOutputStream fileStream= new FileOutputStream(fLocation.getPath(), true)) {
			}

			fileStream= new FileOutputStream(fLocation.getPath(), true);

			// Encoding UTF-16 charset writes a BOM. In which case we need to cut it away if the file isn't empty
			int bomCutSize= 0;
			if (!isEmpty() && "UTF-16".equals(charset.name())) //$NON-NLS-1$

		} catch (IOException exception) {
			JavaPlugin.log(exception);
			return;
		} finally {
			try {
				if (fileStream != null)
					fileStream.close();
			} catch (IOException e) {
			}
		}

		hashWord(word);




		for (Iterator<IResource> iter= fClassFiles.iterator(); iter.hasNext();) {
			IFile file= (IFile) iter.next();
			IClassFileReader reader= null;
			try (InputStream content= file.getContents()) {
			try {
				content= file.getContents();
				reader= ToolFactory.createDefaultClassFileReader(content, IClassFileReader.CLASSFILE_ATTRIBUTES);
			} catch (IOException e) {
				throw new CoreException(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), IStatus.ERROR,
					Messages.format(NewWizardMessages.ClassPathDetector_error_closing_file, BasicElementLabels.getPathLabel(file.getFullPath(), false)),
					e));
				} catch (IOException e) {
					throw new CoreException(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), IStatus.ERROR,
						Messages.format(NewWizardMessages.ClassPathDetector_error_closing_file, BasicElementLabels.getPathLabel(file.getFullPath(), false)),
						e));
				}
			}
			if (reader == null) {
				continue; // problematic class file

Lines 164-169 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/JavadocContentAccess.java (+1 lines)
164	return getHTMLContentReader(member, allowInherited, false);	164	return getHTMLContentReader(member, allowInherited, false);
165	}	165	}
166		166
		167	@SuppressWarnings("resource")
167	private static Reader findDocInHierarchy(IMethod method, boolean isHTML, boolean useAttachedJavadoc) throws JavaModelException {	168	private static Reader findDocInHierarchy(IMethod method, boolean isHTML, boolean useAttachedJavadoc) throws JavaModelException {
168	/*	169	/*
169	* Catch ExternalJavaProject in which case	170	* Catch ExternalJavaProject in which case




	 */
	public void write(IFile resource, IPath destinationPath) throws CoreException {
		ByteArrayOutputStream output= new ByteArrayOutputStream();
		try (BufferedInputStream contentStream= new BufferedInputStream(resource.getContents(false))) {
		try {
			contentStream= new BufferedInputStream(resource.getContents(false));
			int chunkSize= 4096;
			byte[] readBuffer= new byte[chunkSize];
			int count;

				output.write(readBuffer, 0, count);
		} catch (IOException ex) {
			throw JarPackagerUtil.createCoreException(ex.getLocalizedMessage(), ex);
		} finally {
			try {
				if (contentStream != null)
					contentStream.close();
			} catch (IOException ex) {
				throw JarPackagerUtil.createCoreException(ex.getLocalizedMessage(), ex);
			}
		}
		try {
			IPath fileLocation= resource.getLocation();




		// Set modification time
		newEntry.setTime(lastModified);

		try (InputStream contentStream = resource.getContents(false)) {

		try {
			fJarOutputStream.putNextEntry(newEntry);
			int count;
			while ((count= contentStream.read(readBuffer, 0, readBuffer.length)) != -1)
				fJarOutputStream.write(readBuffer, 0, count);
		} finally  {
			if (contentStream != null)
				contentStream.close();

			/*
			 * Commented out because some JREs throw an NPE if a stream
			 * is closed twice. This works because
			 * a) putNextEntry closes the previous entry
			 * b) closing the stream closes the last entry
			 */
			// fJarOutputStream.closeEntry();
		}
	}


	 * @throws	CoreException 	if the resource can-t be accessed
	 */
	private void calculateCrcAndSize(JarEntry jarEntry, IFile resource, byte[] readBuffer) throws IOException, CoreException {
		InputStream contentStream = resource.getContents(false);
		int size = 0;
		CRC32 checksumCalculator= new CRC32();
		int count;
		try (InputStream contentStream = resource.getContents(false)) {
			while ((count= contentStream.read(readBuffer, 0, readBuffer.length)) != -1) {
				checksumCalculator.update(readBuffer, 0, count);
				size += count;
			}
		} finally {
			if (contentStream != null)
				contentStream.close();
		}
		jarEntry.setSize(size);
		jarEntry.setCrc(checksumCalculator.getValue());




			}
		});
		File file= null;
		OutputStream output= null;
		try {
			file= File.createTempFile("history", null); //$NON-NLS-1$
			try (OutputStream output= new BufferedOutputStream(new FileOutputStream(file))) {
			try {
				RefactoringCore.getHistoryService().writeRefactoringDescriptors(proxies, output, RefactoringDescriptor.NONE, false, monitor);
				try {
					output.close();
					output= null;
				} catch (IOException exception) {
					// Do nothing
				}
				writeMetaData(data, file, path);
			} finally {
				if (output != null) {
					try {
						output.close();
					} catch (IOException exception) {
						// Do nothing
					}
				}
			}
			writeMetaData(data, file, path);
		} finally {
			if (file != null)
				file.delete();

			JarPackagerUtil.calculateCrcAndSize(entry, new BufferedInputStream(new FileInputStream(file)), buffer);
		}
		entry.setTime(System.currentTimeMillis());
		try (final InputStream stream= new BufferedInputStream(new FileInputStream(file))) {
		try {
			fJarOutputStream.putNextEntry(entry);
			int count;
			while ((count= stream.read(buffer, 0, buffer.length)) != -1)
				fJarOutputStream.write(buffer, 0, count);
		} finally {
			try {
				stream.close();
			} catch (IOException exception) {
				// Do nothing
			}
		}
	}
}

Return to bug 509247

Lines 127-140 Link Here

(-)a/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/contentassist/CodeCompletionTest.java (-3 / +1 lines)
127		127
128	System.out.print("file contents: \|");	128	System.out.print("file contents: \|");
129	File file= cu.getResource().getLocation().toFile();	129	File file= cu.getResource().getLocation().toFile();
130	try {	130	try (BufferedReader reader= new BufferedReader(new FileReader(file))) {
131	BufferedReader reader= new BufferedReader(new FileReader(file));
132	String line;	131	String line;
133	while ((line= reader.readLine()) != null) {	132	while ((line= reader.readLine()) != null) {
134	System.out.println(line);	133	System.out.println(line);
135	}	134	}
136	System.out.println("\|");	135	System.out.println("\|");
137	reader.close();
138	} catch (FileNotFoundException e1) {	136	} catch (FileNotFoundException e1) {
139	e1.printStackTrace();	137	e1.printStackTrace();
140	} catch (IOException e1) {	138	} catch (IOException e1) {

Lines 472-486 Link Here

(-)a/org.eclipse.jdt.ui.tests.refactoring/test cases/org/eclipse/jdt/ui/tests/refactoring/RefactoringTest.java (-5 / +1 lines)
472	}	472	}
473		473
474	public static String getContents(InputStream in) throws IOException {	474	public static String getContents(InputStream in) throws IOException {
475	BufferedReader br= new BufferedReader(new InputStreamReader(in));
476
477	StringBuffer sb= new StringBuffer(300);	475	StringBuffer sb= new StringBuffer(300);
478	try {	476	try (BufferedReader br= new BufferedReader(new InputStreamReader(in))) {
479	int read= 0;	477	int read= 0;
480	while ((read= br.read()) != -1)	478	while ((read= br.read()) != -1)
481	sb.append((char) read);	479	sb.append((char) read);
482	} finally {
483	br.close();
484	}	480	}
485	return sb.toString();	481	return sb.toString();
486	}	482	}

Lines 680-693 Link Here

(-)a/org.eclipse.jdt.ui.tests.refactoring/test cases/org/eclipse/jdt/ui/tests/refactoring/RenamePackageTests.java (-8 / +2 lines)
680		680
681	helper2(new String[]{"my.pack", "my"}, new String[][]{{}, {}}, "my");	681	helper2(new String[]{"my.pack", "my"}, new String[][]{{}, {}}, "my");
682		682
683	InputStreamReader reader= new InputStreamReader(textfile.getContents(true));
684	StringBuffer newContent= new StringBuffer();	683	StringBuffer newContent= new StringBuffer();
685	try {	684	try (InputStreamReader reader= new InputStreamReader(textfile.getContents(true))) {
686	int ch;	685	int ch;
687	while((ch= reader.read()) != -1)	686	while((ch= reader.read()) != -1)
688	newContent.append((char)ch);	687	newContent.append((char)ch);
689	} finally {
690	reader.close();
691	}	688	}
692	String definedContent= getFileContents(getTestPath() + getName() + TEST_OUTPUT_INFIX + "my/" + textFileName);	689	String definedContent= getFileContents(getTestPath() + getName() + TEST_OUTPUT_INFIX + "my/" + textFileName);
693	assertEqualLines("invalid updating", definedContent, newContent.toString());	690	assertEqualLines("invalid updating", definedContent, newContent.toString());
Lines 1148-1161 Link Here
1148		1145
1149	helper2(new String[]{"r.p1", "r"}, new String[][]{{"A"}, {"A"}}, "q");	1146	helper2(new String[]{"r.p1", "r"}, new String[][]{{"A"}, {"A"}}, "q");
1150		1147
1151	InputStreamReader reader= new InputStreamReader(textfile.getContents(true));
1152	StringBuffer newContent= new StringBuffer();	1148	StringBuffer newContent= new StringBuffer();
1153	try {	1149	try (InputStreamReader reader= new InputStreamReader(textfile.getContents(true))) {
1154	int ch;	1150	int ch;
1155	while((ch= reader.read()) != -1)	1151	while((ch= reader.read()) != -1)
1156	newContent.append((char)ch);	1152	newContent.append((char)ch);
1157	} finally {
1158	reader.close();
1159	}	1153	}
1160	String definedContent= getFileContents(getTestPath() + getName() + TEST_OUTPUT_INFIX + textFileName);	1154	String definedContent= getFileContents(getTestPath() + getName() + TEST_OUTPUT_INFIX + textFileName);
1161	assertEqualLines("invalid updating", definedContent, newContent.toString());	1155	assertEqualLines("invalid updating", definedContent, newContent.toString());

Lines 1222-1235 Link Here

(-)a/org.eclipse.jdt.ui.tests.refactoring/test cases/org/eclipse/jdt/ui/tests/refactoring/RenameTypeTests.java (-8 / +2 lines)
1222		1222
1223	ICompilationUnit newcu= getPackageP().getCompilationUnit(newName + ".java");	1223	ICompilationUnit newcu= getPackageP().getCompilationUnit(newName + ".java");
1224	assertEqualLines("invalid renaming", getFileContents(getOutputTestFileName(newName)), newcu.getSource());	1224	assertEqualLines("invalid renaming", getFileContents(getOutputTestFileName(newName)), newcu.getSource());
1225	InputStreamReader reader= new InputStreamReader(file.getContents(true));
1226	StringBuffer newContent= new StringBuffer();	1225	StringBuffer newContent= new StringBuffer();
1227	try {	1226	try (InputStreamReader reader= new InputStreamReader(file.getContents(true))) {
1228	int ch;	1227	int ch;
1229	while((ch= reader.read()) != -1)	1228	while((ch= reader.read()) != -1)
1230	newContent.append((char)ch);	1229	newContent.append((char)ch);
1231	} finally {
1232	reader.close();
1233	}	1230	}
1234	String definedContent= getFileContents(getTestPath() + getName() + TEST_OUTPUT_INFIX + textFileName);	1231	String definedContent= getFileContents(getTestPath() + getName() + TEST_OUTPUT_INFIX + textFileName);
1235	assertEqualLines("invalid updating", definedContent, newContent.toString());	1232	assertEqualLines("invalid updating", definedContent, newContent.toString());
Lines 1330-1343 Link Here
1330		1327
1331	helper3("SomeClass", "SomeDifferentClass", true, true, true, "test.html");	1328	helper3("SomeClass", "SomeDifferentClass", true, true, true, "test.html");
1332		1329
1333	InputStreamReader reader= new InputStreamReader(file.getContents(true));
1334	StringBuffer newContent= new StringBuffer();	1330	StringBuffer newContent= new StringBuffer();
1335	try {	1331	try (InputStreamReader reader= new InputStreamReader(file.getContents(true))) {
1336	int ch;	1332	int ch;
1337	while((ch= reader.read()) != -1)	1333	while((ch= reader.read()) != -1)
1338	newContent.append((char)ch);	1334	newContent.append((char)ch);
1339	} finally {
1340	reader.close();
1341	}	1335	}
1342	String definedContent= getFileContents(getTestPath() + "testSimilarElements05/out/test.html");	1336	String definedContent= getFileContents(getTestPath() + "testSimilarElements05/out/test.html");
1343	assertEqualLines("invalid updating test.html", newContent.toString(), definedContent);	1337	assertEqualLines("invalid updating test.html", newContent.toString(), definedContent);

Lines 770-793 Link Here

(-)a/org.eclipse.jdt.ui.tests.refactoring/test cases/org/eclipse/jdt/ui/tests/refactoring/nls/NlsRefactoringCreateChangeTest.java (-11 / +8 lines)
770	}	770	}
771		771
772	private void checkContentOfFile(String message, IFile file, String content) throws Exception {	772	private void checkContentOfFile(String message, IFile file, String content) throws Exception {
773	InputStream in= file.getContents();	773	try (InputStream in= file.getContents()) {
774	try {
775	String realContent= copyToString(in);	774	String realContent= copyToString(in);
776	RefactoringTest.assertEqualLines(message, content, realContent);	775	RefactoringTest.assertEqualLines(message, content, realContent);
777	} finally {
778	in.close();
779	}	776	}
780	}	777	}
781		778
782	private String copyToString(InputStream in) throws Exception {	779	private String copyToString(InputStream in) throws Exception {
783	ByteArrayOutputStream out= new ByteArrayOutputStream();	780	try (ByteArrayOutputStream out= new ByteArrayOutputStream()) {
784	int read= in.read();	781	int read= in.read();
785	while (read != -1) {	782	while (read != -1) {
786	out.write(read);	783	out.write(read);
787	read= in.read();	784	read= in.read();
		785	}
		786	return out.toString();
788	}	787	}
789	out.close();
790	return out.toString();
791	}	788	}
792		789
793	private NLSRefactoring createDefaultNls(ICompilationUnit cu) {	790	private NLSRefactoring createDefaultNls(ICompilationUnit cu) {

Lines 50-89 Link Here

(-)a/org.eclipse.jdt.text.tests/src/org/eclipse/jdt/text/tests/performance/FileTool.java (-71 / +21 lines)
50		50
51	Enumeration<? extends ZipEntry> entries = zipFile.entries();	51	Enumeration<? extends ZipEntry> entries = zipFile.entries();
52		52
53	try {	53	while(entries.hasMoreElements()){
54	while(entries.hasMoreElements()){	54	ZipEntry entry = entries.nextElement();
55	ZipEntry entry = entries.nextElement();	55	if(entry.isDirectory()){
56	if(entry.isDirectory()){	56	continue;
57	continue;
58	}
59	String entryName = entry.getName();
60	File file = new File(dstDir, changeSeparator(entryName, '/', File.separatorChar));
61	file.getParentFile().mkdirs();
62	InputStream src = null;
63	OutputStream dst = null;
64	try {
65	src = zipFile.getInputStream(entry);
66	dst = new FileOutputStream(file);
67	transferData(src, dst);
68	} finally {
69	if(dst != null){
70	try {
71	dst.close();
72	} catch(IOException e){
73	}
74	}
75	if(src != null){
76	try {
77	src.close();
78	} catch(IOException e){
79	}
80	}
81	}
82	}	57	}
83	} finally {	58	String entryName = entry.getName();
84	try {	59	File file = new File(dstDir, changeSeparator(entryName, '/', File.separatorChar));
85	zipFile.close();	60	file.getParentFile().mkdirs();
86	} catch(IOException e){	61	try (InputStream src = zipFile.getInputStream(entry);
		62	OutputStream dst = new FileOutputStream(file)) {
		63	transferData(src, dst);
87	}	64	}
88	}	65	}
89	}	66	}
Lines 112-136 Link Here
112	*/	89	*/
113	public static void transferData(File source, File destination) throws IOException {	90	public static void transferData(File source, File destination) throws IOException {
114	destination.getParentFile().mkdirs();	91	destination.getParentFile().mkdirs();
115	InputStream is = null;	92	try (InputStream is = new FileInputStream(source);
116	OutputStream os = null;	93	OutputStream os = new FileOutputStream(destination)) {
117	try {
118	is = new FileInputStream(source);
119	os = new FileOutputStream(destination);
120	transferData(is, os);	94	transferData(is, os);
121	} finally {
122	if(os != null){
123	try {
124	os.close();
125	} catch(IOException e){
126	}
127	}
128	if(is != null){
129	try {
130	is.close();
131	} catch(IOException e){
132	}
133	}
134	}	95	}
135	}	96	}
136		97
Lines 182-217 Link Here
182	}	143	}
183		144
184	public static StringBuffer read(String fileName) throws IOException {	145	public static StringBuffer read(String fileName) throws IOException {
185	return read(new FileReader(fileName));	146	try (Reader reader = new FileReader(fileName)) {
		147	return read(reader);
		148	}
186	}	149	}
187		150
188	public static StringBuffer read(Reader reader) throws IOException {	151	public static StringBuffer read(Reader reader) throws IOException {
189	StringBuffer s= new StringBuffer();	152	StringBuffer s= new StringBuffer();
190	try {	153	char[] buffer= new char[8196];
191	char[] buffer= new char[8196];	154	int chars= reader.read(buffer);
192	int chars= reader.read(buffer);	155	while (chars != -1) {
193	while (chars != -1) {	156	s.append(buffer, 0, chars);
194	s.append(buffer, 0, chars);	157	chars= reader.read(buffer);
195	chars= reader.read(buffer);
196	}
197	} finally {
198	try {
199	reader.close();
200	} catch (IOException e) {
201	}
202	}	158	}
203	return s;	159	return s;
204	}	160	}
205		161
206	public static void write(String fileName, StringBuffer content) throws IOException {	162	public static void write(String fileName, StringBuffer content) throws IOException {
207	Writer writer= new FileWriter(fileName);	163	try (Writer writer= new FileWriter(fileName)) {
208	try {
209	writer.write(content.toString());	164	writer.write(content.toString());
210	} finally {
211	try {
212	writer.close();
213	} catch (IOException e) {
214	}
215	}	165	}
216	}	166	}
217	}	167	}

Lines 29-43 Link Here

(-)a/org.eclipse.jdt.ui.tests.refactoring/test cases/org/eclipse/jdt/ui/tests/refactoring/infra/AbstractCUTestCase.java (-5 / +1 lines)
29	}	29	}
30		30
31	protected String getFileContents(InputStream in) throws IOException {	31	protected String getFileContents(InputStream in) throws IOException {
32	BufferedReader br= new BufferedReader(new InputStreamReader(in));
33
34	StringBuffer sb= new StringBuffer();	32	StringBuffer sb= new StringBuffer();
35	try {	33	try (BufferedReader br= new BufferedReader(new InputStreamReader(in))) {
36	int read= 0;	34	int read= 0;
37	while ((read= br.read()) != -1)	35	while ((read= br.read()) != -1)
38	sb.append((char) read);	36	sb.append((char) read);
39	} finally {
40	br.close();
41	}	37	}
42	return sb.toString();	38	return sb.toString();
43	}	39	}

Lines 85-106 Link Here

(-)a/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/template/java/TemplateSet.java (-26 / +2 lines)
85	* @see #addFromStream(InputStream, boolean)	85	* @see #addFromStream(InputStream, boolean)
86	*/	86	*/
87	public void addFromFile(File file, boolean allowDuplicates) throws CoreException {	87	public void addFromFile(File file, boolean allowDuplicates) throws CoreException {
88	InputStream stream= null;	88	try (InputStream stream= new FileInputStream(file)) {
89
90	try {
91	stream= new FileInputStream(file);
92	addFromStream(stream, allowDuplicates);	89	addFromStream(stream, allowDuplicates);
93
94	} catch (IOException e) {	90	} catch (IOException e) {
95	throwReadException(e);	91	throwReadException(e);
96
97	} finally {
98	try {
99	if (stream != null)
100	stream.close();
101	} catch (IOException e) {
102	// just exit
103	}
104	}	92	}
105	}	93	}
106		94
Lines 205-226 Link Here
205	* @see #saveToStream(OutputStream)	193	* @see #saveToStream(OutputStream)
206	*/	194	*/
207	public void saveToFile(File file) throws CoreException {	195	public void saveToFile(File file) throws CoreException {
208	OutputStream stream= null;	196	try (OutputStream stream= new FileOutputStream(file)) {
209
210	try {
211	stream= new FileOutputStream(file);
212	saveToStream(stream);	197	saveToStream(stream);
213
214	} catch (IOException e) {	198	} catch (IOException e) {
215	throwWriteException(e);	199	throwWriteException(e);
216
217	} finally {
218	try {
219	if (stream != null)
220	stream.close();
221	} catch (IOException e) {
222	// just exit
223	}
224	}	200	}
225	}	201	}
226		202

Lines 165-185 Link Here

(-)a/org.eclipse.jdt.ui/core extension/org/eclipse/jdt/internal/corext/util/History.java (-21 / +2 lines)
165	IPath stateLocation= JavaPlugin.getDefault().getStateLocation().append(fFileName);	165	IPath stateLocation= JavaPlugin.getDefault().getStateLocation().append(fFileName);
166	File file= stateLocation.toFile();	166	File file= stateLocation.toFile();
167	if (file.exists()) {	167	if (file.exists()) {
168	InputStreamReader reader= null;	168	try (InputStreamReader reader = new InputStreamReader(new FileInputStream(file), "utf-8")) { //$NON-NLS-1$
169	try {
170	reader = new InputStreamReader(new FileInputStream(file), "utf-8");//$NON-NLS-1$
171	load(new InputSource(reader));	169	load(new InputSource(reader));
172	} catch (IOException e) {	170	} catch (IOException e) {
173	JavaPlugin.log(e);	171	JavaPlugin.log(e);
174	} catch (CoreException e) {	172	} catch (CoreException e) {
175	JavaPlugin.log(e);	173	JavaPlugin.log(e);
176	} finally {
177	try {
178	if (reader != null)
179	reader.close();
180	} catch (IOException e) {
181	JavaPlugin.log(e);
182	}
183	}	174	}
184	}	175	}
185	}	176	}
Lines 187-195 Link Here
187	public synchronized void save() {	178	public synchronized void save() {
188	IPath stateLocation= JavaPlugin.getDefault().getStateLocation().append(fFileName);	179	IPath stateLocation= JavaPlugin.getDefault().getStateLocation().append(fFileName);
189	File file= stateLocation.toFile();	180	File file= stateLocation.toFile();
190	OutputStream out= null;	181	try (OutputStream out= new FileOutputStream(file)) {
191	try {
192	out= new FileOutputStream(file);
193	save(out);	182	save(out);
194	} catch (IOException e) {	183	} catch (IOException e) {
195	JavaPlugin.log(e);	184	JavaPlugin.log(e);
Lines 199-212 Link Here
199	// The XML library can be misconficgured (e.g. via	188	// The XML library can be misconficgured (e.g. via
200	// -Djava.endorsed.dirs=C:\notExisting\xerces-2_7_1)	189	// -Djava.endorsed.dirs=C:\notExisting\xerces-2_7_1)
201	JavaPlugin.log(e);	190	JavaPlugin.log(e);
202	} finally {
203	try {
204	if (out != null) {
205	out.close();
206	}
207	} catch (IOException e) {
208	JavaPlugin.log(e);
209	}
210	}	191	}
211	}	192	}
212		193

Lines 156-179 Link Here

(-)a/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/changes/DeletePackageFragmentRootChange.java (-16 / +19 lines)
156		156
157	private static int getFileLength(IFile file) throws CoreException {	157	private static int getFileLength(IFile file) throws CoreException {
158	// Cannot use file buffers here, since they are not yet in sync at this point.	158	// Cannot use file buffers here, since they are not yet in sync at this point.
159	InputStream contents= file.getContents();	159	try (InputStream contents= file.getContents()) {
160	InputStreamReader reader;	160	@SuppressWarnings("resource")
161	try {	161	InputStreamReader reader = null;
162	reader= new InputStreamReader(contents, file.getCharset());	162	try {
163	} catch (UnsupportedEncodingException e) {	163	reader= new InputStreamReader(contents, file.getCharset());
164	JavaPlugin.log(e);	164	} catch (UnsupportedEncodingException e) {
165	reader= new InputStreamReader(contents);	165	JavaPlugin.log(e);
166	}	166	reader= new InputStreamReader(contents);
167	try {	167	}
168	return (int) reader.skip(Integer.MAX_VALUE);	168	try {
		169	return (int) reader.skip(Integer.MAX_VALUE);
		170	} finally {
		171	try {
		172	reader.close();
		173	} catch (IOException e) {
		174	// ignore
		175	}
		176	}
169	} catch (IOException e) {	177	} catch (IOException e) {
170	throw new CoreException(new Status(IStatus.ERROR, Corext.getPluginId(), e.getMessage(), e));	178	throw new CoreException(new Status(IStatus.ERROR, Corext.getPluginId(), e.getMessage(), e));
171	} finally {	179	}
172	try {
173	reader.close();
174	} catch (IOException e) {
175	}
176	}
177	}	180	}
178		181
179	private boolean confirmDeleteIfReferenced() throws JavaModelException {	182	private boolean confirmDeleteIfReferenced() throws JavaModelException {

Lines 41-60 Link Here

(-)a/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/nls/changes/CreateTextFileChange.java (-9 / +3 lines)
41	IFile file= getOldFile(new NullProgressMonitor());	41	IFile file= getOldFile(new NullProgressMonitor());
42	if (! file.exists())	42	if (! file.exists())
43	return ""; //$NON-NLS-1$	43	return ""; //$NON-NLS-1$
44	InputStream stream= null;	44	try (InputStream stream= file.getContents()) {
45	try{
46	stream= file.getContents();
47	String encoding= file.getCharset();	45	String encoding= file.getCharset();
48	String c= NLSUtil.readString(stream, encoding);	46	String c= NLSUtil.readString(stream, encoding);
49	return (c == null) ? "": c; //$NON-NLS-1$	47	return (c == null) ? "": c; //$NON-NLS-1$
50	} catch (CoreException e){	48	} catch (CoreException e){
51	throw new JavaModelException(e, IJavaModelStatusConstants.CORE_EXCEPTION);	49	throw new JavaModelException(e, IJavaModelStatusConstants.CORE_EXCEPTION);
52	} finally {	50	} catch (IOException e) {
53	try {	51	throw new JavaModelException(e, IJavaModelStatusConstants.IO_EXCEPTION);
54	if (stream != null)
55	stream.close();
56	} catch (IOException x) {
57	}
58	}	52	}
59	}	53	}
60		54

Lines 70-78 Link Here

(-)a/org.eclipse.jdt.ui/core refactoring/org/eclipse/jdt/internal/corext/refactoring/reorg/JavaElementTransfer.java (-7 / +2 lines)
70	* (String) handle identifier	70	* (String) handle identifier
71	*/	71	*/
72		72
73	try {	73	try (ByteArrayOutputStream out= new ByteArrayOutputStream();
74	ByteArrayOutputStream out= new ByteArrayOutputStream();	74	DataOutputStream dataOut= new DataOutputStream(out)) {
75	DataOutputStream dataOut= new DataOutputStream(out);
76		75
77	//write the number of elements	76	//write the number of elements
78	dataOut.writeInt(javaElements.length);	77	dataOut.writeInt(javaElements.length);
Lines 81-90 Link Here
81	for (int i= 0; i < javaElements.length; i++) {	80	for (int i= 0; i < javaElements.length; i++) {
82	writeJavaElement(dataOut, javaElements[i]);	81	writeJavaElement(dataOut, javaElements[i]);
83	}	82	}
84
85	//cleanup
86	dataOut.close();
87	out.close();
88	byte[] bytes= out.toByteArray();	83	byte[] bytes= out.toByteArray();
89	super.javaToNative(bytes, transferData);	84	super.javaToNative(bytes, transferData);
90	} catch (IOException e) {	85	} catch (IOException e) {

Lines 53-81 Link Here

(-)a/org.eclipse.jdt.ui/jar in jar loader/org/eclipse/jdt/internal/jarinjarloader/JarRsrcLoader.java (-18 / +18 lines)
53	}	53	}
54	ClassLoader jceClassLoader = new URLClassLoader(rsrcUrls, null);	54	ClassLoader jceClassLoader = new URLClassLoader(rsrcUrls, null);
55	Thread.currentThread().setContextClassLoader(jceClassLoader);	55	Thread.currentThread().setContextClassLoader(jceClassLoader);
56	Class c = Class.forName(mi.rsrcMainClass, true, jceClassLoader);	56	Class<?> c = Class.forName(mi.rsrcMainClass, true, jceClassLoader);
57	Method main = c.getMethod(JIJConstants.MAIN_METHOD_NAME, new Class[]{args.getClass()});	57	Method main = c.getMethod(JIJConstants.MAIN_METHOD_NAME, new Class[]{args.getClass()});
58	main.invoke((Object)null, new Object[]{args});	58	main.invoke((Object)null, new Object[]{args});
59	}	59	}
60		60
61	private static ManifestInfo getManifestInfo() throws IOException {	61	private static ManifestInfo getManifestInfo() throws IOException {
62	Enumeration resEnum;	62	Enumeration<URL> resEnum = Thread.currentThread().getContextClassLoader().getResources(JarFile.MANIFEST_NAME);
63	resEnum = Thread.currentThread().getContextClassLoader().getResources(JarFile.MANIFEST_NAME);
64	while (resEnum.hasMoreElements()) {	63	while (resEnum.hasMoreElements()) {
65	try {	64	try {
66	URL url = (URL)resEnum.nextElement();	65	URL url = resEnum.nextElement();
67	InputStream is = url.openStream();	66	try (InputStream is = url.openStream()) {
68	if (is != null) {	67	if (is != null) {
69	ManifestInfo result = new ManifestInfo();	68	ManifestInfo result = new ManifestInfo();
70	Manifest manifest = new Manifest(is);	69	Manifest manifest = new Manifest(is);
71	Attributes mainAttribs = manifest.getMainAttributes();	70	Attributes mainAttribs = manifest.getMainAttributes();
72	result.rsrcMainClass = mainAttribs.getValue(JIJConstants.REDIRECTED_MAIN_CLASS_MANIFEST_NAME);	71	result.rsrcMainClass = mainAttribs.getValue(JIJConstants.REDIRECTED_MAIN_CLASS_MANIFEST_NAME);
73	String rsrcCP = mainAttribs.getValue(JIJConstants.REDIRECTED_CLASS_PATH_MANIFEST_NAME);	72	String rsrcCP = mainAttribs.getValue(JIJConstants.REDIRECTED_CLASS_PATH_MANIFEST_NAME);
74	if (rsrcCP == null)	73	if (rsrcCP == null)
75	rsrcCP = JIJConstants.DEFAULT_REDIRECTED_CLASSPATH;	74	rsrcCP = JIJConstants.DEFAULT_REDIRECTED_CLASSPATH;
76	result.rsrcClassPath = splitSpaces(rsrcCP);	75	result.rsrcClassPath = splitSpaces(rsrcCP);
77	if ((result.rsrcMainClass != null) && !result.rsrcMainClass.trim().equals("")) //$NON-NLS-1$	76	if ((result.rsrcMainClass != null) && !result.rsrcMainClass.trim().equals("")) //$NON-NLS-1$
78	return result;	77	return result;
		78	}
79	}	79	}
80	}	80	}
81	catch (Exception e) {	81	catch (Exception e) {
Lines 96-102 Link Here
96	private static String[] splitSpaces(String line) {	96	private static String[] splitSpaces(String line) {
97	if (line == null)	97	if (line == null)
98	return null;	98	return null;
99	List result = new ArrayList();	99	List<String> result = new ArrayList<>();
100	int firstPos = 0;	100	int firstPos = 0;
101	while (firstPos < line.length()) {	101	while (firstPos < line.length()) {
102	int lastPos = line.indexOf(' ', firstPos);	102	int lastPos = line.indexOf(' ', firstPos);
Lines 107-113 Link Here
107	}	107	}
108	firstPos = lastPos+1;	108	firstPos = lastPos+1;
109	}	109	}
110	return (String[]) result.toArray(new String[result.size()]);	110	return result.toArray(new String[result.size()]);
111	}	111	}
112		112
113	}	113	}

Lines 34-44 Link Here

(-)a/org.eclipse.jdt.ui/jar in jar loader/org/eclipse/jdt/internal/jarinjarloader/RsrcURLStreamHandler.java (-1 / +3 lines)
34	this.classLoader = classLoader;	34	this.classLoader = classLoader;
35	}	35	}
36		36
		37	@Override
37	protected java.net.URLConnection openConnection(URL u) throws IOException {	38	protected java.net.URLConnection openConnection(URL u) throws IOException {
38	return new RsrcURLConnection(u, classLoader);	39	return new RsrcURLConnection(u, classLoader);
39	}	40	}
40		41
41	protected void parseURL(URL url, String spec, int start, int limit) {	42	@Override
		43	protected void parseURL(URL url, String spec, int start, int limit) {
42	String file;	44	String file;
43	if (spec.startsWith(JIJConstants.INTERNAL_URL_PROTOCOL_WITH_COLON))	45	if (spec.startsWith(JIJConstants.INTERNAL_URL_PROTOCOL_WITH_COLON))
44	file = spec.substring(5);	46	file = spec.substring(5);

Lines 325-413 Link Here

(-)a/org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/nls/search/NLSSearchResultRequestor.java (-58 / +36 lines)
325	*/	325	*/
326	private int findPropertyNameStartPosition(String propertyName) {	326	private int findPropertyNameStartPosition(String propertyName) {
327	// Fix for http://dev.eclipse.org/bugs/show_bug.cgi?id=19319	327	// Fix for http://dev.eclipse.org/bugs/show_bug.cgi?id=19319
328	InputStream stream= null;
329	LineReader lineReader= null;
330	String encoding;	328	String encoding;
331	try {	329	try {
332	encoding= fPropertiesFile.getCharset();	330	encoding= fPropertiesFile.getCharset();
333	} catch (CoreException e1) {	331	} catch (CoreException e1) {
334	encoding= "ISO-8859-1"; //$NON-NLS-1$	332	encoding= "ISO-8859-1"; //$NON-NLS-1$
335	}	333	}
336	try {	334	try (InputStream stream= createInputStream(fPropertiesFile)) {
337	stream= createInputStream(fPropertiesFile);	335	try (LineReader lineReader= new LineReader(stream, encoding)) {
338	lineReader= new LineReader(stream, encoding);	336	int start= 0;
		337	try {
		338	StringBuffer buf= new StringBuffer(80);
		339	int eols= lineReader.readLine(buf);
		340	int keyLength= propertyName.length();
		341	while (eols > 0) {
		342	String line= buf.toString();
		343	int i= line.indexOf(propertyName);
		344	int charPos= i + keyLength;
		345	char terminatorChar= 0;
		346	boolean hasNoValue= (charPos >= line.length());
		347	if (i > -1 && !hasNoValue)
		348	terminatorChar= line.charAt(charPos);
		349	if (line.trim().startsWith(propertyName) &&
		350	(hasNoValue \|\| Character.isWhitespace(terminatorChar) \|\| terminatorChar == '=')) {
		351	start += line.indexOf(propertyName);
		352	eols= -17; // found key
		353	} else {
		354	start += line.length() + eols;
		355	buf.setLength(0);
		356	eols= lineReader.readLine(buf);
		357	}
		358	}
		359	if (eols != -17)
		360	start= -1; //key not found in file. See bug 63794. This can happen if the key contains escaped characters.
		361	} catch (IOException ex) {
		362	JavaPlugin.log(ex);
		363	return -1;
		364	}
		365	return start;
		366	}
339	} catch (CoreException cex) {	367	} catch (CoreException cex) {
340	// failed to get input stream	368	// failed to get input stream
341	JavaPlugin.log(cex);	369	JavaPlugin.log(cex);
342	return -1;	370	return -1;
343	} catch (IOException e) {	371	} catch (IOException e) {
344	if (stream != null) {	372	JavaPlugin.log(e);
345	try {
346	stream.close();
347	} catch (IOException ce) {
348	JavaPlugin.log(ce);
349	}
350	}
351	return -1;	373	return -1;
352	}	374	}
353	int start= 0;
354	try {
355	StringBuffer buf= new StringBuffer(80);
356	int eols= lineReader.readLine(buf);
357	int keyLength= propertyName.length();
358	while (eols > 0) {
359	String line= buf.toString();
360	int i= line.indexOf(propertyName);
361	int charPos= i + keyLength;
362	char terminatorChar= 0;
363	boolean hasNoValue= (charPos >= line.length());
364	if (i > -1 && !hasNoValue)
365	terminatorChar= line.charAt(charPos);
366	if (line.trim().startsWith(propertyName) &&
367	(hasNoValue \|\| Character.isWhitespace(terminatorChar) \|\| terminatorChar == '=')) {
368	start += line.indexOf(propertyName);
369	eols= -17; // found key
370	} else {
371	start += line.length() + eols;
372	buf.setLength(0);
373	eols= lineReader.readLine(buf);
374	}
375	}
376	if (eols != -17)
377	start= -1; //key not found in file. See bug 63794. This can happen if the key contains escaped characters.
378	} catch (IOException ex) {
379	JavaPlugin.log(ex);
380	return -1;
381	} finally {
382	try {
383	lineReader.close();
384	} catch (IOException ex) {
385	JavaPlugin.log(ex);
386	}
387	}
388	return start;
389	}	375	}
390		376
391	private void loadProperties() {	377	private void loadProperties() {
392	Set<Object> duplicateKeys= new HashSet<>();	378	Set<Object> duplicateKeys= new HashSet<>();
393	fProperties= new Properties(duplicateKeys);	379	fProperties= new Properties(duplicateKeys);
394	InputStream stream;	380	try (InputStream stream= new BufferedInputStream(createInputStream(fPropertiesFile))) {
395	try {	381	fProperties.load(stream);
396	stream= new BufferedInputStream(createInputStream(fPropertiesFile));
397	} catch (CoreException ex) {	382	} catch (CoreException ex) {
398	fProperties= new Properties();	383	fProperties= new Properties();
399	return;	384	return;
400	}
401	try {
402	fProperties.load(stream);
403	} catch (IOException ex) {	385	} catch (IOException ex) {
404	fProperties= new Properties();	386	fProperties= new Properties();
405	return;	387	return;
406	} finally {	388	} finally {
407	try {
408	stream.close();
409	} catch (IOException ex) {
410	}
411	reportDuplicateKeys(duplicateKeys);	389	reportDuplicateKeys(duplicateKeys);
412	}	390	}
413	}	391	}

Lines 72-90 Link Here

(-)a/org.eclipse.jdt.ui/ui refactoring/org/eclipse/jdt/internal/ui/refactoring/reorg/TypedSourceTransfer.java (-10 / +3 lines)
72	* (String) source of the element	72	* (String) source of the element
73	*/	73	*/
74		74
75	try {	75	try (ByteArrayOutputStream out = new ByteArrayOutputStream();
76	ByteArrayOutputStream out = new ByteArrayOutputStream();	76	DataOutputStream dataOut = new DataOutputStream(out)) {
77	DataOutputStream dataOut = new DataOutputStream(out);
78		77
79	dataOut.writeInt(sources.length);	78	dataOut.writeInt(sources.length);
80		79
81	for (int i = 0; i < sources.length; i++) {	80	for (int i = 0; i < sources.length; i++) {
82	writeJavaElement(dataOut, sources[i]);	81	writeJavaElement(dataOut, sources[i]);
83	}	82	}
84
85	dataOut.close();
86	out.close();
87
88	super.javaToNative(out.toByteArray(), transferData);	83	super.javaToNative(out.toByteArray(), transferData);
89	} catch (IOException e) {	84	} catch (IOException e) {
90	//it's best to send nothing if there were problems	85	//it's best to send nothing if there were problems
Lines 97-111 Link Here
97	byte[] bytes = (byte[]) super.nativeToJava(transferData);	92	byte[] bytes = (byte[]) super.nativeToJava(transferData);
98	if (bytes == null)	93	if (bytes == null)
99	return null;	94	return null;
100	DataInputStream in = new DataInputStream(new ByteArrayInputStream(bytes));	95	try (DataInputStream in = new DataInputStream(new ByteArrayInputStream(bytes))) {
101	try {
102	int count = in.readInt();	96	int count = in.readInt();
103	TypedSource[] results = new TypedSource[count];	97	TypedSource[] results = new TypedSource[count];
104	for (int i = 0; i < count; i++) {	98	for (int i = 0; i < count; i++) {
105	results[i] = readJavaElement(in);	99	results[i] = readJavaElement(in);
106	Assert.isNotNull(results[i]);	100	Assert.isNotNull(results[i]);
107	}	101	}
108	in.close();
109	return results;	102	return results;
110	} catch (IOException e) {	103	} catch (IOException e) {
111	return null;	104	return null;

Lines 38-43 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/fix/CleanUpRefactoringWizard.java (-8 / +8 lines)
38		38
39	import org.eclipse.core.runtime.CoreException;	39	import org.eclipse.core.runtime.CoreException;
40	import org.eclipse.core.runtime.IStatus;	40	import org.eclipse.core.runtime.IStatus;
		41	import org.eclipse.core.runtime.Status;
41	import org.eclipse.core.runtime.preferences.IEclipsePreferences;	42	import org.eclipse.core.runtime.preferences.IEclipsePreferences;
42	import org.eclipse.core.runtime.preferences.InstanceScope;	43	import org.eclipse.core.runtime.preferences.InstanceScope;
43		44
Lines 475-482 Link Here
475	}	476	}
476		477
477	public String encodeSettings(Map<String, String> settings) throws CoreException {	478	public String encodeSettings(Map<String, String> settings) throws CoreException {
478	ByteArrayOutputStream stream= new ByteArrayOutputStream(2000);	479	try (ByteArrayOutputStream stream= new ByteArrayOutputStream(2000)) {
479	try {
480	CleanUpProfileVersioner versioner= new CleanUpProfileVersioner();	480	CleanUpProfileVersioner versioner= new CleanUpProfileVersioner();
481	CustomProfile profile= new ProfileManager.CustomProfile("custom", settings, versioner.getCurrentVersion(), versioner.getProfileKind()); //$NON-NLS-1$	481	CustomProfile profile= new ProfileManager.CustomProfile("custom", settings, versioner.getCurrentVersion(), versioner.getProfileKind()); //$NON-NLS-1$
482	ArrayList<Profile> profiles= new ArrayList<>();	482	ArrayList<Profile> profiles= new ArrayList<>();
Lines 487-494 Link Here
487	} catch (UnsupportedEncodingException e) {	487	} catch (UnsupportedEncodingException e) {
488	return stream.toString();	488	return stream.toString();
489	}	489	}
490	} finally {	490	} catch (IOException e) {
491	try { stream.close(); } catch (IOException e) { /* ignore */ }	491	throw new CoreException(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), e.getMessage(), e));
492	}	492	}
493	}	493	}
494		494
Lines 499-506 Link Here
499	} catch (UnsupportedEncodingException e) {	499	} catch (UnsupportedEncodingException e) {
500	bytes= settings.getBytes();	500	bytes= settings.getBytes();
501	}	501	}
502	InputStream is= new ByteArrayInputStream(bytes);	502	try (InputStream is= new ByteArrayInputStream(bytes)) {
503	try {
504	List<Profile> res= ProfileStore.readProfilesFromStream(new InputSource(is));	503	List<Profile> res= ProfileStore.readProfilesFromStream(new InputSource(is));
505	if (res == null \|\| res.size() == 0)	504	if (res == null \|\| res.size() == 0)
506	return JavaPlugin.getDefault().getCleanUpRegistry().getDefaultOptions(CleanUpConstants.DEFAULT_CLEAN_UP_OPTIONS).getMap();	505	return JavaPlugin.getDefault().getCleanUpRegistry().getDefaultOptions(CleanUpConstants.DEFAULT_CLEAN_UP_OPTIONS).getMap();
Lines 508-515 Link Here
508	CustomProfile profile= (CustomProfile)res.get(0);	507	CustomProfile profile= (CustomProfile)res.get(0);
509	new CleanUpProfileVersioner().update(profile);	508	new CleanUpProfileVersioner().update(profile);
510	return profile.getSettings();	509	return profile.getSettings();
511	} finally {	510	} catch (IOException e) {
512	try { is.close(); } catch (IOException e) { /* ignore */ }	511	// ignore
		512	return null;
513	}	513	}
514	}	514	}
515		515

Lines 467-491 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/infoviews/SourceView.java (-9 / +2 lines)
467	* @return the source without leading comments	467	* @return the source without leading comments
468	*/	468	*/
469	private String removeLeadingComments(String source) {	469	private String removeLeadingComments(String source) {
470	JavaCodeReader reader= new JavaCodeReader();
471	IDocument document= new Document(source);	470	IDocument document= new Document(source);
472	int i;	471	int i;
473	try {	472	try (JavaCodeReader reader= new JavaCodeReader()) {
474	reader.configureForwardReader(document, 0, document.getLength(), true, false);	473	reader.configureForwardReader(document, 0, document.getLength(), true, false);
475	int c= reader.read();	474	int c= reader.read();
476	while (c != -1 && (c == '\r' \|\| c == '\n' \|\| c == '\t')) {	475	while (c != -1 && (c == '\r' \|\| c == '\n' \|\| c == '\t')) {
477	c= reader.read();	476	c= reader.read();
478	}	477	}
479	i= reader.getOffset();	478	i= reader.getOffset();
480	reader.close();
481	} catch (IOException ex) {	479	} catch (IOException ex) {
482	i= 0;	480	i= 0;
483	} finally {	481	JavaPlugin.log(ex);
484	try {
485	reader.close();
486	} catch (IOException ex) {
487	JavaPlugin.log(ex);
488	}
489	}	482	}
490		483
491	try {	484	try {

Lines 103-134 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/jarimport/JarImportWizard.java (-18 / +3 lines)
103	if (uri != null) {	103	if (uri != null) {
104	final File file= new File(uri);	104	final File file= new File(uri);
105	if (file.exists()) {	105	if (file.exists()) {
106	ZipFile zip= null;	106	try (ZipFile zip= new ZipFile(file, ZipFile.OPEN_READ)) {
107	try {
108	zip= new ZipFile(file, ZipFile.OPEN_READ);
109	ZipEntry entry= zip.getEntry(JarPackagerUtil.getRefactoringsEntry());	107	ZipEntry entry= zip.getEntry(JarPackagerUtil.getRefactoringsEntry());
110	if (entry != null) {	108	if (entry != null) {
111	InputStream stream= null;	109	try (InputStream stream= zip.getInputStream(entry)) {
112	try {
113	stream= zip.getInputStream(entry);
114	final RefactoringHistory existing= RefactoringCore.getHistoryService().readRefactoringHistory(stream, JavaRefactoringDescriptor.JAR_MIGRATION \| JavaRefactoringDescriptor.JAR_REFACTORING);	110	final RefactoringHistory existing= RefactoringCore.getHistoryService().readRefactoringHistory(stream, JavaRefactoringDescriptor.JAR_MIGRATION \| JavaRefactoringDescriptor.JAR_REFACTORING);
115	if (existing != null)	111	if (existing != null)
116	fHistoryDelta= incoming.removeAll(existing).getDescriptors();	112	fHistoryDelta= incoming.removeAll(existing).getDescriptors();
117	} finally {
118	if (stream != null) {
119	try {
120	stream.close();
121	} catch (IOException exception) {
122	// Do nothing
123	}
124	}
125	}	113	}
126	}	114	}
127	} catch (IOException exception) {	115	} catch (IOException exception) {
128	try {	116	// ignore
129	zip.close();
130	} catch(IOException e){
131	}
132	}	117	}
133	}	118	}
134	}	119	}

Lines 368-382 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/jarimport/JarImportWizardPage.java (-37 / +7 lines)
368	setPageComplete(false);	368	setPageComplete(false);
369	return;	369	return;
370	}	370	}
371	ZipFile zip= null;	371	try (ZipFile zip= new ZipFile(file, ZipFile.OPEN_READ)) {
372	try {
373	try {
374	zip= new ZipFile(file, ZipFile.OPEN_READ);
375	} catch (IOException exception) {
376	setErrorMessage(JarImportMessages.JarImportWizardPage_invalid_location);
377	setPageComplete(false);
378	return;
379	}
380	final JarImportData data= fWizard.getImportData();	372	final JarImportData data= fWizard.getImportData();
381	data.setRefactoringFileLocation(URIUtil.toURI(path));	373	data.setRefactoringFileLocation(URIUtil.toURI(path));
382	ZipEntry entry= zip.getEntry(JarPackagerUtil.getRefactoringsEntry());	374	ZipEntry entry= zip.getEntry(JarPackagerUtil.getRefactoringsEntry());
Lines 391-399 Link Here
391	setPageComplete(true);	383	setPageComplete(true);
392	return;	384	return;
393	}	385	}
394	InputStream stream= null;	386	try (InputStream stream= zip.getInputStream(entry)) {
395	try {
396	stream= zip.getInputStream(entry);
397	data.setRefactoringHistory(RefactoringCore.getHistoryService().readRefactoringHistory(stream, JavaRefactoringDescriptor.JAR_MIGRATION \| JavaRefactoringDescriptor.JAR_REFACTORING));	387	data.setRefactoringHistory(RefactoringCore.getHistoryService().readRefactoringHistory(stream, JavaRefactoringDescriptor.JAR_MIGRATION \| JavaRefactoringDescriptor.JAR_REFACTORING));
398	} catch (IOException exception) {	388	} catch (IOException exception) {
399	setErrorMessage(JarImportMessages.JarImportWizardPage_no_refactorings);	389	setErrorMessage(JarImportMessages.JarImportWizardPage_no_refactorings);
Lines 404-425 Link Here
404	setErrorMessage(JarImportMessages.JarImportWizardPage_no_refactorings);	394	setErrorMessage(JarImportMessages.JarImportWizardPage_no_refactorings);
405	setPageComplete(false);	395	setPageComplete(false);
406	return;	396	return;
407	} finally {
408	if (stream != null) {
409	try {
410	stream.close();
411	} catch (IOException exception) {
412	// Do nothing
413	}
414	}
415	}	397	}
416	} finally {	398	} catch (IOException exception) {
417	if (zip != null) {	399	setErrorMessage(JarImportMessages.JarImportWizardPage_invalid_location);
418	try {	400	setPageComplete(false);
419	zip.close();	401	return;
420	} catch (IOException e) {
421	}
422	}
423	}	402	}
424	}	403	}
425	}	404	}
Lines 462-483 Link Here
462	if (uri != null) {	441	if (uri != null) {
463	final File file= new File(uri);	442	final File file= new File(uri);
464	if (file.exists()) {	443	if (file.exists()) {
465	ZipFile zip= null;	444	try (ZipFile zip= new ZipFile(file, ZipFile.OPEN_READ)) {
466	try {
467	zip= new ZipFile(file, ZipFile.OPEN_READ);
468	ZipEntry entry= zip.getEntry(JarPackagerUtil.getRefactoringsEntry());	445	ZipEntry entry= zip.getEntry(JarPackagerUtil.getRefactoringsEntry());
469	if (entry != null) {	446	if (entry != null) {
470	fWizard.getImportData().setExistingTimeStamp(entry.getTime());	447	fWizard.getImportData().setExistingTimeStamp(entry.getTime());
471	}	448	}
472	} catch (IOException exception) {	449	} catch (IOException exception) {
473	// Just leave it	450	// Just leave it
474	} finally {
475	if (zip != null) {
476	try {
477	zip.close();
478	} catch (IOException e) {
479	}
480	}
481	}	451	}
482	}	452	}
483	}	453	}

Lines 213-233 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/jarpackager/JarFileExportOperation.java (-34 / +11 lines)
213	if (element instanceof IPackageFragmentRoot) {	213	if (element instanceof IPackageFragmentRoot) {
214	IPackageFragmentRoot root= (IPackageFragmentRoot) element;	214	IPackageFragmentRoot root= (IPackageFragmentRoot) element;
215	if (root.isArchive()) {	215	if (root.isArchive()) {
216	ZipFile file= null;	216	try (ZipFile file = JarPackagerUtil.getArchiveFile(root.getPath())) {
217	try {
218	file= JarPackagerUtil.getArchiveFile(root.getPath());
219	if (file != null)	217	if (file != null)
220	count+= file.size();	218	count+= file.size();
221	} catch (CoreException e) {	219	} catch (CoreException e) {
222	JavaPlugin.log(e);	220	JavaPlugin.log(e);
223	} finally {	221	} catch (IOException e) {
224	try {	222	addWarning(Messages.format(JarPackagerMessages.JarFileExportOperation_CloseZipFileError_message, new Object[] { JavaElementLabels.getElementLabel(root, JavaElementLabels.ALL_DEFAULT), e.getLocalizedMessage() }), e);
225	if (file != null) {
226	file.close();
227	}
228	} catch (IOException e) {
229	addWarning(Messages.format(JarPackagerMessages.JarFileExportOperation_CloseZipFileError_message, new Object[] { JavaElementLabels.getElementLabel(root, JavaElementLabels.ALL_DEFAULT), e.getLocalizedMessage() }), e);
230	}
231	}	223	}
232	} else if (root.isExternal()) {	224	} else if (root.isExternal()) {
233	try {	225	try {
Lines 394-413 Link Here
394	private void exportJavaElement(IProgressMonitor progressMonitor, IJavaElement je) throws InterruptedException {	386	private void exportJavaElement(IProgressMonitor progressMonitor, IJavaElement je) throws InterruptedException {
395	if (je.getElementType() == IJavaElement.PACKAGE_FRAGMENT_ROOT && ((IPackageFragmentRoot) je).isArchive()) {	387	if (je.getElementType() == IJavaElement.PACKAGE_FRAGMENT_ROOT && ((IPackageFragmentRoot) je).isArchive()) {
396	IPackageFragmentRoot root= (IPackageFragmentRoot) je;	388	IPackageFragmentRoot root= (IPackageFragmentRoot) je;
397	ZipFile jarFile= null;	389	try (ZipFile jarFile= JarPackagerUtil.getArchiveFile(root.getPath())) {
398	try {
399	jarFile= JarPackagerUtil.getArchiveFile(root.getPath());
400	fJarBuilder.writeArchive(jarFile, progressMonitor);	390	fJarBuilder.writeArchive(jarFile, progressMonitor);
401	} catch (CoreException e) {	391	} catch (CoreException e) {
402	addWarning(Messages.format(JarPackagerMessages.JarFileExportOperation_OpenZipFileError_message, new Object[] { JavaElementLabels.getElementLabel(root, JavaElementLabels.ALL_DEFAULT), e.getLocalizedMessage() }), e);	392	addWarning(Messages.format(JarPackagerMessages.JarFileExportOperation_OpenZipFileError_message, new Object[] { JavaElementLabels.getElementLabel(root, JavaElementLabels.ALL_DEFAULT), e.getLocalizedMessage() }), e);
403	} finally {	393	} catch (IOException e) {
404	try {	394	addWarning(Messages.format(JarPackagerMessages.JarFileExportOperation_CloseZipFileError_message, new Object[] { JavaElementLabels.getElementLabel(root, JavaElementLabels.ALL_DEFAULT), e.getLocalizedMessage() }), e);
405	if (jarFile != null) {
406	jarFile.close();
407	}
408	} catch (IOException e) {
409	addWarning(Messages.format(JarPackagerMessages.JarFileExportOperation_CloseZipFileError_message, new Object[] { JavaElementLabels.getElementLabel(root, JavaElementLabels.ALL_DEFAULT), e.getLocalizedMessage() }), e);
410	}
411	}	395	}
412	return;	396	return;
413	} else if (je.getElementType() == IJavaElement.PACKAGE_FRAGMENT_ROOT && ((IPackageFragmentRoot) je).isExternal()) {	397	} else if (je.getElementType() == IJavaElement.PACKAGE_FRAGMENT_ROOT && ((IPackageFragmentRoot) je).isExternal()) {
Lines 843-861 Link Here
843	IFile classFile= (IFile)members[i];	827	IFile classFile= (IFile)members[i];
844	URI location= classFile.getLocationURI();	828	URI location= classFile.getLocationURI();
845	if (location != null) {	829	if (location != null) {
846	InputStream contents= null;	830	try (InputStream contents= EFS.getStore(location).openInputStream(EFS.NONE, monitor)) {
847	try {
848	contents= EFS.getStore(location).openInputStream(EFS.NONE, monitor);
849	cfReader= ToolFactory.createDefaultClassFileReader(contents, IClassFileReader.CLASSFILE_ATTRIBUTES);	831	cfReader= ToolFactory.createDefaultClassFileReader(contents, IClassFileReader.CLASSFILE_ATTRIBUTES);
850	} finally {	832	} catch (IOException e) {
851	try {	833	throw new CoreException(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), IStatus.ERROR,
852	if (contents != null)	834	Messages.format(JarPackagerMessages.JarFileExportOperation_errorCannotCloseConnection, BasicElementLabels.getURLPart(Resources.getLocationString(classFile))),
853	contents.close();	835	e));
854	} catch (IOException e) {
855	throw new CoreException(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), IStatus.ERROR,
856	Messages.format(JarPackagerMessages.JarFileExportOperation_errorCannotCloseConnection, BasicElementLabels.getURLPart(Resources.getLocationString(classFile))),
857	e));
858	}
859	}	836	}
860	if (cfReader != null) {	837	if (cfReader != null) {
861	ISourceAttribute sourceAttribute= cfReader.getSourceFileAttribute();	838	ISourceAttribute sourceAttribute= cfReader.getSourceFileAttribute();

Lines 123-134 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/jarpackager/ManifestProvider.java (-5 / +1 lines)
123	private Manifest createSuppliedManifest(JarPackageData jarPackage) throws CoreException, IOException {	123	private Manifest createSuppliedManifest(JarPackageData jarPackage) throws CoreException, IOException {
124	Manifest manifest;	124	Manifest manifest;
125	// No need to use buffer here because Manifest(...) does	125	// No need to use buffer here because Manifest(...) does
126	InputStream stream= jarPackage.getManifestFile().getContents(false);	126	try (InputStream stream= jarPackage.getManifestFile().getContents(false)) {
127	try {
128	manifest= new Manifest(stream);	127	manifest= new Manifest(stream);
129	} finally {
130	if (stream != null)
131	stream.close();
132	}	128	}
133	return manifest;	129	return manifest;
134	}	130	}

Lines 69-88 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/jarpackagerfat/FatJarManifestProvider.java (-18 / +4 lines)
69	while (entries.hasMoreElements()) {	69	while (entries.hasMoreElements()) {
70	ZipEntry entry= entries.nextElement();	70	ZipEntry entry= entries.nextElement();
71	if (entry.getName().equalsIgnoreCase("META-INF/MANIFEST.MF")) { //$NON-NLS-1$	71	if (entry.getName().equalsIgnoreCase("META-INF/MANIFEST.MF")) { //$NON-NLS-1$
72	InputStream inputStream= null;	72	try (InputStream inputStream= zip.getInputStream(entry)) {
73	try {
74	inputStream= zip.getInputStream(entry);
75	Manifest otherManifest= new Manifest(inputStream);	73	Manifest otherManifest= new Manifest(inputStream);
76	otherManifests.add(otherManifest);	74	otherManifests.add(otherManifest);
77	} catch (IOException e) {	75	} catch (IOException e) {
78	JavaPlugin.log(e);	76	JavaPlugin.log(e);
79	} finally {
80	if (inputStream != null) {
81	try {
82	inputStream.close();
83	} catch(IOException e){
84	}
85	}
86	}	77	}
87	}	78	}
88	}	79	}
Lines 91-99 Link Here
91	result= merge(ownManifest, otherManifests);	82	result= merge(ownManifest, otherManifests);
92	} finally {	83	} finally {
93	for (Iterator<ZipFile> iter= openZips.iterator(); iter.hasNext(); ) {	84	for (Iterator<ZipFile> iter= openZips.iterator(); iter.hasNext(); ) {
94	ZipFile file= iter.next();	85	try (ZipFile file = iter.next()) {
95	try {	86	// nothing to do
96	file.close();
97	} catch (IOException e) {	87	} catch (IOException e) {
98	JavaPlugin.log(e);	88	JavaPlugin.log(e);
99	}	89	}
Lines 205-216 Link Here
205	private Manifest createSuppliedManifest(JarPackageData jarPackage) throws CoreException, IOException {	195	private Manifest createSuppliedManifest(JarPackageData jarPackage) throws CoreException, IOException {
206	Manifest manifest;	196	Manifest manifest;
207	// No need to use buffer here because Manifest(...) does	197	// No need to use buffer here because Manifest(...) does
208	InputStream stream= jarPackage.getManifestFile().getContents(false);	198	try (InputStream stream= jarPackage.getManifestFile().getContents(false)) {
209	try {
210	manifest= new Manifest(stream);	199	manifest= new Manifest(stream);
211	} finally {
212	if (stream != null)
213	stream.close();
214	}	200	}
215	return manifest;	201	return manifest;
216	}	202	}

Lines 165-175 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/jarpackagerfat/UnpackJarBuilder.java (-14 / +2 lines)
165	}	165	}
166		166
167	private void copyFile(File src, File dest) {	167	private void copyFile(File src, File dest) {
168	InputStream in= null;	168	try (InputStream in= new FileInputStream(src);
169	OutputStream out= null;	169	OutputStream out= new FileOutputStream(dest)) {
170	try {
171	in= new FileInputStream(src);
172	out= new FileOutputStream(dest);
173	byte[] buf= new byte[4096];	170	byte[] buf= new byte[4096];
174	int cnt= in.read(buf);	171	int cnt= in.read(buf);
175	while (cnt > 0) {	172	while (cnt > 0) {
Lines 182-196 Link Here
182	throw new RuntimeException(e);	179	throw new RuntimeException(e);
183	} catch (IOException e) {	180	} catch (IOException e) {
184	throw new RuntimeException(e);	181	throw new RuntimeException(e);
185	} finally {
186	try {
187	out.close();
188	} catch (IOException ignore) {
189	}
190	try {
191	in.close();
192	} catch (IOException ignore) {
193	}
194	}	182	}
195	}	183	}
196		184

Lines 859-865 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javadocexport/JavadocOptionsManager.java (-10 / +3 lines)
859		859
860		860
861	public File writeXML(Element javadocElement) throws CoreException {	861	public File writeXML(Element javadocElement) throws CoreException {
862	FileOutputStream objectStreamOutput= null;
863	//@change	862	//@change
864	//for now only writing ant files for single project selection	863	//for now only writing ant files for single project selection
865	try {	864	try {
Lines 872-879 Link Here
872		871
873	file.getParentFile().mkdirs();	872	file.getParentFile().mkdirs();
874		873
875	objectStreamOutput= new FileOutputStream(file);	874	try (FileOutputStream objectStreamOutput= new FileOutputStream(file)) {
876	JavadocWriter.writeDocument(javadocElement, encoding, objectStreamOutput);	875	JavadocWriter.writeDocument(javadocElement, encoding, objectStreamOutput);
		876	}
877	return file;	877	return file;
878	} catch (IOException e) {	878	} catch (IOException e) {
879	String message= JavadocExportMessages.JavadocOptionsManager_createXM_error;	879	String message= JavadocExportMessages.JavadocOptionsManager_createXM_error;
Lines 881-893 Link Here
881	} catch (TransformerException e) {	881	} catch (TransformerException e) {
882	String message= JavadocExportMessages.JavadocOptionsManager_createXM_error;	882	String message= JavadocExportMessages.JavadocOptionsManager_createXM_error;
883	throw new CoreException(JavaUIStatus.createError(IStatus.ERROR, message, e));	883	throw new CoreException(JavaUIStatus.createError(IStatus.ERROR, message, e));
884	} finally {
885	if (objectStreamOutput != null) {
886	try {
887	objectStreamOutput.close();
888	} catch (IOException e) {
889	}
890	}
891	}	884	}
892	}	885	}
893		886

Lines 298-305 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javadocexport/JavadocWizard.java (-4 / +1 lines)
298	File file= File.createTempFile("javadoc-arguments", ".tmp"); //$NON-NLS-1$//$NON-NLS-2$	298	File file= File.createTempFile("javadoc-arguments", ".tmp"); //$NON-NLS-1$//$NON-NLS-2$
299	vmArgs.add('@' + file.getAbsolutePath());	299	vmArgs.add('@' + file.getAbsolutePath());
300		300
301	BufferedWriter writer= new BufferedWriter(new OutputStreamWriter(new FileOutputStream(file), getEncoding(vmArgs)));	301	try (BufferedWriter writer= new BufferedWriter(new OutputStreamWriter(new FileOutputStream(file), getEncoding(vmArgs)))) {
302	try {
303	for (int i= 0; i < progArgs.size(); i++) {	302	for (int i= 0; i < progArgs.size(); i++) {
304	String curr= progArgs.get(i);	303	String curr= progArgs.get(i);
305	curr= checkForSpaces(curr);	304	curr= checkForSpaces(curr);
Lines 307-314 Link Here
307	writer.write(curr);	306	writer.write(curr);
308	writer.write(' ');	307	writer.write(' ');
309	}	308	}
310	} finally {
311	writer.close();
312	}	309	}
313	String[] args= vmArgs.toArray(new String[vmArgs.size()]);	310	String[] args= vmArgs.toArray(new String[vmArgs.size()]);
314	process= Runtime.getRuntime().exec(args);	311	process= Runtime.getRuntime().exec(args);

Lines 109-121 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/ClipboardOperationAction.java (-12 / +3 lines)
109	}	109	}
110		110
111	public ClipboardData(byte[] bytes) throws IOException {	111	public ClipboardData(byte[] bytes) throws IOException {
112	DataInputStream dataIn = new DataInputStream(new ByteArrayInputStream(bytes));	112	try (DataInputStream dataIn = new DataInputStream(new ByteArrayInputStream(bytes))) {
113	try {
114	fOriginHandle= dataIn.readUTF();	113	fOriginHandle= dataIn.readUTF();
115	fTypeImports= readArray(dataIn);	114	fTypeImports= readArray(dataIn);
116	fStaticImports= readArray(dataIn);	115	fStaticImports= readArray(dataIn);
117	} finally {
118	dataIn.close();
119	}	116	}
120	}	117	}
121		118
Lines 149-166 Link Here
149	}	146	}
150		147
151	public byte[] serialize() throws IOException {	148	public byte[] serialize() throws IOException {
152	ByteArrayOutputStream out = new ByteArrayOutputStream();	149	try (ByteArrayOutputStream out = new ByteArrayOutputStream(); DataOutputStream dataOut = new DataOutputStream(out)) {
153	DataOutputStream dataOut = new DataOutputStream(out);
154	try {
155	dataOut.writeUTF(fOriginHandle);	150	dataOut.writeUTF(fOriginHandle);
156	writeArray(dataOut, fTypeImports);	151	writeArray(dataOut, fTypeImports);
157	writeArray(dataOut, fStaticImports);	152	writeArray(dataOut, fStaticImports);
158	} finally {	153	return out.toByteArray();
159	dataOut.close();
160	out.close();
161	}	154	}
162
163	return out.toByteArray();
164	}	155	}
165	}	156	}
166		157

Lines 160-183 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/InternalClassFileEditorInput.java (-13 / +6 lines)
160	}	160	}
161		161
162	private static IPath writeToTempFile(IClassFile classFile) {	162	private static IPath writeToTempFile(IClassFile classFile) {
163	FileOutputStream writer= null;
164	try {	163	try {
165	File file= File.createTempFile(classFile.getElementName(), ".class"); //$NON-NLS-1$	164	File file= File.createTempFile(classFile.getElementName(), ".class"); //$NON-NLS-1$
166	byte[] bytes= classFile.getBytes();	165	byte[] bytes= classFile.getBytes();
167	writer= new FileOutputStream(file);	166	try (FileOutputStream writer= new FileOutputStream(file)) {
168	writer.write(bytes);	167	writer.write(bytes);
169	return new Path(file.toString());	168	return new Path(file.toString());
170	} catch (IOException e) {	169	}
171	JavaPlugin.log(e);
172	} catch (CoreException e) {	170	} catch (CoreException e) {
173	JavaPlugin.log(e.getStatus());	171	JavaPlugin.log(e.getStatus());
174	} finally {	172	} catch (IOException e) {
175	if (writer != null)	173	JavaPlugin.log(e);
176	try {
177	writer.close();
178	} catch (IOException e) {
179	JavaPlugin.log(e);
180	}
181	}	174	}
182	throw new IllegalArgumentException("Could not create temporary file."); //$NON-NLS-1$	175	throw new IllegalArgumentException("Could not create temporary file."); //$NON-NLS-1$
183	}	176	}

Lines 15-21 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/CodeTemplateBlock.java (-34 / +12 lines)
15	import java.io.BufferedOutputStream;	15	import java.io.BufferedOutputStream;
16	import java.io.File;	16	import java.io.File;
17	import java.io.FileInputStream;	17	import java.io.FileInputStream;
18	import java.io.FileNotFoundException;
19	import java.io.FileOutputStream;	18	import java.io.FileOutputStream;
20	import java.io.IOException;	19	import java.io.IOException;
21	import java.io.InputStream;	20	import java.io.InputStream;
Lines 480-512 Link Here
480	if (path == null)	479	if (path == null)
481	return;	480	return;
482		481
483	try {	482	TemplateReaderWriter reader= new TemplateReaderWriter();
484	TemplateReaderWriter reader= new TemplateReaderWriter();	483	File file= new File(path);
485	File file= new File(path);	484	if (file.exists()) {
486	if (file.exists()) {	485	try (InputStream input= new BufferedInputStream(new FileInputStream(file))) {
487	InputStream input= new BufferedInputStream(new FileInputStream(file));	486	TemplatePersistenceData[] datas= reader.read(input, null);
488	try {	487	for (int i= 0; i < datas.length; i++) {
489	TemplatePersistenceData[] datas= reader.read(input, null);	488	updateTemplate(datas[i]);
490	for (int i= 0; i < datas.length; i++) {
491	updateTemplate(datas[i]);
492	}
493	} finally {
494	try {
495	input.close();
496	} catch (IOException x) {
497	}
498	}	489	}
		490	} catch (IOException e) {
		491	openReadErrorDialog(e);
499	}	492	}
500
501	fCodeTemplateTree.refresh();
502	updateSourceViewerInput(fCodeTemplateTree.getSelectedElements());
503
504	} catch (FileNotFoundException e) {
505	openReadErrorDialog(e);
506	} catch (IOException e) {
507	openReadErrorDialog(e);
508	}	493	}
509		494
		495	fCodeTemplateTree.refresh();
		496	updateSourceViewerInput(fCodeTemplateTree.getSelectedElements());
510	}	497	}
511		498
512	private void updateTemplate(TemplatePersistenceData data) {	499	private void updateTemplate(TemplatePersistenceData data) {
Lines 567-586 Link Here
567	}	554	}
568		555
569	if (!file.exists() \|\| confirmOverwrite(file)) {	556	if (!file.exists() \|\| confirmOverwrite(file)) {
570	OutputStream output= null;	557	try (OutputStream output= new BufferedOutputStream(new FileOutputStream(file))) {
571	try {
572	output= new BufferedOutputStream(new FileOutputStream(file));
573	TemplateReaderWriter writer= new TemplateReaderWriter();	558	TemplateReaderWriter writer= new TemplateReaderWriter();
574	writer.save(templates, output);	559	writer.save(templates, output);
575	output.close();	560	output.close();
576	} catch (IOException e) {	561	} catch (IOException e) {
577	if (output != null) {
578	try {
579	output.close();
580	} catch (IOException e2) {
581	// ignore
582	}
583	}
584	openWriteErrorDialog();	562	openWriteErrorDialog();
585	}	563	}
586	}	564	}

Lines 352-360 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/ImportOrganizeConfigurationBlock.java (-14 / +2 lines)
352	dialogSettings.put(DIALOGSETTING_LASTLOADPATH, dialog.getFilterPath());	352	dialogSettings.put(DIALOGSETTING_LASTLOADPATH, dialog.getFilterPath());
353		353
354	Properties properties= new Properties();	354	Properties properties= new Properties();
355	FileInputStream fis= null;	355	try (FileInputStream fis= new FileInputStream(fileName)) {
356	try {
357	fis= new FileInputStream(fileName);
358	properties.load(fis);	356	properties.load(fis);
359	List<ImportOrderEntry> res= loadFromProperties(properties);	357	List<ImportOrderEntry> res= loadFromProperties(properties);
360	if (res != null) {	358	if (res != null) {
Lines 362-371 Link Here
362	}	360	}
363	} catch (IOException e) {	361	} catch (IOException e) {
364	JavaPlugin.log(e);	362	JavaPlugin.log(e);
365	} finally {
366	if (fis != null) {
367	try { fis.close(); } catch (IOException e) {}
368	}
369	}	363	}
370	String title= PreferencesMessages.ImportOrganizeConfigurationBlock_loadDialog_error_title;	364	String title= PreferencesMessages.ImportOrganizeConfigurationBlock_loadDialog_error_title;
371	String message= PreferencesMessages.ImportOrganizeConfigurationBlock_loadDialog_error_message;	365	String message= PreferencesMessages.ImportOrganizeConfigurationBlock_loadDialog_error_message;
Lines 394-412 Link Here
394	ImportOrderEntry entry= elements.get(i);	388	ImportOrderEntry entry= elements.get(i);
395	properties.setProperty(String.valueOf(i), entry.serialize());	389	properties.setProperty(String.valueOf(i), entry.serialize());
396	}	390	}
397	FileOutputStream fos= null;	391	try (FileOutputStream fos= new FileOutputStream(fileName)) {
398	try {
399	fos= new FileOutputStream(fileName);
400	properties.store(fos, "Organize Import Order"); //$NON-NLS-1$	392	properties.store(fos, "Organize Import Order"); //$NON-NLS-1$
401	} catch (IOException e) {	393	} catch (IOException e) {
402	JavaPlugin.log(e);	394	JavaPlugin.log(e);
403	String title= PreferencesMessages.ImportOrganizeConfigurationBlock_saveDialog_error_title;	395	String title= PreferencesMessages.ImportOrganizeConfigurationBlock_saveDialog_error_title;
404	String message= PreferencesMessages.ImportOrganizeConfigurationBlock_saveDialog_error_message;	396	String message= PreferencesMessages.ImportOrganizeConfigurationBlock_saveDialog_error_message;
405	MessageDialog.openError(getShell(), title, message);	397	MessageDialog.openError(getShell(), title, message);
406	} finally {
407	if (fos != null) {
408	try { fos.close(); } catch (IOException e) {}
409	}
410	}	398	}
411	}	399	}
412	}	400	}

Lines 418-433 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/JavadocConfigurationBlock.java (-6 / +2 lines)
418	connection.connect();	418	connection.connect();
419	res= ((HttpURLConnection) connection).getResponseCode();	419	res= ((HttpURLConnection) connection).getResponseCode();
420	}	420	}
421	InputStream is= null;	421	try (InputStream is= connection.getInputStream()) {
422	try {
423	is= connection.getInputStream();
424	byte[] buffer= new byte[256];	422	byte[] buffer= new byte[256];
425	while (is.read(buffer) != -1) {	423	while (is.read(buffer) != -1) {
426	// just read	424	// just read
427	}	425	}
428	} finally {
429	if (is != null)
430	is.close();
431	}	426	}
432	} catch (IllegalArgumentException e) {	427	} catch (IllegalArgumentException e) {
433	return false; // workaround for bug 91072	428	return false; // workaround for bug 91072
Lines 531-536 Link Here
531	}	526	}
532		527
533	private String internalChooseArchivePath() {	528	private String internalChooseArchivePath() {
		529	@SuppressWarnings("resource")
534	ZipFile zipFile= null;	530	ZipFile zipFile= null;
535	try {	531	try {
536	if (fWorkspaceRadio.isSelected()) {	532	if (fWorkspaceRadio.isSelected()) {

Lines 559-566 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/UserLibraryPreferencePage.java (-11 / +2 lines)
559	}	559	}
560		560
561	protected static void saveLibraries(List<CPUserLibraryElement> libraries, File file, String encoding, IProgressMonitor monitor) throws IOException {	561	protected static void saveLibraries(List<CPUserLibraryElement> libraries, File file, String encoding, IProgressMonitor monitor) throws IOException {
562	OutputStream stream= new FileOutputStream(file);	562	try (OutputStream stream= new FileOutputStream(file)) {
563	try {
564	DocumentBuilder docBuilder= null;	563	DocumentBuilder docBuilder= null;
565	DocumentBuilderFactory factory= DocumentBuilderFactory.newInstance();	564	DocumentBuilderFactory factory= DocumentBuilderFactory.newInstance();
566	factory.setValidating(false);	565	factory.setValidating(false);
Lines 635-645 Link Here
635	} catch (TransformerException e) {	634	} catch (TransformerException e) {
636	throw new IOException(e.getMessage());	635	throw new IOException(e.getMessage());
637	} finally {	636	} finally {
638	try {
639	stream.close();
640	} catch (IOException e) {
641	// ignore
642	}
643	if (monitor != null) {	637	if (monitor != null) {
644	monitor.done();	638	monitor.done();
645	}	639	}
Lines 647-655 Link Here
647	}	641	}
648		642
649	private static List<CPUserLibraryElement> loadLibraries(File file) throws IOException {	643	private static List<CPUserLibraryElement> loadLibraries(File file) throws IOException {
650	InputStream stream= new FileInputStream(file);
651	Element cpElement;	644	Element cpElement;
652	try {	645	try (InputStream stream= new FileInputStream(file)) {
653	DocumentBuilder parser = DocumentBuilderFactory.newInstance().newDocumentBuilder();	646	DocumentBuilder parser = DocumentBuilderFactory.newInstance().newDocumentBuilder();
654	parser.setErrorHandler(new DefaultHandler());	647	parser.setErrorHandler(new DefaultHandler());
655	cpElement = parser.parse(new InputSource(stream)).getDocumentElement();	648	cpElement = parser.parse(new InputSource(stream)).getDocumentElement();
Lines 657-664 Link Here
657	throw new IOException(PreferencesMessages.UserLibraryPreferencePage_LoadSaveDialog_load_badformat);	650	throw new IOException(PreferencesMessages.UserLibraryPreferencePage_LoadSaveDialog_load_badformat);
658	} catch (ParserConfigurationException e) {	651	} catch (ParserConfigurationException e) {
659	throw new IOException(PreferencesMessages.UserLibraryPreferencePage_LoadSaveDialog_load_badformat);	652	throw new IOException(PreferencesMessages.UserLibraryPreferencePage_LoadSaveDialog_load_badformat);
660	} finally {
661	stream.close();
662	}	653	}
663		654
664	if (!cpElement.getNodeName().equalsIgnoreCase(TAG_ROOT)) {	655	if (!cpElement.getNodeName().equalsIgnoreCase(TAG_ROOT)) {

Lines 165-172 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/preferences/formatter/ProfileStore.java (-23 / +10 lines)
165	}	165	}
166		166
167	public void writeProfiles(Collection<Profile> profiles, IScopeContext instanceScope) throws CoreException {	167	public void writeProfiles(Collection<Profile> profiles, IScopeContext instanceScope) throws CoreException {
168	ByteArrayOutputStream stream= new ByteArrayOutputStream(2000);	168	try (ByteArrayOutputStream stream= new ByteArrayOutputStream(2000)) {
169	try {
170	writeProfilesToStream(profiles, stream, ENCODING, fProfileVersioner);	169	writeProfilesToStream(profiles, stream, ENCODING, fProfileVersioner);
171	String val;	170	String val;
172	try {	171	try {
Lines 177-184 Link Here
177	IEclipsePreferences uiPreferences = instanceScope.getNode(JavaUI.ID_PLUGIN);	176	IEclipsePreferences uiPreferences = instanceScope.getNode(JavaUI.ID_PLUGIN);
178	uiPreferences.put(fProfilesKey, val);	177	uiPreferences.put(fProfilesKey, val);
179	uiPreferences.putInt(fProfilesVersionKey, fProfileVersioner.getCurrentVersion());	178	uiPreferences.putInt(fProfilesVersionKey, fProfileVersioner.getCurrentVersion());
180	} finally {	179	} catch (IOException e) {
181	try { stream.close(); } catch (IOException e) { /* ignore */ }	180	// ignore
182	}	181	}
183	}	182	}
184		183
Lines 190-197 Link Here
190	} catch (UnsupportedEncodingException e) {	189	} catch (UnsupportedEncodingException e) {
191	bytes= profiles.getBytes();	190	bytes= profiles.getBytes();
192	}	191	}
193	InputStream is= new ByteArrayInputStream(bytes);	192	try (InputStream is= new ByteArrayInputStream(bytes)) {
194	try {
195	List<Profile> res= readProfilesFromStream(new InputSource(is));	193	List<Profile> res= readProfilesFromStream(new InputSource(is));
196	if (res != null) {	194	if (res != null) {
197	for (int i= 0; i < res.size(); i++) {	195	for (int i= 0; i < res.size(); i++) {
Lines 199-206 Link Here
199	}	197	}
200	}	198	}
201	return res;	199	return res;
202	} finally {	200	} catch (IOException e) {
203	try { is.close(); } catch (IOException e) { /* ignore */ }	201	// ignore
204	}	202	}
205	}	203	}
206	return null;	204	return null;
Lines 215-227 Link Here
215	* @throws CoreException	213	* @throws CoreException
216	*/	214	*/
217	public List<Profile> readProfilesFromFile(File file) throws CoreException {	215	public List<Profile> readProfilesFromFile(File file) throws CoreException {
218	try {	216	try (final FileInputStream reader= new FileInputStream(file)) {
219	final FileInputStream reader= new FileInputStream(file);	217	return readProfilesFromStream(new InputSource(reader));
220	try {
221	return readProfilesFromStream(new InputSource(reader));
222	} finally {
223	try { reader.close(); } catch (IOException e) { /* ignore */ }
224	}
225	} catch (IOException e) {	218	} catch (IOException e) {
226	throw createException(e, FormatterMessages.CodingStyleConfigurationBlock_error_reading_xml_message);	219	throw createException(e, FormatterMessages.CodingStyleConfigurationBlock_error_reading_xml_message);
227	}	220	}
Lines 258-271 Link Here
258	* @throws CoreException	251	* @throws CoreException
259	*/	252	*/
260	public void writeProfilesToFile(Collection<Profile> profiles, File file, String encoding) throws CoreException {	253	public void writeProfilesToFile(Collection<Profile> profiles, File file, String encoding) throws CoreException {
261	final OutputStream stream;	254	try (final OutputStream stream= new FileOutputStream(file)) {
262	try {	255	writeProfilesToStream(profiles, stream, encoding, fProfileVersioner);
263	stream= new FileOutputStream(file);
264	try {
265	writeProfilesToStream(profiles, stream, encoding, fProfileVersioner);
266	} finally {
267	try { stream.close(); } catch (IOException e) { /* ignore */ }
268	}
269	} catch (IOException e) {	256	} catch (IOException e) {
270	throw createException(e, FormatterMessages.CodingStyleConfigurationBlock_error_serializing_xml_message);	257	throw createException(e, FormatterMessages.CodingStyleConfigurationBlock_error_serializing_xml_message);
271	}	258	}

Lines 89-102 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/correction/SerialVersionHashOperation.java (-4 / +1 lines)
89	if (classfileResource == null)	89	if (classfileResource == null)
90	return null;	90	return null;
91		91
92	InputStream contents= classfileResource.getContents();	92	try (InputStream contents= classfileResource.getContents()) {
93	try {
94	IClassFileReader cfReader= ToolFactory.createDefaultClassFileReader(contents, IClassFileReader.ALL);	93	IClassFileReader cfReader= ToolFactory.createDefaultClassFileReader(contents, IClassFileReader.ALL);
95	if (cfReader != null) {	94	if (cfReader != null) {
96	return calculateSerialVersionId(cfReader);	95	return calculateSerialVersionId(cfReader);
97	}	96	}
98	} finally {
99	contents.close();
100	}	97	}
101	return null;	98	return null;
102	} finally {	99	} finally {

Lines 759-780 Link Here

(-)a/org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/javadoc/JavadocContentAccess2.java (-45 / +14 lines)
759	Javadoc javadoc= getJavadocNode(member, rawJavadoc);	759	Javadoc javadoc= getJavadocNode(member, rawJavadoc);
760		760
761	if (javadoc == null) {	761	if (javadoc == null) {
762	Reader contentReader= null;	762	try (Reader contentReader = JavadocContentAccess.getHTMLContentReader(member, false, false)) {
763	// fall back to JavadocContentAccess:	763	// fall back to JavadocContentAccess:
764	try {
765	contentReader= JavadocContentAccess.getHTMLContentReader(member, false, false);
766	if (contentReader != null)	764	if (contentReader != null)
767	return getString(contentReader);	765	return getString(contentReader);
768	} catch (JavaModelException e) {	766	} catch (JavaModelException e) {
769	JavaPlugin.log(e);	767	JavaPlugin.log(e);
770	} finally {	768	} catch (IOException e) {
771	if (contentReader != null) {	769	//ignore
772	try {
773	contentReader.close();
774	} catch (IOException e) {
775	//ignore
776	}
777	}
778	}	770	}
779	return null;	771	return null;
780	}	772	}
Lines 2077-2094 Link Here
2077	}	2069	}
2078		2070
2079	private static String getHTMLContent(IJarEntryResource jarEntryResource, String encoding) throws CoreException {	2071	private static String getHTMLContent(IJarEntryResource jarEntryResource, String encoding) throws CoreException {
2080	InputStream in= jarEntryResource.getContents();	2072	try (InputStream in = jarEntryResource.getContents()) {
2081	try {
2082	return getContentsFromInputStream(in, encoding);	2073	return getContentsFromInputStream(in, encoding);
2083	} finally {	2074	} catch (IOException e) {
2084	if (in != null) {	2075	// ignore
2085	try {	2076	return null;
2086	in.close();	2077	}
2087	} catch (IOException e) {
2088	//ignore
2089	}
2090	}
2091	}
2092	}	2078	}
2093		2079
2094	private static String getHTMLContentFromAttachedSource(IPackageFragmentRoot root, IPackageFragment packageFragment) throws CoreException {	2080	private static String getHTMLContentFromAttachedSource(IPackageFragmentRoot root, IPackageFragment packageFragment) throws CoreException {
Lines 2154-2187 Link Here
2154	} else {	2140	} else {
2155	packagedocPath= filePath;	2141	packagedocPath= filePath;
2156	}	2142	}
2157	ZipFile zipFile= null;	2143	try (ZipFile zipFile= new ZipFile(file, ZipFile.OPEN_READ)) {
2158	InputStream in= null;
2159	try {
2160	zipFile= new ZipFile(file, ZipFile.OPEN_READ);
2161	ZipEntry packagedocFile= zipFile.getEntry(packagedocPath);	2144	ZipEntry packagedocFile= zipFile.getEntry(packagedocPath);
2162	if (packagedocFile != null) {	2145	if (packagedocFile != null) {
2163	in= zipFile.getInputStream(packagedocFile);	2146	try (InputStream in= zipFile.getInputStream(packagedocFile)) {
2164	if (encoding == null)	2147	if (encoding == null)
2165	encoding= getSourceAttachmentEncoding(root);	2148	encoding= getSourceAttachmentEncoding(root);
2166	return getContentsFromInputStream(in, encoding);	2149	return getContentsFromInputStream(in, encoding);
		2150	}
2167	}	2151	}
2168	} catch (IOException e) {	2152	} catch (IOException e) {
2169	throw new CoreException(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), e.getMessage(), e));	2153	throw new CoreException(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), e.getMessage(), e));
2170	} finally {
2171	try {
2172	if (in != null) {
2173	in.close();
2174	}
2175	} catch (IOException e) {
2176	//ignore
2177	}
2178	try {
2179	if (zipFile != null) {
2180	zipFile.close();//this will close the InputStream also
2181	}
2182	} catch (IOException e) {
2183	//ignore
2184	}
2185	}	2154	}
2186	}	2155	}
2187	}	2156	}