[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [virgo-dev] PDE2Virgo Plugin

Hi GianMaria
 
Sorry for my delayed reply.
 
I went over your code changes on featue/329198 branch and so far from what I have seen they look ok. Some methods (e.g.: org.eclipse.virgo.ide.pde.core.internal.Builder#buildFilesInFolder()) look a bit huge at first glance. These could be split up for better readability and understandability.
 
I also installed build #6 from virgo.ide.snapshot.on.branch ci-job, created a server runtime together with a target platform. This worked well although, I first tried 3.7.0 virgo-kernel build which seems not to be yet supported by the tooling. I then downloaded 3.6.4 virgo-kernel and created a new "PDE Bundle Project", also this worked well. I also tried to add an OSGI-INF folder, but here I was also required to add it to the Bundle-Classpath header, otherwise the tooling would just ignore it and this folder is not deployed to the satging directory. Should I file a bug for this?
 
What I also found is that when I open the Server Editor for Virgo and activate both check boxes (Tail applicationtrace files into console view & Start server with -clean option) under "Server Startup Configuration", nothing happens. The server is not started using -clean option nor the application trace files are appended to console view. Did you also exprierenced this when you use the tooling?
 
Regards,
Dani
 
Gesendet: Montag, 04. Januar 2016 um 09:51 Uhr
Von: Giamma <gm.romanato@xxxxxxxxx>
An: "Virgo Project" <virgo-dev@xxxxxxxxxxx>
Betreff: Re: [virgo-dev] PDE2Virgo Plugin
Ciao Daniel,

Happy new year!

It should work, if it doesn't it's a defect.  The plug-in copies resources into the bin folder during build. As a workaround you can try to list the osgi-inf folder in the bundle-classpath header. 

Few days ago I pushed to branch feature/329198 the integrated pde2virgo. It would be great if you were still available for a code review. 

It would be great if you alsohad time to test it a bit. No documentation at the moment yet, but the commit comment lists all changes. The builder and nature identifiers have changed because of the new plug-in name, so it cannot work with an existing project unless the  .project  file is edited. 

GianMaria 
 
Il giorno Lun 4 Gen 2016 07:43 Daniel Marthaler <DMarthaler@xxxxxxx> ha scritto:
Hi GianMaria,
 
First of all, happy new year ;)
 
Just exprienced that when I use PDE2Virgo Plugin and having a OSGI-INF folder in my project, this OSGI-INF is not getting deployed to the server runtime although it has been included in "bin.includes" in the build.properties file of my PDE project. If I understand PDE2Virgo correctly this should be handled by PDE2Virgo Plugin, is this correct?
 
Regards,
Dani
 
_______________________________________________
virgo-dev mailing list
virgo-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/virgo-dev
_______________________________________________ virgo-dev mailing list virgo-dev@xxxxxxxxxxx To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/virgo-dev