[virgo-dev] Virgo test framework - @BundleDependencies question

[Dmitry Sklyut <dmitry@xxxxxxxxxxx>]

Hi,

BundleDependencies annotation can be used to specify extra bundles needed by the specific test case.

This is cleaner than specifying all entries in the test.config.properties or in org.eclipse.virgo.kernel.userregion.properties.

One thing that is missing - code in OsgiTestRunner.addUserConfiguredBundles does not account for "auto-start" setting.

That is, adding "@start" at the end of the uri.

The change is trivial, but I wonder if the BundleDependencies annotation should be changed to provide a flag to auto-start to match

org.eclipse.virgo.osgi.launcher.parser.BundleEntry.

With this change BundleDependencies can be changed like this:

<code>

@Retention(RetentionPolicy.RUNTIME)

@Target(ElementType.TYPE)

public @interface BundleDependencies {

BundleEnty[] value();

}

@Retention(RetentionPolicy.RUNTIME)

@Target(ElementType.TYPE)

public @interface BundleEnty { 

    String value();

    boolean autoStart() default false;

}

</code>

So the choice is between a flag and parsing of the uri to look for "@start" at the end of the location string.

Thoughts?

Regards,
Dmitry