[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [virgo-dev] Re: snaps checked in

Thanks Florian! I have created a "virgoisation" branch to carry your changes and Dmitry's so we can get to a stable point (build successful at least) before merging into master.

I cannot push your changes without your confirmation in the bug that you wrote 100% of the changes to the script and that you have the right to contribute those changes to Eclipse. Please could you add this?

Glyn
On 20 Jul 2010, at 13:35, Florian Waibel wrote:

> I created the bug as requested: https://bugs.eclipse.org/bugs/show_bug.cgi?id=320382
> 
> Regards,
>  florian
> 
> 
>> To keep the IP process simple, it would be great if Florian could raise a bugzilla and attach "0001 patch" since that is his work. Florian, is that possible?
>> 
>> In view of the due diligence process [1], both you and Florian should confirm in the bugzillas that you wrote 100% of the code you contributed, that you have the right to contribute the code to Eclipse, and that any new Java files contain the appropriate License header.
>> 
>> Thanks,
>> Glyn
>> [1] http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf
>> 
>> On 16 Jul 2010, at 19:40, Dmitry Sklyut wrote:
>> 
>> I would like to follow Florian's example.
>> 
>> Attached are a set of patches to get Snaps building against 2.1.0.M02-incubation of virgo and 1.1.0.M02-incubation of gemini-web.
>> 
>> I got it to the point that simple-host + spring-snap get deployed and bound.  From my experience with Slices - there are still 2/3 issues that need to be fixed before it is usable.  I will look into creating patches for those once this set is settled.
>> 
>> To test:
>> 
>> apply patches.
>> cd build-snap
>> ant clean clean-integration test package
>> cp target/package-expanded/snaps-1.0.0.BUILD-${localbuildtime}/repository/usr/* $virgo_home/repository/usr
>> modify $virgo_home/config/org.eclipse.virgo.kernel.userregion.properties to add snaps to the list of initialArtifacts (not sure if this is necessary, maybe dropping a plan in pickup is enough)
>> Example:
>> initialArtifacts=repository:plan/org.eclipse.virgo.kernel.userregion.springdm, repository:plan/org.eclipse.virgo.web, repository:plan/org.eclipse.virgo.snaps
>> 
>> Start webserver.
>> 
>> cp $snaps/org.eclipse.virgo.snaps.test/src/test/resources/simple-host.war  to $virgo-home/pickup/
>> Test:
>> http://localhost:8080/simple-host
>> 
>> cp $snaps/org.eclipse.virgo.snaps.test/src/test/resources/spring-snap.jarr  to $virgo-home/pickup/
>> Test:
>> http://localhost:8080/simple-host/spring/s/withViewName
>> http://localhost:8080/simple-host/spring/s/write
>> 
>> 
>> Note on patches:
>> 0005 and 0006 should have been single - but I forgot to git add . before committing
>> 0001 patch is basically application of everything that Florian attached to this email thread.
>> 
>> I also bumped version of virgo-build to align with other virgo components (took version from virgo.web one - hope it is right).
>> 
>> Let me know if I should create a Bugzilla issue to track this.
>> 
>> Regards,
>> 
>> Dmitry
>> 
>> 
>> On Fri, Jul 9, 2010 at 11:32 AM, Florian Waibel <fwaibel@xxxxxxxxxxxxxxxxx<mailto:fwaibel@xxxxxxxxxxxxxxxxx>> wrote:
>> Hi,
>> 
>> this time i tried a little harder.
>> But didn't get past a Tests failed (crashed) in the snaps.test project.
>> I guess i missed something essential.
>> 
>> In case someone else is trying to migrate snaps i added the updated virgoise.sh.
>> 
>> I'll investigate the problem next week. If someone else could have a closer look, too that would be a great
>> timesaver i guess...
>> 
>> Thanks,
>> florian
>> 
>> 
>> 
>> On Jul 7, 2010, at 3:43 PM, Glyn Normington wrote:
>> 
>>> Hi Florian
>>> 
>>> Thanks very much for spotting that "slice" which slipped through the net! I've fixed that ([1] with an acknowledgement to yourself) and another that showed up via:
>>> 
>>> ls -lR | grep slice
>>> 
>>> The invitation to get the slices code working on top of Virgo instead of dm Server is still open. :-)
>>> 
>>> Glyn
>>> [1] http://git.eclipse.org/c/virgo/org.eclipse.virgo.snaps.git/commit/?id=b3494fc78bf727f45c55d4e25f8de335918b6490
>>> On 7 Jul 2010, at 13:05, Florian Waibel wrote:
>>> 
>>>> Hi,
>>>> 
>>>> i followed your invitation :)
>>>> 
>>>> #!/usr/bin/env bash
>>>> dir=`dirname $0`
>>>> dir=`cd $dir;pwd`
>>>> 
>>>> for f in $(find . -iname "*.java" -or -iname "*.aj" -or -iname "*.xml" -or -iname ".project" -or -iname "*.MF" -or -iname "*.mf" -or -iname ".prefs"  -or -iname ".classpath" -or -iname "build.versions" -or -iname "*.properties" -or -iname "*.bat" -or -iname "*.sh" -or -iname "*.conf" -or -iname "*.profile" -or -iname "*.config" -or -iname "*.plan" -or -iname "runner.bundles")
>>>> do
>>>> 
>>>> sed -i -e 's/SLICES_IVY_CACHE/SNAPS_IVY_CACHE/g' $f
>>>> sed -i -e 's/SLICE_/SNAP_/g' $f
>>>> sed -i -e 's/SLICES_/SNAPS_/g' $f
>>>> sed -i -e 's/slice\.simple/snap\.simple/g' $f
>>>> 
>>>> rm $f-e
>>>> done
>>>> 
>>>> One "missed" refactoring in project test-apps/simple-snap:
>>>> 
>>>> #mkdir -p test-apps/simple-snap/src/main/java/snap/simple
>>>> #mv test-apps/simple-snap/src/main/java/slice/simple/*java test-apps/simple-snap/src/main/java/snap/simple
>>>> #rmdir test-apps/simple-snap/src/main/slice/simple
>>>> 
>>>> I don't know about the $dir/update-dependency.rb commands. So those lines are missing...
>>>> 
>>>> Regards,
>>>> florian
>>>> 
>>>> --
>>>> Florian Waibel
>>>> EclipseSource
>>>> Email: fwaibel@xxxxxxxxxxxxxxxxx<mailto:fwaibel@xxxxxxxxxxxxxxxxx>
>>>> Tel: +49-721-66-47-33-0
>>>> Fax: +49-721-66-47-33-29
>>>> http://www.eclipsesource.com/
>>>> ========================= Legal Disclaimer =================================
>>>> According to Section 80 of the German Corporation Act
>>>> Innoopract Informationssysteme GmbH must indicate the following information:
>>>> Address: Stephanienstrasse 20, 76133 Karlsruhe Germany
>>>> General Manager: Jochen Krause
>>>> Registered Office: Commercial Register Mannheim HRB 107883
>>>> ============================================================================
>>>> 
>>>> On Jul 7, 2010, at 9:53 AM, Glyn Normington wrote:
>>>> 
>>>>> Oh, I should also have mentioned the slices->snaps migration notes:
>>>>> 
>>>>> http://wiki.eclipse.org/Virgo/Community#Migrating_from_the_dm_Server_slices_prototype_to_the_Virgo_snaps_prototype
>>>>> 
>>>>> Glyn
>>>>> On 6 Jul 2010, at 19:02, Glyn Normington wrote:
>>>>> 
>>>>>> I've checked in snaps to Eclipse git. See [1] for the location.
>>>>>> 
>>>>>> The only changes I've made compared to the slices prototype is to uniformly rename "slices" to "snaps" (including the singular and other capitalisations), to re-package the code to org.eclipse.virgo packages, and to get this building cleanly with Virgo build. It still has dm Server pre-reqs and needs "virgoising" (the virgoise.sh shell script in the web server repo provides a good starting point).
>>>>>> 
>>>>>> If anyone would care to provide a patch to get this working with Virgo, please be my guest.
>>>>>> 
>>>>>> Glyn
>>>>>> 
>>>>>> [1] http://wiki.eclipse.org/Virgo/Source#Virgo_git_Repositories
>>>>> 
>>>>> _______________________________________________
>>>>> virgo-dev mailing list
>>>>> virgo-dev@xxxxxxxxxxx<mailto:virgo-dev@xxxxxxxxxxx>
>>>>> https://dev.eclipse.org/mailman/listinfo/virgo-dev
>>>> 
>>> 
>> 
>> 
>> _______________________________________________
>> virgo-dev mailing list
>> virgo-dev@xxxxxxxxxxx<mailto:virgo-dev@xxxxxxxxxxx>
>> https://dev.eclipse.org/mailman/listinfo/virgo-dev
>> 
>> 
>> <0001-commiting-changes-from-Florian-Waibel-patches-sent-t.patch><0002-Update-versions-of-dependencies-and-virgo-build-vers.patch><0003-update-virgo-build-to-the-same-version-as-virgo.web.patch><0004-align-version-of-virgo-build-with-other-virgo-compon.patch><0005-upgrade-snaps-to-use-2.1.0-integration-dependencies.patch><0006-upgrade-snaps-to-use-2.1.0-integration-dependencies.patch><0007-change-log-even-prefix-to-match-messages.patch><ATT00001..txt>
>> 
>> _______________________________________________
>> virgo-dev mailing list
>> virgo-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/virgo-dev
> 
> _______________________________________________
> virgo-dev mailing list
> virgo-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/virgo-dev