|
On 03/11/2013 05:40 PM, Max Rydahl
Andersen wrote:
On Mon, Mar 11, 2013 at 05:18:23PM +0100, Mickael
Istria wrote:
On 03/05/2013 04:51 PM, Igor Fedorenko
wrote:
https://git.eclipse.org/c/tycho/org.eclipse.tycho.extras.git/tree/tycho-buildtimestamp-jgit/src/main/java/org/eclipse/tycho/extras/buildtimestamp/jgit/JGitBuildTimestampProvider.java?id=tycho-extras-0.16.0#n82
I'll be willing to review a quality patch... but if somebody
with good
jgit knowledge did that it'd be even better.
What would you think about the following approach:
1. In case tree is dirty, JBitBuildTimestampProvider returns
null
2. In case the timestamp provider returns null, tycho-packaging
plugin would use "SNAPSHOT" instead of the timestamp string
?
wouldn't it be better with <jgittimestamp>SNAPSHOT then ?
This would require to have an additional output to the timestamp
provider interface to get the status of the timestamp (something
like an "isDirty" method or flag).
Igor, Jan, Tobias, anyone, what would you think of one or the other
approach?
|
